From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 919D4C54EE9 for ; Thu, 22 Sep 2022 11:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230235AbiIVL5A (ORCPT ); Thu, 22 Sep 2022 07:57:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbiIVL46 (ORCPT ); Thu, 22 Sep 2022 07:56:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67D11A1D66 for ; Thu, 22 Sep 2022 04:56:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663847816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oXHxih+IbJlBpItUiUsNTieYvbvInNzPCfL2NlPaMU8=; b=ZWQ7Z9fAMGJkS7tAA9YCM/sLa7lVluO+jyMlyLaqYNeKYUS4z5dRppzN/lAjxYoRQl+bgz 6+PddmZGlOI9X/LUOH7xWHTjk0dqvPhLxhGhJUovuSGhs7cQiGkhc916y3VVIb1/lU4H6J 8txlCHXuppWqkQ6eIFy97V+7pCNLkVk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-572-DdNE36QCNrOPn7uiAkMj1Q-1; Thu, 22 Sep 2022 07:56:49 -0400 X-MC-Unique: DdNE36QCNrOPn7uiAkMj1Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AEFAA101E14E; Thu, 22 Sep 2022 11:56:48 +0000 (UTC) Received: from [10.22.33.6] (unknown [10.22.33.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 71F60140EBF5; Thu, 22 Sep 2022 11:56:47 +0000 (UTC) Message-ID: <5da6ff25-bf96-743b-8d5c-152838044ecf@redhat.com> Date: Thu, 22 Sep 2022 07:56:47 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v9 0/7] sched: Persistent user requested affinity Content-Language: en-US To: Peter Zijlstra Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Tejun Heo , Zefan Li , Johannes Weiner , Will Deacon , linux-kernel@vger.kernel.org, Linus Torvalds , Lai Jiangshan References: <20220916183217.1172225-1-longman@redhat.com> From: Waiman Long In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/22/22 04:45, Peter Zijlstra wrote: > On Fri, Sep 16, 2022 at 02:32:10PM -0400, Waiman Long wrote: > >> Waiman Long (7): >> sched: Add __releases annotations to affine_move_task() >> sched: Use user_cpus_ptr for saving user provided cpumask in >> sched_setaffinity() >> sched: Enforce user requested affinity >> sched: Introduce affinity_context structure >> sched: Handle set_cpus_allowed_ptr() & sched_setaffinity() race >> sched: Fix sched_setaffinity() and fork/clone() race >> sched: Always clear user_cpus_ptr in do_set_cpus_allowed() > I still think this is ordered all wrong. Esp. with that affinity context > doing the right thing isn't onerous at all. > > So please, re-order this and fold all fixes back in so that it becomes > a sane series. Basically patches 5 and 6 shouldn't exist, they fix > issues created by the earlier patches. > Thanks for the suggestion. Will rework the series as suggested. Cheers, Longman