From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E2FA3921D6 for ; Tue, 30 Jun 2026 05:30:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782797450; cv=none; b=W9TO2K2M8no9yq+YuKfPSIYLZGTZiqd0+PRlZKzs+4b16p1eekAJF6vNAeTr55ACDs8zkd1cqRO5mnFF47pm85faqD0fC7cmPe7Y4RsKR6RnljvrA1xTH9KdsklSB4VUydL8P/imab3ZqljEofCUJmIQEDhXTzw9lOTif5fUcXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782797450; c=relaxed/simple; bh=AMbCfl1TqOeipjOiTdE0+IqDoXL9fNroA+PH+fRuGzw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NUh9WqfbpFyP9enj3fddbIcSWeG6NldBFDXaQbNkBHIgy4A+Q0QnIxqCfgP2FXhMRHGIM0YumhzUbRJMw+l67RahxZkjPJL0KkK9jVg4dUh6i0ME8PT4lKvXf+HPu4j3XT894nbG6LJvToES9wBaNys9qoLXdC8A9NZc/t6dV4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cZl9E8Ps; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A34YschW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cZl9E8Ps"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A34YschW" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U1ImK4437820 for ; Tue, 30 Jun 2026 05:30:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WhiYGokexxUvHxryATmlhdYY6XJnEz/snuGmeXg93hw=; b=cZl9E8PsrXl9QgCL jh31zWrJCAL8BAjCgp6BFt9K0QiFrtIWvjI9E6Lo18MFhpybP+cfEla8/C09rRPF 5dbqoZ1DlXwbkOflsm8YA994DYvVNq95aYnGDx9ywP3WryxDrGzaG1aKv0h+Y8dR j3NP9NpWHUIL4V6OSwULCyUKQGGMboNHYrXT4MDScqy1yTTEkiMvdecm2wdMWx3w l+WAYl7Ao4vJezHEv0DiR/xLkbv5C8hUASKS/l8wtqYc5hp+vUSYOm3dbY2tBCpW ikzbjklRP5NT81SVHd2/d8XES/ASALckAB8rN3FHOez4syhh/aKynuO4vHK+X944 f9xjNA== Received: from mail-dl1-f69.google.com (mail-dl1-f69.google.com [74.125.82.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3qhabyve-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 05:30:48 +0000 (GMT) Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-139c6673856so6352912c88.0 for ; Mon, 29 Jun 2026 22:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782797447; x=1783402247; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WhiYGokexxUvHxryATmlhdYY6XJnEz/snuGmeXg93hw=; b=A34YschWm9+uuk7NcgJnjH3l0Vma46ShVH33wlhvTsxkFCaGEZR/GrmRUwvMUi71Sz ibUCJ8oLcZzRfU2rkMmqn12fjYLrWeW1m7f/QhyfoWax80GvAJB16SGhZ1nZASFFVzDq IvFbXJwP/ZxSJ6SRKwNFU9MO1Fd6zkZwLU+R7QkA2H217YCczGlLvYghdv0hca4iD8O9 Mv8ubyWUDF759YwGR07+flIEP55y+OSYlk/7uAnuY2XBLOX4lvMPIykJUz6PD7dpR7NC 4DtXxlfmLxCbiTtOOZwqkA9KvYr5iZMOSbLQcGsOVyiZD+Lve+BuJsFIE/WvGJNXxIB/ 3cCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782797447; x=1783402247; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WhiYGokexxUvHxryATmlhdYY6XJnEz/snuGmeXg93hw=; b=JmhzfuzLRs0HgwINQy3P0I4QGwtdRvTzFL0/eL5xikVfwHfk673yP3Kv73Gme99v7G 8tiBlvdlG1duVlocDDAVOwOo2GfsTVINe88aK/86lboKYgHfMMxaE9dA8VKl3yaElOJC /DpDlCIbjt4lqwoySODLGh/xx7pYKtYWuJxkWQX/2Z4ces9RuXoBWY/+AQdCxUEcjEU9 jQhttYm8nrCdVK/y8+9vd+GqkV8X84kRz6hX7aP4p7x0hNq3LgNnbXQTv9zU8krtxx6t JVdaWPXn590daw0hFvRRACkwQZlS62MUkb68/8hDTvFVSo/vOFuazz07L5Kv7KAoZez1 u4SQ== X-Forwarded-Encrypted: i=1; AHgh+RrC38H9sg4DD9VPAGyR5UBu2ZTjLz2/Lxq0iTnhCqftNBMTdTeHzoKffojWDrw3tEzhmJ2h9zqXeFGzmx8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzbwf0lxl4NXRQ7XBVLaf9ScZeJ0AdH9nclZ3wK08Sh6WmyVpK6 mFE7dWtEKAZe/XydPxX0ZdQMr9OBaLHrh+J02B0vGC6pM6Wo1gaUQwtW3Z0WobWmNZLYxpic9+K 9ukcsmrjFJH7dtuyw370dltg1H6i7B7mLHkP6l4FQ33lu3Ek33Xz9ZlZAqt3Fypc22gU= X-Gm-Gg: AfdE7clEJbSq6tqwQRsl+YffsWH71RhaIrqRDHJ7Pxr2KRqrMwZ99KxgcnEpRVBu+9j uybNqk9LpL+eZIbuslysJjEgfLm1XiGSHT4nVX1PN5L2vyEwqyxEDK4R+2bHk8sqj4ms3toIWcE U3ne85KWbJzM92EhWgZCC7D0AIfOXb75KJc/sEnfm4IrvUYcpkdDWu3x/I7kiEA9F4DL/0klSEY py3sJ2CZD1CzeRNC+KReVkERNfyqm5vKq0nqNDqVCxzQB1Z3Xw6eKaseJ6rTVLftkBPr/TGDqmU ldu7+igAsJVHCcOeqBejS8icCyGuR7bods1GcoDZrnwqnUsRx40WO29+cSMG7nrT/7QUq3hnG/1 diEWTNxDmzNiv8esIcvaig6oro1HRrwzvqvAzll4P8t6DvXcYEtuS+y6zUn5dPd+GlxSxjCpORm du60bElILxRKIzoWTIgiLMq4wi7LY= X-Received: by 2002:a05:693c:3b09:b0:30b:bda8:a70b with SMTP id 5a478bee46e88-30ee12bf278mr1453048eec.4.1782797446901; Mon, 29 Jun 2026 22:30:46 -0700 (PDT) X-Received: by 2002:a05:693c:3b09:b0:30b:bda8:a70b with SMTP id 5a478bee46e88-30ee12bf278mr1453031eec.4.1782797446349; Mon, 29 Jun 2026 22:30:46 -0700 (PDT) Received: from [10.242.229.199] (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.19.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30ee2cd21bcsm6404411eec.0.2026.06.29.22.30.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 22:30:45 -0700 (PDT) Message-ID: <5dae2ab9-76ef-4516-b21d-80729bf7ed79@oss.qualcomm.com> Date: Tue, 30 Jun 2026 11:00:41 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform: arm64: qcom-hamoa-ec: Register cooling devices with their name To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: Sibi Sankar , Hans de Goede , Bryan O'Donoghue , Konrad Dybcio , Dmitry Baryshkov , Maya Matuszczyk , linux-arm-msm@vger.kernel.org, platform-driver-x86@vger.kernel.org, LKML References: <20260629-fix_cooling_device_register-v1-1-c6e518b0bbd4@oss.qualcomm.com> <48334852-b131-d6a0-469f-09e15d6765d5@linux.intel.com> Content-Language: en-US From: Anvesh Jain P In-Reply-To: <48334852-b131-d6a0-469f-09e15d6765d5@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: W2wGFc4HlAnruexM_5xoeY9vAQdctUoG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDA0MiBTYWx0ZWRfX8OFeD4lVlkNs BLBNGpz3y8ACBdmbjqiluEzYj4p3OS+ycMv/XYjSNWlKzK+R2qWzHUtRR/sWxfUHHdpRDDwuglk 7SEvqSrZEMvX0EMbsRHkuO76KvTeJi/vO6/FkOG+3U/sNq1v49da6doT76FGPN9j22q6LEwl+Wh YDS4qqjRWiYKkswLaJLYTKjtSn7JHVdu0PqP9KdZMvZDzdOnqRFKoTA6LqeMacrGwXfqMprlSZw 1MRkDnAN11iFyLS00HI9Mkf0Qa1GqywtEIEii4wYj8wT+rhutlPPu2fShns5XHIWdQI9aj3KkPF EIENfi8g4nYqGpa7Ipb88FPM+e8Hxgv5tN0T3TaO4z31wJBQkLfMuO1xBQAVPBKOU378Qba4uRp nThRBgw/sVkX5MCdRLqeMjEw1NcMNNHnrORjE6zw6nWKpIwX5C2ppbPSe65wRouACb6jEg8ejMB x1NpFwMqFSAGjijH89Q== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDA0MiBTYWx0ZWRfX/52fQHx3GnPr fdtZ+yYORSvcwC4Xu1xHsqCCsEq/WmdTsbXz0+fL5hTDaAUrFs1iKx5pkbRKIM1ez5gNrZOL4sS 4Y4vwSL4E80f0ozexOxPibHgQw2zkwA= X-Authority-Analysis: v=2.4 cv=O9UJeh9W c=1 sm=1 tr=0 ts=6a435488 cx=c_pps a=kVLUcbK0zfr7ocalXnG1qA==:117 a=3ivmCuETaj/XXnlAhr/wyw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=sTVR4Ors8kAh6zT4N6oA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=vr4QvYf-bLy2KjpDp97w:22 X-Proofpoint-ORIG-GUID: W2wGFc4HlAnruexM_5xoeY9vAQdctUoG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300042 On 6/29/2026 6:03 PM, Ilpo Järvinen wrote: > On Mon, 29 Jun 2026, Anvesh Jain P wrote: > >> Each fan is registered as a thermal cooling device using >> devm_thermal_of_cooling_device_register(). When the thermal core gained >> cooling device ID support, the helper's prototype changed: its second >> argument became a 'u32 cdev_id' and its third a 'const char *type', >> replacing the previous 'struct device_node *np'. >> >> The resulting semantic conflict between the EC driver and the reworked >> thermal helper was resolved while merging the drivers-x86 tree into >> linux-next by passing NULL as the 'type' argument, dropping the per-fan >> 'name' string. As a result every fan is registered as a cooling device >> with an empty name. >> >> Pass 'name' as the 'type' argument so the cooling devices are registered >> with their intended "qcom_ec_fan_" names. >> >> Fixes: 5c44f48e91de ("platform: arm64: Add driver for EC found on Qualcomm reference devices") >> Signed-off-by: Anvesh Jain P >> --- >> drivers/platform/arm64/qcom-hamoa-ec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/arm64/qcom-hamoa-ec.c b/drivers/platform/arm64/qcom-hamoa-ec.c >> index 45829f2786b7..12196d56b60e 100644 >> --- a/drivers/platform/arm64/qcom-hamoa-ec.c >> +++ b/drivers/platform/arm64/qcom-hamoa-ec.c >> @@ -391,7 +391,7 @@ static int qcom_ec_probe(struct i2c_client *client) >> ec_cdev->fan_id = i + 1; >> ec_cdev->parent_dev = dev; >> >> - ec_cdev->cdev = devm_thermal_of_cooling_device_register(dev, 0, NULL, ec_cdev, >> + ec_cdev->cdev = devm_thermal_of_cooling_device_register(dev, 0, name, ec_cdev, >> &qcom_ec_thermal_ops); >> if (IS_ERR(ec_cdev->cdev)) { >> return dev_err_probe(dev, PTR_ERR(ec_cdev->cdev), >> >> --- >> base-commit: 948efecf22e49aa4bf55bb73ec79a0ddcfd38571 > > $ git log 948efecf22e49aa4bf55bb73ec79a0ddcfd38571 > fatal: bad object 948efecf22e49aa4bf55bb73ec79a0ddcfd38571 > > Please don't base your submissions on some random commits. There has never > been code with (dev, 0, NULL, ...) in platforms drivers tree (and neither > in Linus' tree). > You're right. I based this on a linux-next snapshot; the (dev, 0, NULL, ...) form only existed transiently as a merge-conflict fixup there and never in the platform-drivers or Linus' tree. Current linux-next already registers the fans with 'name' via devm_thermal_of_child_cooling_device_register(), so the issue is gone. I'll drop this patch. -- Best Regards, Anvesh