From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCF842D47E6; Wed, 11 Mar 2026 19:15:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773256556; cv=none; b=ZKDnIw5xHWx0TeQA6kjYx2Us3DDSUYqKEAl4PZRcWs84HA6tjEMSiCDzW5mOVJsrb1bnNnOnBgFTkr0q/Q6xSZ2G8P7Zq4DgYDz+GCanvs5e3LmMwMWTgSH8qsHH4LFNNXclSR5ExpnKiS87Pc+pD8nis02QKHLt/1lyhAsKNDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773256556; c=relaxed/simple; bh=gwh9ZtQJ8T4eqca8LnY4EHjsnKJyybWcR2U7kLlgdAA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EgpiON26fX4vqLmYcSkTZpnl0Ut5JGOG1r9lT6nHT14J+UOiFKnU2y1uhGkag+oUy1aIBhDISLYffbkR4oqjsYHLS1s+W7gY/gOdxlqUMM9vM+62Ek8/HRcuJXO/MharJC/asDm3CoFeLASl2CO2v9GDpRDEs8o41icDP/Fjegg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=AC3Rxeav; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="AC3Rxeav" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=tmKJz4PTXeSP3DIMaLWnUAhuXvl8uJw/wenH2e9XHUg=; b=AC3RxeaviT2nq9ifbCFtg7D8ye nyNyvB4SOixmyd7Jnw374vliShdGmRuMl3EH8V1+USm+BUia6DHGQYFuvR1xF5Z6+xBJ2dn3ZMjT4 wVJKP3D+4darksEJftGdlRfNL+O1PEYluNPY2Y7O0wM31lLU2HLZ5OBNJCiG+HjDPnj4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1w0P24-00BE63-D4; Wed, 11 Mar 2026 20:15:48 +0100 Date: Wed, 11 Mar 2026 20:15:48 +0100 From: Andrew Lunn To: Oliver Neukum Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1 net-next] net: usb: cdc-ether: unify error handling in probe Message-ID: <5db41b5a-c53f-4441-bf4e-a12add3e33b4@lunn.ch> References: <20260311112919.678686-1-oneukum@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260311112919.678686-1-oneukum@suse.com> > @@ -288,16 +288,11 @@ int usbnet_generic_cdc_bind(struct usbnet *dev, struct usb_interface *intf) > if (info->data != info->control) { > status = usb_driver_claim_interface(driver, info->data, dev); > if (status < 0) > - return status; > + goto bad_desc; > bad_desc: > dev_info(&dev->udev->dev, "bad CDC descriptors\n"); > - return -ENODEV; > + return status; Always reporting "bad CDC descriptors" does not seem correct. Not being able to claim the interface is probably some other sort of problem. It might be better to change the dev_dbg()s to dev_err()s, and drop the dev_info() here. You can then add additional dev_err() before the goto's you are adding. Andrew --- pw-bot: cr