From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Lee Jones" <lee@kernel.org>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH v2] firmware: exynos-acpm: Drop fake 'const' on handle pointer
Date: Sun, 1 Mar 2026 13:09:34 +0100 [thread overview]
Message-ID: <5db42200-bfeb-4e20-9864-244ecb0894cc@kernel.org> (raw)
In-Reply-To: <279baf9e-ef05-4217-9357-94d21bd93978@linaro.org>
On 25/02/2026 15:00, Tudor Ambarus wrote:
>>> static const struct acpm_ops exynos_acpm_driver_ops = {
>>> .dvfs_ops = {
>>> .set_rate = acpm_dvfs_set_rate,
>>> .get_rate = acpm_dvfs_get_rate,
>>> },
>>> .pmic_ops = {
>>> .read_reg = acpm_pmic_read_reg,
>>> .write_reg = acpm_pmic_write_reg,
>>> // ... other ops
>>> },
>>> };
>>>
>>> and in probe:
>>> acpm->handle.ops = &exynos_acpm_driver_ops;
>>>
>>> This way, the handle safely reflects the mutability of its container,
>>> but our function pointers remain fully protected.
>>
>> Yes, this makes sense.
>>
>
> Will you come with a follow up patch or do you want me to ACK this and do
> the follow up patch myself? Both options are fine by mine.
Go ahead with implementing this idea. I cannot test it anyway, so better
if you do it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-01 12:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 10:42 Krzysztof Kozlowski
2026-02-24 12:57 ` Tudor Ambarus
2026-02-25 10:48 ` Krzysztof Kozlowski
2026-02-25 14:00 ` Tudor Ambarus
2026-03-01 12:09 ` Krzysztof Kozlowski [this message]
2026-02-28 14:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5db42200-bfeb-4e20-9864-244ecb0894cc@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®