From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51A88350287 for ; Tue, 27 Jan 2026 16:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769530341; cv=none; b=Jl4WdERjIuUHeJR0COdoDNEdIVvbuPLA8soQA2nvR4IoT864dQ8cYt42LONlQhagM+1qLCu+3aGzIHlQFv7xLwS+jDAIGce9g3OKxR4Kdi1g9/MQ9FaZUyJykzdVvt6AH0oZ4X+eHInL6lyE1r1Uf1tZiFDlKNiNARHPkyDz1D0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769530341; c=relaxed/simple; bh=oqoBow5D3lG837WMPctNSJeeKyxHDiuyOmPTM74O8P4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AID0XR+4+JIRyvmM7WRlvaZpCyHtI19wkaiepqQqfCQRLjnBU0MuWDJi9JuxsTc5QlMZ2ZZHQucBHQl4wlH51j+Yu7ZA+XgAQWdykkR4e1QH+Bn9qyFBfXStq2p/z+d3z4SZwGRYSH+jHrV/rAH+WsVHePZmh+xbPCTYpzDfmNA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GJAIbMUH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NhhxR+Ok; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GJAIbMUH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NhhxR+Ok" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60RAb2Id700433 for ; Tue, 27 Jan 2026 16:12:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +SEkQgEJt3XSj0HPB4DBICRq/bSP9m3nTqv1wEUO5dM=; b=GJAIbMUHFANji3ap dyADZWwk/CEa7ZGm9UCid41ymVZz4hGg4hfqBNB42fBmRdDjCIh5VNBUIb4ve0qs p3dTlTyDsZuys78RnhGekkxdY+8c6f6hoshS1MnaLtEUIZADDXbhvwluz6+8KCvO NmbA+mCHSWFpL6OThICAew5btI2UHhJxDTHWMre9fSdy6G2enoZGK7Q1/8OzIIV3 HniesAz+JYlBTXi+Cvb5aFkzatkrlbOtNNPR9V9NDJU2tivTdy6XaeIgUYgZcvjo AZFUJXTvGVtX62C9uhnwqvbeFavPe+p9jA+f2gnH5ulAYXOaAwY2mXXPC+KqPhm+ V/1vVw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bxew3uhd5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 16:12:19 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-352e214cce9so4263792a91.1 for ; Tue, 27 Jan 2026 08:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769530338; x=1770135138; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+SEkQgEJt3XSj0HPB4DBICRq/bSP9m3nTqv1wEUO5dM=; b=NhhxR+OkOrgzWu7z3y87J/LuwSmpA8A3Xkd3Pl+rSQhS/q1CTLpBATRqH1PX9Azpu3 wF+TvmkxONkzbxjL4Vqq43q3+/yFOlFlrUWhBhjaD3gYWrwAJstMz+wPgY/40NPhW1PD lfzrlMhROQWU7o4DC9kZtBiQP4EzTSQDlIhP4UY+iQ+h0XDOkeP6C5AC/n/SjmkW2pQU FzqjbLN/cFWjO+WRqi1ZVlrggSx5AOlTL4vb5zDWtSX8DVe9V8oWr0izEF/DnwVSUUSg TbEjIUsBudoBUo8zm44c75eKiGFIQ4s+cfkhsKgPFrjUkshYZiFx7XznAU5jiiiWyF6r Eijw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769530338; x=1770135138; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+SEkQgEJt3XSj0HPB4DBICRq/bSP9m3nTqv1wEUO5dM=; b=WlIpbszdM2ZY7pXh1xdEXaq38vMg8f/CpCh/Q76fYib9hJkrMWuRUvu2YCxyXfCgHQ T6hb+FSohdEEKQEJ391WewDuOJrbiAQPbnAkxO/y1oKjhO7lQ32s+c+OUYxRhIfuDcOk tTcXB0/qg6mGgbZQ611yvFUkg4JLnf4SzY+ShQwBu1fyFf8HurYyFr/4UDYYmqkx78zT tzvddTEMRj3ACYlHztV3/4FMzWxfQvze0K7cfVva2iBQ5lESLGhrHIO8MRw6Jt8FFeiT EWWzBLNEWmN/CZXlskw0EPF7xC9UuLT+T3JbwZho4/gRh5wXcVTwLnukxIHpJ9r7Ri8m HuRQ== X-Forwarded-Encrypted: i=1; AJvYcCWNaRD5BnmyDm7djvLBP8w8XGyTQl1mQbpqfZ/FNtV6wlaMm3C0Esp2IVnC22xOlif5S5HnPC3Fg0bkagE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2PS9uoZsPvYlMKv65YQzoxTuFQj4GP3EEtOS04sUbnmBsLs3I 68kXkaEuI1SBDSH7y9R4vW9ckKGpvebCMkxMLnH8phGL+rrN5/aV9ZB99dt27AKM4NdLYp5Y5BD vGkqIMW+6ufwp9NjrpQSEI6ElccGd2mVOVkzR9V2n8AP3uJUPf2Iz/9M6xcYMGqI5yL8= X-Gm-Gg: AZuq6aJrUdCmQ1z4LK6IPPs/Tu2wwElwgn2dWIWNicfGq0UW4MeYgnHiMkLzktKlUV4 qfr3flZ+V/7nwetSK4szb8ylWRzAdp9IWFvL5CE4hRCDL7j1Ft8teMOvCC99IRxO83XepWupZ+3 HDETIQHQXQ8hzLmUmX7pdeywBNp+MbKyy0F+EBM8701JSKy0Fy1w3WyFNCJnlG0zR0w1JEVUC77 C/xn6+ysqPrZ9JGLL1ulD652D2q5Azix/p66XwyCHNjC0DhciUQcodkTi67S9iCIm84LE4iT86e f/4HWwVQHzoo0CLnLLoYVaGe4ACG8Z3unVn3KLKNcRQyrL8BiWmezlaM+RO0fLxAfC1yTgEmIdG jKOrxSk+TK+0KUnK+iecsdPwXhN1oZSBf2OJwVow= X-Received: by 2002:a17:902:dac4:b0:2a0:c5b8:24b0 with SMTP id d9443c01a7336-2a870dd56edmr28281765ad.46.1769530338431; Tue, 27 Jan 2026 08:12:18 -0800 (PST) X-Received: by 2002:a17:902:dac4:b0:2a0:c5b8:24b0 with SMTP id d9443c01a7336-2a870dd56edmr28281295ad.46.1769530337793; Tue, 27 Jan 2026 08:12:17 -0800 (PST) Received: from [192.168.1.6] ([106.222.229.24]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802f97f3asm123086095ad.59.2026.01.27.08.12.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 08:12:17 -0800 (PST) Message-ID: <5db5dafd-3c1f-4844-b822-bbfe86b3eb4d@oss.qualcomm.com> Date: Tue, 27 Jan 2026 21:42:10 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/8] remoteproc: qcom: probe all child devices To: Dmitry Baryshkov Cc: Bjorn Andersson , mathieu.poirier@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, konradybcio@kernel.org, amitk@kernel.org, mani@kernel.org, casey.connolly@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20251223123227.1317244-1-gaurav.kohli@oss.qualcomm.com> <20251223123227.1317244-3-gaurav.kohli@oss.qualcomm.com> <57493aef-fb35-4377-8cf3-1df7f53470c9@oss.qualcomm.com> <74h7r3vsig3csejax3eu3uk53mdiimg2hjx7ntmmfrwdai6s3j@eiztghclfcvt> Content-Language: en-US From: Gaurav Kohli In-Reply-To: <74h7r3vsig3csejax3eu3uk53mdiimg2hjx7ntmmfrwdai6s3j@eiztghclfcvt> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: FmEw2wklNloIsqx1_pPsyYVqhQkV5OJJ X-Proofpoint-GUID: FmEw2wklNloIsqx1_pPsyYVqhQkV5OJJ X-Authority-Analysis: v=2.4 cv=J8CnLQnS c=1 sm=1 tr=0 ts=6978e3e3 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=EBd7WcfsMYPMwvoCMWz0vA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=2-K1YE3ZJe1EJHp8LXMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDEzMiBTYWx0ZWRfX6fOgSRWL5rnm rKu7ehYExZq/GbxWqJEdP3WtKdlTEaj4ooIVZ018vEWWqOWKnTWg1H3XXLU238T+2ouNLSoYfzV /uGgA+kfVJtHd47aIdqJBFdzkzYNPkJ1l610BZ4r4zFrVdhMvZoJECXeHPZT9Af0ceI3uDT7hng FV02f7rmzL8bNHfvZvQQnr6cWlb5kkdya865HJxMSzUknkampqsikEUFfb/WyyQxrBu+JRjDLn6 qE1toYtWobrO7+0oJ+83f26iZW459pvi9tTFlWWq4Fh2EB8m5Suogp9wqBrpDbXj92b0JU7iNrK IBur2Scqi2nk2TBCX/EtQJ/UQqnEmWjgdlv29EpGTZoeHDRkC4vHVHSFntAdx6WHha8/NhJe8FF mppRhjTLvaI1RCi9gVrEPBeVU5EYARvOX7naVLg/GdqVJCUFOuMwKOUMUEfwzaBzxBbJvCLdTQ8 W39uLnCYvAUmUtmpr6g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_03,2026-01-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 adultscore=0 impostorscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270132 On 1/24/2026 12:33 AM, Dmitry Baryshkov wrote: > On Fri, Jan 23, 2026 at 07:23:39PM +0530, Gaurav Kohli wrote: >> On 1/8/2026 12:37 PM, Gaurav Kohli wrote: >>> On 1/3/2026 8:26 PM, Bjorn Andersson wrote: >>>> On Tue, Dec 23, 2025 at 06:02:21PM +0530, Gaurav Kohli wrote: >>>>> From: Casey Connolly >>>>> >>>>> Generalise the qcom,bam-dmux child node support by probing all >>>>> remoteproc children with of_platform_populate(). This will be used to >>>>> enable support for devices which are best represented as >>>>> subnodes of the >>>>> remoteproc, such as those representing QMI clients. >>>> Please flip this around, start with the description of the problem >>>> you're trying to solve. >>>> >>>>> Signed-off-by: Casey Connolly >>>> This must have your signed-off-by, where you certifies the origin of >>>> this patch. >>>> >>>>> --- >>>>>   drivers/remoteproc/qcom_q6v5.c     | 4 ++++ >>>>>   drivers/remoteproc/qcom_q6v5_mss.c | 8 -------- >>>>>   2 files changed, 4 insertions(+), 8 deletions(-) >>>>> >>>>> diff --git a/drivers/remoteproc/qcom_q6v5.c >>>>> b/drivers/remoteproc/qcom_q6v5.c >>>>> index 58d5b85e58cd..a02839c7ed8c 100644 >>>>> --- a/drivers/remoteproc/qcom_q6v5.c >>>>> +++ b/drivers/remoteproc/qcom_q6v5.c >>>>> @@ -6,6 +6,7 @@ >>>>>    * Copyright (C) 2014 Sony Mobile Communications AB >>>>>    * Copyright (c) 2012-2013, The Linux Foundation. All rights >>>>> reserved. >>>>>    */ >>>>> +#include >>>>>   #include >>>>>   #include >>>>>   #include >>>>> @@ -351,6 +352,8 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, >>>>> struct platform_device *pdev, >>>>>           return dev_err_probe(&pdev->dev, PTR_ERR(q6v5->path), >>>>>                        "failed to acquire interconnect path\n"); >>>>>   +    of_platform_populate(q6v5->dev->of_node, NULL, NULL, q6v5->dev); >>>> There are other child nodes here, in particular the GLINK and SMD edges. >>>> Do we really want platform_devices registered for them? >>>> >>>> Regards, >>>> Bjorn >>> >>> thanks for pointing this, can you please suggest the right approach. >>> >>> This should not impact glink, as that is registering as rproc sub node, >>> And we need rproc cooling as child node >>> >>> of remote proc subsytem to create probe dependency only. >>> >>> >>> Can we do platform populate for specific child, would that be right >>> approach. or we should create rproc cooling as independent of parent ? >>> >> HI Bjorn, >> >> I’d like to highlight the impact and details of placement of remoteproc >> cooling dt node: >> >> >> ->As a child of the remote proc subsystem node: >>     In this configuration, the cooling device will only be probed once the >> corresponding remote proc subsystem itself is probed. >> >> ->Outside the remote proc subsystem, may be part of soc node: >>     In this setup, the cooling device will be probed independently. It will >> wait until the remoteproc subsystem is brought up >>     before completing cooling registration. >>     The drawback here is that if the parent remoteproc subsystem is >> disabled, the cooling device will still undergo an >>     unnecessary probe, even though it cannot be registered. > Bjorns question was different. It wasn't about pushing cooling device > outside of the remoteproc node. It is about not registering the devices. > > Can we follow the approach outlined by qcom_add_smd_subdev() / > qcom_add_glink_subdev()? Hi Dmitry, Thanks for the review. Since the remoteproc cooling is a QMI-based driver, it will receive the subsystem up notification directly. Therefore, there’s no need to make it a subdev node or tie it into the init/reset sequence of remoteproc subsytem. >