mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Peng Hao <peng.hao2@zte.com.cn>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests: fix warning: "_GNU_SOURCE" redefined
Date: Tue, 16 Oct 2018 08:53:45 -0600	[thread overview]
Message-ID: <5dbfc86b-17f9-4f56-ebaa-489f70436294@kernel.org> (raw)
In-Reply-To: <1539287630-92982-1-git-send-email-peng.hao2@zte.com.cn>

On 10/11/2018 01:53 PM, Peng Hao wrote:
> Makefile contains -D_GNU_SOURCE. remove define "_GNU_SOURCE"
> in c files.
> 
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>  tools/testing/selftests/proc/fd-001-lookup.c  | 2 +-
>  tools/testing/selftests/proc/fd-003-kthread.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/proc/fd-001-lookup.c b/tools/testing/selftests/proc/fd-001-lookup.c
> index a2010df..60d7948 100644
> --- a/tools/testing/selftests/proc/fd-001-lookup.c
> +++ b/tools/testing/selftests/proc/fd-001-lookup.c
> @@ -14,7 +14,7 @@
>   * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
>   */
>  // Test /proc/*/fd lookup.
> -#define _GNU_SOURCE
> +
>  #undef NDEBUG
>  #include <assert.h>
>  #include <dirent.h>
> diff --git a/tools/testing/selftests/proc/fd-003-kthread.c b/tools/testing/selftests/proc/fd-003-kthread.c
> index 1d659d5..dc591f9 100644
> --- a/tools/testing/selftests/proc/fd-003-kthread.c
> +++ b/tools/testing/selftests/proc/fd-003-kthread.c
> @@ -14,7 +14,7 @@
>   * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
>   */
>  // Test that /proc/$KERNEL_THREAD/fd/ is empty.
> -#define _GNU_SOURCE
> +
>  #undef NDEBUG
>  #include <sys/syscall.h>
>  #include <assert.h>
> 

Thanks for the patch. Applied to linux-kselftest next for 4.20-rc1.

thanks,
-- Shuah

      reply	other threads:[~2018-10-16 14:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11 19:53 Peng Hao
2018-10-16 14:53 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5dbfc86b-17f9-4f56-ebaa-489f70436294@kernel.org \
    --to=shuah@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=peng.hao2@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome