From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE9E6CA9ED3 for ; Mon, 4 Nov 2019 17:52:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA9E420663 for ; Mon, 4 Nov 2019 17:52:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aLtOeSff" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729362AbfKDRwM (ORCPT ); Mon, 4 Nov 2019 12:52:12 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:38584 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727989AbfKDRwM (ORCPT ); Mon, 4 Nov 2019 12:52:12 -0500 Received: by mail-pl1-f194.google.com with SMTP id w8so7913944plq.5 for ; Mon, 04 Nov 2019 09:52:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:cc:from:subject:to:user-agent:date; bh=3CHrSHD37ZopVTCrhzgKR9E8ooKOmK/8OxMVDS6vwuI=; b=aLtOeSffc2ESdeStgh0gvZWVGC4SVaxngt6L3IAywqqZTvFkn+X676dv17c4L6eGba SnLWjpu0qWDl8sFS8//6SiqVNR9FxZ1NRQCXVSYm1+GH1eGC3imZpqxJJVpp1zDsB/n0 qT2qm86muT+AU+DwWe6nV0XwIj9ZbPbZlOtyI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:cc:from:subject:to :user-agent:date; bh=3CHrSHD37ZopVTCrhzgKR9E8ooKOmK/8OxMVDS6vwuI=; b=jp5BmogbOD0H7O1Hq+doPPypxNhW6hOeMmJ0eACzHeM9tqDNZQFgmBAX7puHUeaTZa K2RfQTzn04bUif83PPoOCmdv8NEkGKa8Kta8k6GtkOcjb0q3az3OSoP+cZGVWuBYFs+W 5Min/3+h9vUUYDbfZDi+HGEPwu1uK8VwcXhy26I1kUja9T7+d7w/xX21aI1gf7npxR1T vZCRbC4AGj1xPxX7S/kAwkIZoheCTYnt2k1OP2ySo+yP6yPsQYcUXNRJHuIh+R33AaXF CNZ3Pwhf730Tms7RKQK9dttQ6qVcF8rw2TteepcwKGD4FfPmEg+9tmGqZMwWYMcTjJH9 3Q4g== X-Gm-Message-State: APjAAAWUaTEcpEaYbfSkGYGdXyefgBcajkjlJD/4VJLAjbBFoMf5bEpA 39fNOKVCePSMHZ+TjUkh7XaqBA== X-Google-Smtp-Source: APXvYqxrYy0bhV9BstiDpY6WoRWDrnAIP8w3jFR5/bWWHdykonSQNVFdZDTiO5WNLjo1Bbf3S55xnw== X-Received: by 2002:a17:902:16b:: with SMTP id 98mr28484214plb.154.1572889931654; Mon, 04 Nov 2019 09:52:11 -0800 (PST) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id f2sm14089155pfg.48.2019.11.04.09.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 09:52:11 -0800 (PST) Message-ID: <5dc0654b.1c69fb81.5f215.8c24@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1572591543-15501-1-git-send-email-kgunda@codeaurora.org> References: <1572591543-15501-1-git-send-email-kgunda@codeaurora.org> Cc: Kiran Gunda From: Stephen Boyd Subject: Re: [PATCH V1] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l To: Andy Gross , Kiran Gunda , Lee Jones , Mark Rutland , Rob Herring , bjorn.andersson@linaro.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, rnayak@codeaurora.org User-Agent: alot/0.8.1 Date: Mon, 04 Nov 2019 09:52:10 -0800 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Kiran Gunda (2019-10-31 23:59:03) > Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs > found on SC7180 based platforms. >=20 > Signed-off-by: Kiran Gunda > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 2 ++ > drivers/mfd/qcom-spmi-pmic.c | 4 ++++ > 2 files changed, 6 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/D= ocumentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > index 1437062..b5fc64e 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > @@ -32,6 +32,8 @@ Required properties: > "qcom,pm8998", > "qcom,pmi8998", > "qcom,pm8005", > + "qcom,pm6150", > + "qcom,pm6150l", Please sort on compatible string > or generalized "qcom,spmi-pmic". > - reg: Specifies the SPMI USID slave address for this device. > For more information see: > diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c > index e8fe705..d916aa8 100644 > --- a/drivers/mfd/qcom-spmi-pmic.c > +++ b/drivers/mfd/qcom-spmi-pmic.c > @@ -34,6 +34,8 @@ > #define PM8998_SUBTYPE 0x14 > #define PMI8998_SUBTYPE 0x15 > #define PM8005_SUBTYPE 0x18 > +#define PM6150L_SUBTYPE 0x27 > +#define PM6150_SUBTYPE 0x28 And on macro name here. > =20 > static const struct of_device_id pmic_spmi_id_table[] =3D { > { .compatible =3D "qcom,spmi-pmic", .data =3D (void *)COMMON_SUBT= YPE }, > @@ -53,6 +55,8 @@ > { .compatible =3D "qcom,pm8998", .data =3D (void *)PM8998_SUBT= YPE }, > { .compatible =3D "qcom,pmi8998", .data =3D (void *)PMI8998_SUB= TYPE }, > { .compatible =3D "qcom,pm8005", .data =3D (void *)PM8005_SUBT= YPE }, > + { .compatible =3D "qcom,pm6150l", .data =3D (void *)PM6150L_SUB= TYPE }, > + { .compatible =3D "qcom,pm6150", .data =3D (void *)PM6150_SUBT= YPE }, And compatible here. > { }