mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Harshit Mogalapalli" <harshit.m.mogalapalli@oracle.com>,
	linux-hwmon@vger.kernel.org,
	"Cryolitia PukNgae" <cryolitia@uniontech.com>,
	"Günter Röck" <linux@roeck-us.net>
Cc: kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] hwmon: gpd-fan: Fix error handling in gpd_fan_probe()
Date: Sun, 12 Oct 2025 19:19:40 +0200	[thread overview]
Message-ID: <5dc1ce09-98b4-4c48-971a-3ecb5ed9882b@web.de> (raw)
In-Reply-To: <20251010204447.94343-1-harshit.m.mogalapalli@oracle.com>

> When devm_request_region(0 fails to get a region regrion would be NULL
> and devm_hwmon_device_register_with_info() fails, best to propagate
> the hwmon dev to PTR_ERR() as opposed to region.

Will another imperative wording approach become more helpful for an improved
change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17#n94

Regards,
Markus

  parent reply	other threads:[~2025-10-12 17:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-10 20:44 Harshit Mogalapalli
2025-10-11  6:16 ` Cryolitia PukNgae
2025-10-12 17:19 ` Markus Elfring [this message]
2025-10-12 17:58 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5dc1ce09-98b4-4c48-971a-3ecb5ed9882b@web.de \
    --to=markus.elfring@web.de \
    --cc=cryolitia@uniontech.com \
    --cc=dan.carpenter@linaro.org \
    --cc=error27@gmail.com \
    --cc=harshit.m.mogalapalli@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®