From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D10C282C3 for ; Thu, 24 Jan 2019 18:40:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4B4F218B0 for ; Thu, 24 Jan 2019 18:40:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726317AbfAXSkD (ORCPT ); Thu, 24 Jan 2019 13:40:03 -0500 Received: from mga09.intel.com ([134.134.136.24]:24259 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725909AbfAXSkC (ORCPT ); Thu, 24 Jan 2019 13:40:02 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2019 10:40:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,517,1539673200"; d="scan'208";a="128626428" Received: from rmankee-mobl.amr.corp.intel.com (HELO [10.254.99.82]) ([10.254.99.82]) by orsmga002.jf.intel.com with ESMTP; 24 Jan 2019 10:40:00 -0800 Subject: Re: [PATCH][V2] ASoC: Intel: make const arrays static, reduces object code size To: Colin King , Liam Girdwood , Jie Yang , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hans de Goede , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org References: <20190124173735.13669-1-colin.king@canonical.com> From: Pierre-Louis Bossart Message-ID: <5dc23c74-2098-2876-38b1-e5bee620aa42@linux.intel.com> Date: Thu, 24 Jan 2019 12:40:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190124173735.13669-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/24/19 11:37 AM, Colin King wrote: > From: Colin Ian King > > Don't populate the const arrays on the stack but instead make > it static. Makes the object code smaller, for example: > > Before: > text data bss dec hex filename > 14107 8832 224 23163 5a7b bytcht_es8316.o > > After: > text data bss dec hex filename > 14015 8896 224 23135 5a5f bytcht_es8316.o > > (gcc version 8.2.0 x86_64) > > Signed-off-by: Colin Ian King Acked-by: Pierre-Louis Bossart > --- > > V2: also fix up bytcr_rt5640.c and bytcr_rt5651.c, thanks to > Pierre-Louis Bossart for noticing these two. > > --- > sound/soc/intel/boards/bytcht_es8316.c | 2 +- > sound/soc/intel/boards/bytcr_rt5640.c | 2 +- > sound/soc/intel/boards/bytcr_rt5651.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c > index fa9c4cf97686..1364e4e601d8 100644 > --- a/sound/soc/intel/boards/bytcht_es8316.c > +++ b/sound/soc/intel/boards/bytcht_es8316.c > @@ -437,7 +437,7 @@ static const struct acpi_gpio_mapping byt_cht_es8316_gpios[] = { > > static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev) > { > - const char * const mic_name[] = { "in1", "in2" }; > + static const char * const mic_name[] = { "in1", "in2" }; > struct byt_cht_es8316_private *priv; > struct device *dev = &pdev->dev; > struct snd_soc_acpi_mach *mach; > diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c > index ca8b4d5ff70f..a79466c8fb29 100644 > --- a/sound/soc/intel/boards/bytcr_rt5640.c > +++ b/sound/soc/intel/boards/bytcr_rt5640.c > @@ -1149,7 +1149,7 @@ struct acpi_chan_package { /* ACPICA seems to require 64 bit integers */ > > static int snd_byt_rt5640_mc_probe(struct platform_device *pdev) > { > - const char * const map_name[] = { "dmic1", "dmic2", "in1", "in3" }; > + static const char * const map_name[] = { "dmic1", "dmic2", "in1", "in3" }; > const struct dmi_system_id *dmi_id; > struct byt_rt5640_private *priv; > struct snd_soc_acpi_mach *mach; > diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards/bytcr_rt5651.c > index b618d984e2d5..e6945d11c8ab 100644 > --- a/sound/soc/intel/boards/bytcr_rt5651.c > +++ b/sound/soc/intel/boards/bytcr_rt5651.c > @@ -919,7 +919,7 @@ struct acpi_chan_package { /* ACPICA seems to require 64 bit integers */ > > static int snd_byt_rt5651_mc_probe(struct platform_device *pdev) > { > - const char * const mic_name[] = { "dmic", "in1", "in2", "in12" }; > + static const char * const mic_name[] = { "dmic", "in1", "in2", "in12" }; > struct byt_rt5651_private *priv; > struct snd_soc_acpi_mach *mach; > struct device *codec_dev;