From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751546AbdG0K41 (ORCPT ); Thu, 27 Jul 2017 06:56:27 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:40182 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbdG0K40 (ORCPT ); Thu, 27 Jul 2017 06:56:26 -0400 Subject: Re: [PATCH RESEND] ARM: davinci: don't mark vpif_input structures as 'const' To: Arnd Bergmann , Kevin Hilman CC: Bartosz Golaszewski , Axel Haslam , Mauro Carvalho Chehab , , References: <20170727101320.609258-1-arnd@arndb.de> From: Sekhar Nori Message-ID: <5dc37564-2efe-d090-78a4-1702291b176d@ti.com> Date: Thu, 27 Jul 2017 16:24:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170727101320.609258-1-arnd@arndb.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Thursday 27 July 2017 03:42 PM, Arnd Bergmann wrote: > A change to the platform data definitions caused a warning in the board code: > > arch/arm/mach-davinci/board-dm646x-evm.c:680:13: error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] > arch/arm/mach-davinci/board-dm646x-evm.c:690:13: error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] You can replace these by: arch/arm/mach-davinci/board-da850-evm.c:1221:13: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] arch/arm/mach-davinci/board-da850-evm.c:1231:13: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] to match with this patch. > > This is a bit unfortunate, since we generally like structure definitions to > be const, but as this is legacy code, the easiest way out is still to > remove the 'const' annotation here. > > Fixes: 4a5f8ae50b66 ("[media] davinci: vpif_capture: get subdevs from DT when available") > Fixes: 231ce279e6e3 ("ARM: davinci: fix const warnings") > Signed-off-by: Arnd Bergmann Acked-by: Sekhar Nori Looks like this slipped my testing since I had CONFIG_DA850_UI_SD_VIDEO_PORT switched off. Thanks for catching it. > --- > I originally sent my fix on Jun 9, but Kevin had already applied an > identical fix for two of the three affected files. This fixes the > third one that his patch missed. > > I have a couple of other patches that I'm planning to apply directly > to the fixes branch now, and would do the same for this one unless > there are objections. No problem. Thanks! ~Sekhar