From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752189AbdJEUvX (ORCPT ); Thu, 5 Oct 2017 16:51:23 -0400 Received: from mout.web.de ([217.72.192.78]:58633 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbdJEUvV (ORCPT ); Thu, 5 Oct 2017 16:51:21 -0400 Subject: [PATCH 1/2] powermac: Delete an error message for a failed memory allocation in kw_i2c_host_init() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras Cc: LKML , kernel-janitors@vger.kernel.org References: <5188c0b3-476a-6a14-bab5-052ad0f4dae0@users.sourceforge.net> Message-ID: <5dc8fe2f-0459-faff-585f-a92137115895@users.sourceforge.net> Date: Thu, 5 Oct 2017 22:51:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <5188c0b3-476a-6a14-bab5-052ad0f4dae0@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:u2ew0EXdCdtBPETkmvm/h1+JMFqTyElBjTeBUhqO3WRuk3L3sN2 rb69rGOs/BzvpBdDNuTzQwJhjp5J9ea+OqJ6nqYsFiZIzeZ0yPYNgNROo5jvbuaae3cF5Ql 1T+2ThWB38IUrHbomTIqsvB34g6B9JAuga6BVv0AfuaXGO7jZ+aDELjk4CJf4VpmL7oYqbo WBZJHBFBo2HYsjMYFSu+A== X-UI-Out-Filterresults: notjunk:1;V01:K0:sU2KmK2PZtk=:/10q04rX/5cuxDJDPZgJhI csLW2SI/g1UXIvj/KcZMFGjRyOJlmmrEkczOsnHfmg/STedbq138vNTsqVnL6IDABamjkZNjl k2rZSjyJoLv/hrGgD10wXSVjyIOmQpH673nqIJDezUO9mbZadQQSWsTxcgaTpqhgvKRWzidN/ BsokXZRx+ttP9zpbzUJN5QVOZXELSExgEPt5oEujqDtJwWoHyIlsAC9h6lNNTWF2fujhJmc1h DjX3h4q0ex8eIJl1xKcyulO9zO+dIrU4yDEoJ6NQKXSGCp+MWyUJaH5JIfAbyjw6GK3hQ7lA6 pPmA8GDDYOaRY3TmQGDwUlIKzlOqXr93GmCnThYy4S26P/8qMOofhXdxckHm7+Ii3Yj3isIsQ Puqhhx+P/AStusPmpLBs9V+E9hN+AuUWwjtEkBV3kx5Pj5bfhaHBqFBVx2VzLZoN2CjzEN+By I8Q4VhY3ALLo8JIz7I4UyKIPaQCst/nU0cSebyWFVgqMH9hPwXoPtvevRydAZD8J9QnlE0qCb QOYlREx2xRqHVFnnilCGJDD7AMNJRpL6vZ2fB9HSI/HMpYQ0db1o72k+QGeqgW2bEsvTzJSmL wEYjsdGtvOgWNDhIQeoLAkxzAXrRHB14VpCx6gS9rjRinZA7VjmtX4TPU8op7P36div2HdVnp JV5CLU/g928v4WfmH8ZshocaOX/guGvMFyqTHphhAWePQCjqrnYQ3viIufY5GTLv506WM3sP3 TGFXL7oth0Pytd/dFyH4BMeUjsE6R61H9b3Bzy++I0s9ABvl0xj764NmBLrGQYWNLJLy0FcuM OWO7XT9ckKKv1BorBiSTTLNR9t6UqL7oIT9sPSxxDNYzstOY9c= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 5 Oct 2017 22:30:29 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/powermac/low_i2c.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c index 70183eb3d5c8..ecd166b5549b 100644 --- a/arch/powerpc/platforms/powermac/low_i2c.c +++ b/arch/powerpc/platforms/powermac/low_i2c.c @@ -493,11 +493,8 @@ static struct pmac_i2c_host_kw *__init kw_i2c_host_init(struct device_node *np) u32 steps; host = kzalloc(sizeof(struct pmac_i2c_host_kw), GFP_KERNEL); - if (host == NULL) { - printk(KERN_ERR "low_i2c: Can't allocate host for %pOF\n", - np); + if (!host) return NULL; - } /* Apple is kind enough to provide a valid AAPL,address property * on all i2c keywest nodes so far ... we would have to fallback -- 2.14.2