From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17A7C468BC for ; Fri, 7 Jun 2019 09:42:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C19D92089E for ; Fri, 7 Jun 2019 09:42:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728215AbfFGJmk (ORCPT ); Fri, 7 Jun 2019 05:42:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:43122 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727512AbfFGJmj (ORCPT ); Fri, 7 Jun 2019 05:42:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3CC5EAE15; Fri, 7 Jun 2019 09:42:37 +0000 (UTC) Message-ID: <5dccf2500f023ce2c78d9ff3f41b53e36843298b.camel@suse.de> Subject: Re: [PATCH v2 2/7] clk: bcm283x: add driver interfacing with Raspberry Pi's firmware From: Nicolas Saenz Julienne To: Stefan Wahren , stefan.wahren@i2se.com, linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, f.fainelli@gmail.com, ptesarik@suse.com, sboyd@kernel.org, viresh.kumar@linaro.org, mturquette@baylibre.com, linux-pm@vger.kernel.org, rjw@rjwysocki.net, eric@anholt.net, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mbrugger@suse.de, ssuloev@orpaltech.com Date: Fri, 07 Jun 2019 11:42:34 +0200 In-Reply-To: <3c4c8b56-eb02-be6f-9b3a-a94a895f10f0@gmx.net> References: <20190606142255.29454-1-nsaenzjulienne@suse.de> <20190606142255.29454-3-nsaenzjulienne@suse.de> <3c4c8b56-eb02-be6f-9b3a-a94a895f10f0@gmx.net> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-vYYrm15OHAAapvPJgPuT" User-Agent: Evolution 3.32.2 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-vYYrm15OHAAapvPJgPuT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2019-06-07 at 11:26 +0200, Stefan Wahren wrote: > Hi Nicolas, >=20 > Am 06.06.19 um 16:22 schrieb Nicolas Saenz Julienne: > > Raspberry Pi's firmware offers an interface though which update it's > > clock's frequencies. This is specially useful in order to change the CP= U > > clock (pllb_arm) which is 'owned' by the firmware and we're unable to > > scale using the register interface provided by clk-bcm2835. > >=20 > > Signed-off-by: Nicolas Saenz Julienne > > Acked-by: Eric Anholt > >=20 > > --- > >=20 > > Changes since v1: > > - Use BIT() > > - Add Kconfig entry, with compile test > > - remove prepare/unprepare > > - Fix uninitialized init.name in pllb registration > > - Add MODULE_ALIAS() > > - Use determine_rate() instead of round_rate() > > - Add small introduction explaining need for driver > >=20 > > drivers/clk/bcm/Kconfig | 7 + > > drivers/clk/bcm/Makefile | 1 + > > drivers/clk/bcm/clk-raspberrypi.c | 302 ++++++++++++++++++++++++++++++ > > 3 files changed, 310 insertions(+) > > create mode 100644 drivers/clk/bcm/clk-raspberrypi.c > >=20 > > diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig > > index 29ee7b776cd4..a4a2775d65e1 100644 > > --- a/drivers/clk/bcm/Kconfig > > +++ b/drivers/clk/bcm/Kconfig > > @@ -64,3 +64,10 @@ config CLK_BCM_SR > > default ARCH_BCM_IPROC > > help > > Enable common clock framework support for the Broadcom Stingray SoC > > + > > +config CLK_RASPBERRYPI > > + tristate "Raspberry Pi firmware based clock support" > > + depends on RASPBERRYPI_FIRMWARE || (COMPILE_TEST && > > !RASPBERRYPI_FIRMWARE) > > + help > > + Enable common clock framework support for Raspberry Pi's firmware > > + dependent clocks > > diff --git a/drivers/clk/bcm/Makefile b/drivers/clk/bcm/Makefile > > index 002661d39128..eb7159099d82 100644 > > --- a/drivers/clk/bcm/Makefile > > +++ b/drivers/clk/bcm/Makefile > > @@ -7,6 +7,7 @@ obj-$(CONFIG_CLK_BCM_KONA) +=3D clk-bcm21664.o > > obj-$(CONFIG_COMMON_CLK_IPROC) +=3D clk-iproc-armpll.o clk-iproc-pll.o > > clk-iproc-asiu.o > > obj-$(CONFIG_ARCH_BCM2835) +=3D clk-bcm2835.o > > obj-$(CONFIG_ARCH_BCM2835) +=3D clk-bcm2835-aux.o > > +obj-$(CONFIG_CLK_RASPBERRYPI) +=3D clk-raspberrypi.o > > obj-$(CONFIG_ARCH_BCM_53573) +=3D clk-bcm53573-ilp.o > > obj-$(CONFIG_CLK_BCM_CYGNUS) +=3D clk-cygnus.o > > obj-$(CONFIG_CLK_BCM_HR2) +=3D clk-hr2.o >=20 > not your fault but you better rebase your next version on linux-next > because Florian's latest patches ("clk: bcm: Make BCM2835 clock drivers > selectable") collide with this patch. >=20 > Checkpatch gives the following output about this patch: >=20 > WARNING: 'harware' may be misspelled - perhaps 'hardware'? >=20 > #58: FILE: drivers/clk/bcm/clk-raspberrypi.c:5: > + * Even though clk-bcm2835 provides an interface to the harware > registers for >=20 > ERROR: code indent should use tabs where possible > #197: FILE: drivers/clk/bcm/clk-raspberrypi.c:144: > +^I^I^I^I struct clk_rate_request *req)$ Noted, thanks. As this seems fairly calm, should I send v3 or wait little more? --=-vYYrm15OHAAapvPJgPuT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAlz6MYsACgkQlfZmHno8 x/4cAgf8C0p+K3P3lwXzF2aerFWGjQdQ5MTyixpeAFG52zhaabNg97gJ1Id0m0pa DpW++g2ioGud8UyqpllRIVQYkdyCTMR2EpK7IQ29LN9nwS8SwKBg33HhYDUYgVY9 7Bl4zb+IavOd74KzxP+VBhdRrGIh8TsI/mfS7d2udj121AKJtpy9eFx6KrT60sPn xAAgkcj490MpT3c4kihVMVPy/kLBQoHYWKpui23sTNyMKT7+2arsYrOgKcy6THbl /JI1MO+kCGIQUVmkHk8jzoQMOVAGQqnqLYmjQVntn6Esdujc2PBqu5fqzV3mWrks 7LsAb94I/Y1BUed/JKAFjT5DJ0qLPA== =zWl2 -----END PGP SIGNATURE----- --=-vYYrm15OHAAapvPJgPuT--