From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8F3C455184 for ; Thu, 20 Aug 2026 13:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787232540; cv=none; b=vGt/f/egQFwcwzm9FHpo5xmdca7HeFlqlN6Y8C8lm9jT7iTB+hnN9Vw9Ql9Bf6SeoocNqyqx9b/ELb0X0QjVBSNfo+gpD5yD2JDUBpFmmV4Hy0jYntbzRbAzzHPqdq0wVRwaGhAcprFexcvG4/wycfbm+YS27+Mia+zclLgZTD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787232540; c=relaxed/simple; bh=bgd/aBKkexWU/D1QHpCDp5dKjnRhTgnL90kp3gswrPc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M5TTi72x3Mn0Iu0O7H7C6xJVzyf9bPNi2FmtMQo8q7H6dR0dlxx+91nUknzQzg8QbWlaVPtTEadMf1AlwSfo0KoSUw93o+rwh5+uf/BIJ7qjQS20nVq8GyqcBGatgwQ1KY3KrSuqcoN9FU+DLd1ldyNKPXMi1R5iOmQPWN6cRG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=R3dsEVvZ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=WLJJcbQx; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R3dsEVvZ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="WLJJcbQx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787232537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=81FXEFEAWoGzBEUkp5WTBnX+AFEQNiURHAaHyp35qfU=; b=R3dsEVvZC+qSw7781d5mB2hH8qnJKBQrg4zzKAhfR7fVtmgUwzr4taduIxRVf7YGrP7fiX d+XsYDG1ky6D9aLT0o2wOnqc/hCLN6HOrt/v1IZ1Hjd37aBrpKdOgwoI97H6fF1aEo0im+ 5pBM90Wn4T0Lp+OAV0NoR3EOw64iLQA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-578-LiJH92a8OeqVwWRO15muYQ-1; Thu, 20 Aug 2026 09:28:54 -0400 X-MC-Unique: LiJH92a8OeqVwWRO15muYQ-1 X-Mimecast-MFC-AGG-ID: LiJH92a8OeqVwWRO15muYQ_1787232533 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4955843c6cdso20766345e9.1 for ; Thu, 20 Aug 2026 06:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787232533; x=1787837333; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=81FXEFEAWoGzBEUkp5WTBnX+AFEQNiURHAaHyp35qfU=; b=WLJJcbQxzG5uIEpP7OT+KhvWY9f1eTP5cLasZskybto/qEL0SHq5lwlayRJag83Vht CGMFQUfJiEYoKleGaNWSSHSRiUKxc0ash2QoALBNLsZk7nwFxDL+uSpGAzzlyyBu08ZB 6wWMIC4uS9lwe+mlbpQRCCo6FDS3atu1rmFrfsXaKAqevJDm/ry5zGEaRPeGi9yHTu76 KNnCDKwu8XegzqaCCB6U/SdI28eGIHSu03g0Dxqj6JkVyHJQLd/8KZxTexHhr5+dfR2r TzHyZE/VbkweloMm6ixVPYta6i8jmgQcJ1SZ1aWlrdbli75pUV+tnkh35hE0TkY5y3UU 5lmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787232533; x=1787837333; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=81FXEFEAWoGzBEUkp5WTBnX+AFEQNiURHAaHyp35qfU=; b=EZVs67RbrnKrBW84u264tVCdjqU4CXP05qVTvPQbkOE0vBpo6FOyK01mLBtEDDEhX0 phdxQielUIQuwh2GpriaHEhz0xwHJOLzuqLklbqgIiT5iBxiHZiq6oMAAIYwg0HEr6wx dCDkd/4eLXQL6kAP7dynR7w7zZTpTu9KrZd44W//G6UCPXnUQE3U69LZ1vG0kTDqjdec ainOUVXBEjmLN7x+WNP6SEorYGRd4F7LSYdXSvE+180PFMd7BH6zQQ1PMHoMRBngDYtV 8P1Xv8zcGlJ7MHSnM8izUC5NeYIHG4FRLLppr2r+YP4gK1+SvRduYZD8CWgQ4E0c3jbl ONqw== X-Forwarded-Encrypted: i=1; AHgh+Ro04jEyj/O6vprV0t3wNPHWZmmpS4oIPewxn42KnqdRjH70OhtDRXB9F2gWyVTLxh+BZxdutLBsTroZVIg=@vger.kernel.org X-Gm-Message-State: AOJu0YwntV+S7YyfSZPz0GBve+vafcSse2wix941bMf1EZmczJ4sIA/1 HJQwPNQAjHgEiA97vvTzTddGXH33io9LocUwMr098G3kzqGPj/5WLYtYN0VuZG/1JqwhqEHJ7Xa 0AKzrWMCtd08ybZLpXoALE5kx8rr7sJ+fTeeK2EMkKWFYgJEPmIoJh7dpA1+F7MOkGg== X-Gm-Gg: AR+sD100aFVi1BqOFPTrsRsTI70S75bVAo68uKN6/nZl7trA5mlH1c4nWhP79SjA+5u wI6onoMfnytLJQOA7gYeRMVVWWYKeVss6XlUIs9yRE0/YLj9F0s2zvJFev25LsUjwkg3WtY8g1W Fkrgtbod5RrfMB/A8UuA39qz4MMdS7Hz0nMZhIyG/5lpYRzg7s67MkZ859ovugNl6LJ6UpMfc1Q bMsq4K8aD2vfNENpow4QhUkjjqPqMNmHo62+dQWEp2EC7ajxZsucHJfmZBOa8aMnVp0X0UtaZHO pj3XCuLeZmxs4bl/j+9HuFB6aBGKv2GnAPc80lLuBta98SGsfGBtirT2dvEkgRO9IHX4Gpaocxk 7ciPk+xYEQL8CiBC7kSK0NVG7wnydg4GYimNMsH3+LlRnNBFwY8B8zriznPWIo3q24av40QjX5Z M= X-Received: by 2002:a05:600c:3b95:b0:495:48d7:f178 with SMTP id 5b1f17b1804b1-499aa1b97ccmr211342255e9.11.1787232532937; Thu, 20 Aug 2026 06:28:52 -0700 (PDT) X-Received: by 2002:a05:600c:3b95:b0:495:48d7:f178 with SMTP id 5b1f17b1804b1-499aa1b97ccmr211341565e9.11.1787232532604; Thu, 20 Aug 2026 06:28:52 -0700 (PDT) Received: from [192.168.188.103] (ip239-44-231-195.pool-bba.aruba.it. [195.231.44.239]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499affa25acsm82583045e9.4.2026.08.20.06.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 06:28:52 -0700 (PDT) Message-ID: <5dd2fd63-48f4-4f28-b3f0-fd9b7f502c2a@redhat.com> Date: Thu, 20 Aug 2026 15:28:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] net: fec: Propagate PTP initialization errors To: phucduc.bui@gmail.com, Wei Fang , Frank Li , Shenwei Wang Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Richard Cochran , imx@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20260820111416.97917-1-phucduc.bui@gmail.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260820111416.97917-1-phucduc.bui@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/20/26 1:14 PM, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > Change fec_ptp_init() to return an error code instead of silently > ignoring failures during PTP initialization. > > The PPS IRQ is not required for the FEC/PTP functionality, so its > absence should not make the probe fail. However, an unavailable > optional IRQ should be distinguished from an actual error returned > during the IRQ lookup. > > If a platform does not support the PPS IRQ, it can omit the IRQ from > its device tree and the optional lookup will return -ENXIO. Propagate > other errors from the IRQ lookup instead of silently ignoring them. > > Also propagate failures from devm_request_irq() and ptp_clock_register(). > > Update the function declaration in fec.h accordingly. > > Found by manual code inspection. > > Signed-off-by: bui duc phuc ## Form letter - net-next-closed We have already submitted our pull request with net-next material for v7.3, and therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after Aug 31st. RFC patches sent for review only are obviously welcome at any time. See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle