From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41471CDB47E for ; Sun, 15 Oct 2023 09:24:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbjJOJYt (ORCPT ); Sun, 15 Oct 2023 05:24:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbjJOJYs (ORCPT ); Sun, 15 Oct 2023 05:24:48 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49ED3A3 for ; Sun, 15 Oct 2023 02:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1697361883; bh=urG4oh7ObZeYy796+eJBTOzvZ+QqH/SVTyJ2zZ6fxs8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=io6+Y4+TXg3IBuIBwLGU1ltfzSdN84NFAuELISXW/8mT9o2gIBOYM8Hp1tkCIIQ+E LulG1P+6C1jSP4VujEK9FgLKe2FpmwE8akAJOR0LGH9hKqXIQYCGeuD3HMXtPsHhqz 44+TRGTS6Q4NgqOsup8JHaztxUDQViGTVQ29i7Vs= Date: Sun, 15 Oct 2023 11:24:43 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Calvince Otieno Cc: Dan Carpenter , outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Luke Koch , Bagas Sanjaya , Simon Horman , linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: wlan-ng: remove unused functions Message-ID: <5dd59334-428b-4e27-8d19-7b8514bb5ef5@t-8ch.de> References: <62778e4d-cc2e-4310-b334-52b54cfe7e79@kadam.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Calvince, On 2023-10-15 10:39:20+0300, Calvince Otieno wrote: > On Sun, Oct 15, 2023 at 10:38 AM Calvince Otieno wrote: > > On Fri, Oct 13, 2023 at 12:02 PM Dan Carpenter wrote: > > > > On Fri, Oct 13, 2023 at 09:52:50AM +0300, Calvince Otieno wrote: > > > The following functions were defined in the prism2mgmt.h file but neither > > > declared nor used anywhere. It is recommended that they be removed. > > > > > > - void prism2mgmt_get_grpaddr(u32 did, struct p80211pstrd *pstr, > > > struct hfa384x *priv); > > > - int prism2mgmt_set_grpaddr(u32 did, > > > u8 *prism2buf, struct p80211pstrd *pstr, > > > struct hfa384x *priv); > > > - int prism2mgmt_get_grpaddr_index(u32 did); > > > > > > > Could you look up when the functions were deleted and add that > > information to the commit message? > > > > These functions were removed five years ago in commit 123412341234 > > ("delete functions"). > > > > regards, > > dan carpenter > > I am not able to locate exactly when these functions were deleted. > I have checked the commit history of these files prism2mgmt.h and prism2mgmt.c, > but, I can't find any commit relating to the removal of the above functions. you can use the "-S" argument to "git log" for this quite nicely: $ git log --pretty=oneline -Sprism2mgmt_set_grpaddr drivers/staging/wlan-ng 1e7201836c576883d5bd708810cc72ab1392756f Staging: wlan-ng: Delete a pile of unused mibs. And fix WEXT SET_TXPOWER. cbec30c4c00c9f5a7357f5c5dacb63ae2378afb4 Staging: wlan-ng: Delete a large pile of now-unused code. 00b3ed1685089ff52169a715de11106ed37df087 Staging: add wlan-ng prism2 usb driver This shows all the commits that touched the drivers/staging/wlan-ng directory and added or removed the string "prism2mgmt_set_grpadd". You can check which of these three commits dropped the function and then repeat the procedure for the other two functions. Thomas