From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B07AC433F5 for ; Fri, 31 Aug 2018 06:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ABD6320661 for ; Fri, 31 Aug 2018 06:24:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABD6320661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727475AbeHaKaH (ORCPT ); Fri, 31 Aug 2018 06:30:07 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:42084 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727202AbeHaKaH (ORCPT ); Fri, 31 Aug 2018 06:30:07 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: gtucker) with ESMTPSA id B7246264017 Subject: Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers" To: Guenter Roeck , Roland Dreier Cc: Greg Kroah-Hartman , Ben Hutchings , LKML , stable@vger.kernel.org, matt@codeblueprint.co.uk, bp@suse.de, Andrew Morton , Andy Lutomirski , luto@kernel.org, Ard Biesheuvel , bp@alien8.de, brgerst@gmail.com, davej@codemonkey.org.uk, dvlasenk@redhat.com, "H. Peter Anvin" , Linus Torvalds , Peter Zijlstra , sai.praneeth.prakhya@intel.com, sds@tycho.nsa.gov, Thomas Gleixner , toshi.kani@hp.com, linux-efi@vger.kernel.org, Ingo Molnar , Yazen.Ghannam@amd.com References: <20171215092305.994559179@linuxfoundation.org> <20171215092311.347628971@linuxfoundation.org> <1535129126.2902.36.camel@codethink.co.uk> <20180824191749.GA15489@kroah.com> <20180824201025.GB18715@roeck-us.net> <20180824203251.GD18715@roeck-us.net> From: Guillaume Tucker Message-ID: <5dd63596-9f7f-f72a-37ad-b0d97580667e@collabora.com> Date: Fri, 31 Aug 2018 07:24:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180824203251.GD18715@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/08/18 21:32, Guenter Roeck wrote: > On Fri, Aug 24, 2018 at 01:16:18PM -0700, Roland Dreier wrote: >>> Sounds great. I'll hold off with sending my RFT series and wait for your >>> test results. I think we'll also need d367cef0a7f0c6 ("x86/mm/pat: Fix >>> boot crash when 1GB pages are not supported by the CPU"). >> >> Sure, makes sense - I don't have any EFI systems with CPUs old enough >> not to support 1G pages but that looks reasonable. I'll pull that >> into my tree as well. >> > kernelci reported a crash on a CPU which doesn't support 1G pages. > See https://kernelci.org/boot/id/5b7d39ea59b514c03796ba9c/ Looks like this has now been fixed with Andi's patch in 4.4.153: "x86/mm/pat: Fix L1TF stable backport for CPA" I can confirm this platform is now booting fine in kernelci: http://lava.streamtester.net/scheduler/job/146195 Thanks, Guillaume