From: <Pavel.Parkhomenko@baikalelectronics.ru>
To: <andrew@lunn.ch>
Cc: <Alexey.Malahov@baikalelectronics.ru>,
<Sergey.Semin@baikalelectronics.ru>,
<linux-kernel@vger.kernel.org>, <michael@stapelberg.de>,
<afleming@gmail.com>, <f.fainelli@gmail.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH] net: phy: marvell: Fix RGMII Tx/Rx delays setting in 88e1121-compatible PHYs
Date: Sat, 5 Feb 2022 15:22:44 +0000 [thread overview]
Message-ID: <5dd77fec0f9a2d38fd4473cd0e357e80aeafe0cb.camel@baikalelectronics.ru> (raw)
In-Reply-To: <Yf0lyGi+2mEwmrEH@lunn.ch>
On Fri, 04/02/2022 at 14:10 +0100, Andrew Lunn wrote:
> Hi Pavel
>
> There appears to be another path which has the same issue.
>
> m88e1118_config_aneg() calls marvell_set_polarity(), which also needs
> a reset afterwards.
>
> Could you fix this case as well?
>
> Thanks
> Andrew
m88e1118_config_aneg() was added back in 2008 and has unconditional
genphy_soft_reset() at the very beginning. I haven't got 88E1118R or
88E11149R by the hand and the full documentation is also not available.
I believe that in this case it would be safe to still issue reset
unconditionally, but do it at the very end of m88e1118_config_aneg().
Anyways, I'd like to post it as a separate patch as I cannot test the fix
properly, unlike previous patch regarding 88E1510.
--
Best regards,
Pavel Parkhomenko
next prev parent reply other threads:[~2022-02-05 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 5:29 Pavel.Parkhomenko
2022-02-04 9:56 ` Serge Semin
2022-02-04 10:41 ` Russell King (Oracle)
2022-02-04 13:10 ` Andrew Lunn
2022-02-05 15:22 ` Pavel.Parkhomenko [this message]
2022-02-05 16:25 ` Andrew Lunn
2022-02-05 4:02 ` Jakub Kicinski
2022-02-05 20:39 ` [PATCH net v2] " Pavel Parkhomenko
2022-02-08 4:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dd77fec0f9a2d38fd4473cd0e357e80aeafe0cb.camel@baikalelectronics.ru \
--to=pavel.parkhomenko@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=afleming@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@stapelberg.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®