From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D4A632AAA2 for ; Tue, 17 Feb 2026 10:55:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771325750; cv=none; b=GSoo4pXD30Leg7zzIi5S7utGburXmc5Pz1aHDy2x07/hjNzu5jmE/ITnM0+p+O3I7YC4TpwXxn6HfVAyExzrX7lIKWQ3il4RfLjJZDw1O48zgd8OCxPDNM1ZcVE40JvXwxWsPgdMp8XnJS06AL+828rx9NflJoyDcSuKTRmeEK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771325750; c=relaxed/simple; bh=fQkAhhQAqFJXXjDjlKJ4Pr2ZUi0r4H/CsWFdmxSGiOo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HrUEM1KPCGFH6VBY/v5Y6iTB+ddYEx16VuabKlLfFhbvYb3bBv4coLSnjbhXXhlVLJowCln8XHiDNvo6LUMCNEDphk7gywupwskV5Ptz1LOdllOu7Eik340Wr+lrmPToWXh0w36iNr3Xb9WqDjRGy3qsw1Wd3wygrcoVABCjKMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gjpket2t; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ls0r302d; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gjpket2t"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ls0r302d" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61H8bJec297136 for ; Tue, 17 Feb 2026 10:55:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zqkImrZ3d6J+orJLxyPG7cK4X2BClCQg2tGoIiWRLY0=; b=gjpket2tJkF7Ry6c 4Wxoow40RYWa1aGiYUPjFUiolbC8H6rqJ6xSGmY7S5fnMe6U+ZTnJOGIsre4Lxn8 NJ/Zkz4nigFnnK1IqbRum3Org8EoX5Bc+JSHwp6ZDBEHq4udGF6ql2RZfrn6gX1i bjbNcshnjtxaPglb1ahI4lOIt+XidFv/rO5vdULJDlI8UfeiGDUeQTOqiSk5eT95 3GceHAb5m4skPLqWBzmdc7yXp0H0c6+SNHNRBjEPc9uupIOQWSoRQNAwCCXKHiVo dS+XbCZ40Qd/pekF3d3EOjS3y1dpdk+xVfvtyWHYk0MogZ1P/TyQvEUNgVf5brjE wpxvgA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cc6a9t1jg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 10:55:47 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cb50fb0abdso281988385a.1 for ; Tue, 17 Feb 2026 02:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771325747; x=1771930547; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zqkImrZ3d6J+orJLxyPG7cK4X2BClCQg2tGoIiWRLY0=; b=Ls0r302dja9OozseCL0EH/6cwPwMFflYKKoH05uyw3jO6R6/2Bp1nSEdS7TDhHDPcU p91QaBV5o40ue1te0aqKLa6WRHj8d1lW8rYwC6PVWQvNc3gnYJg5h9g013gJjssY11od phO48fIHh6FltnBhLQ7hM1gHyuHnxnlC4IBmBmI/TiXAGw60HBAbUE3zt40NMhLZmPQi Q+zpMah2ZaEyn9qNkHwW6N3m9wmXkhC98hfJgOsI9expAf/IJXvQGgW/2KNGzOAli9VW kK1sHSz+IEUdWtNGQ9V5zGWmvtszkjzZ2102UWth/Di50tr+8r0hBOZrEFjhgWzNVv8z 6Zkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771325747; x=1771930547; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zqkImrZ3d6J+orJLxyPG7cK4X2BClCQg2tGoIiWRLY0=; b=R9yXIfwjfXYVNEWCDRbBHV/tvgb/PJQuXWocbe6G5Rwwb+uvhjTF5QTw+3PxxPkM2x IWpg8wvMqP1pPybkWpal/iFL08BEU8LltkZfuWegmlIPkBr8BvvbEGEk207HYBI+/aQ5 L/ggQr+So/3gEikGAi1Ww2XCZZFJ/NlFWbrzupYl9hz4lLx4KRwkJ4mUGXYHzwVTWro+ CGn+I55ZtCbi0a/HmgVk6EYii6mwZDfcwtUn43mxvXB62cA0gJABDaysbG2EKaygvW1L hEpZYHYfWePd2r+dk4jpFiX81ytYZA1UGeDSw6FmTLP9HU6HjvNmqEKqJ+vk1Vacl+Yr jddQ== X-Forwarded-Encrypted: i=1; AJvYcCVJgLGvq0qFwAsNeKJMy2JdpOVs7hMoE4taIpSxFitINrN9+uA3enXDcHFZyjO6YYb/5SE9IkaXOolhM4k=@vger.kernel.org X-Gm-Message-State: AOJu0YxUrWtxGwsM9qVbyjQAzNffd1UKKxE+i89nMAK/AhItWclzC6Q8 ONxXccULHhMCZdKXCAq8LUFJFCmH17ShaeIwD9aAsuMax0dxJz785/BT1Y96nJLBdC53Zh0RkpV I1AK1SvVhUABmnQz/A2Hmu8hRXyNxFiv6WI6LYIskwmrma2P7aW+FSu5u28GsCJMcBE4= X-Gm-Gg: AZuq6aKTXLO9AyT1NBW1+KVjgl9mW+pgliGJe2mP4OOpo6+7hnCbWRiT+0KPbQE/gxv tEKUJRNK2b9g3Pv8v0Tk+4nsMH9mlr8KiqeEz2aftfnReTZaJ2Ibv6MBwEkhAuQiTmi9XimgySk QuwPTo7SJis02pDy8uvEPt3DEQG4bltPNlOOrzGMR6HVpBltlG0GiRnufB4HNSAEbcaR9pcY3P1 kHYv/RujhPflJwsdzkQsCvJv1ScWgt9OOL1LN45YDQ7NHnk0GkeLzRbZoklGYTNRi6r9RbskvYO j1KPLZ3U8bH2aFToNTfs9oB+k2scnY5As8MjYWkH7iVijoLXgY6omf6R+b22Raw7GyKRRliHS7v kU0LPhHvLGqs9sY4x+PD+DHLBr6SIqcotbqSN5pd8IEEfB5Pe3RNyQUotDY8pOBnN6fLyj3LyeU /ZhBU= X-Received: by 2002:a05:620a:4441:b0:8cb:1d7a:3f33 with SMTP id af79cd13be357-8cb4084bbe4mr1324179285a.4.1771325747285; Tue, 17 Feb 2026 02:55:47 -0800 (PST) X-Received: by 2002:a05:620a:4441:b0:8cb:1d7a:3f33 with SMTP id af79cd13be357-8cb4084bbe4mr1324177385a.4.1771325746709; Tue, 17 Feb 2026 02:55:46 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65bad3f129fsm2234759a12.29.2026.02.17.02.55.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 02:55:45 -0800 (PST) Message-ID: <5dd7834b-2e9c-4865-af6f-c362aa0c8287@oss.qualcomm.com> Date: Tue, 17 Feb 2026 11:55:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/9] soc: qcom: ubwc: add helpers to get programmable values To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen , Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, Wangao Wang References: <20260125-iris-ubwc-v4-0-1ff30644ac81@oss.qualcomm.com> <20260125-iris-ubwc-v4-2-1ff30644ac81@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260125-iris-ubwc-v4-2-1ff30644ac81@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDA5MCBTYWx0ZWRfX+cfc5M5gVnR0 dcINFSJ3ujm/+RMT7t3fGK63m94adLVOvcKB7KwC+ADCw7X2vPlzB3nGwU4kMkuiKLSY/bl080N uRaguBjStTMjfYqkrENfkV1XtJfFzyeU+1U0OBA/5sBsMhhmV0OPePwTC6FI7SRGz1NGnSRNHhq m54+x9KGzvZyoCLNCAenpddF41JNXuS/2ozmoEBeLbwy8ZiZl9PReGS5VsQyznIeOEjEbTfGAlU ZxB3id9OFTe90paj54xzTde3fMMSKVJUWnWiQ5DYZKIDF55mtxtCCZLfT4fVIOn8IgQ7lzXtFhP CUvdL8TotC2/KBBBzjI3/gLyVIrQRboa3SV7IUO1oGWe+VT8ynvk4JhVaubMYxhPz3EfhophTd2 JxBmdQILE1yUhtoJExgefFWM4PbmiQEA1YkipKu5VF9yosRoC49GIF1hbRCwSYRY/3M8aHgHrxi 8yDrPBwbXURyHyASomg== X-Proofpoint-GUID: s3Wv45i3fl63RIq9V58giIfplm1xMlvW X-Proofpoint-ORIG-GUID: s3Wv45i3fl63RIq9V58giIfplm1xMlvW X-Authority-Analysis: v=2.4 cv=TPNIilla c=1 sm=1 tr=0 ts=69944933 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=gMz6hfKilskiRDmxBycA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 spamscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170090 On 1/25/26 12:30 PM, Dmitry Baryshkov wrote: > Currently the database stores macrotile_mode in the data. However it > can be derived from the rest of the data: it should be used for UBWC > encoding >= 3.0 except for several corner cases (SM8150 and SC8180X). > > The ubwc_bank_spread field seems to be based on the impreside data we > had for the MDSS and DPU programming. In some cases UBWC engine inside > the display controller doesn't need to program it, although bank spread > is to be enabled. > > Bank swizzle is also currently stored as is, but it is almost standard > (banks 1-3 for UBWC 1.0 and 2-3 for other versions), the only exception > being Lemans (it uses only bank 3). > > Add helpers returning values from the config for now. They will be > rewritten later, in a separate series, but having the helper now > simplifies refacroring the code later. > > Tested-by: Wangao Wang > Signed-off-by: Dmitry Baryshkov > --- > include/linux/soc/qcom/ubwc.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h > index 5bdeca18d54d..f5d0e2341261 100644 > --- a/include/linux/soc/qcom/ubwc.h > +++ b/include/linux/soc/qcom/ubwc.h > @@ -84,4 +84,19 @@ static inline bool qcom_ubwc_min_acc_length_64b(const struct qcom_ubwc_cfg_data > cfg->ubwc_dec_version == UBWC_3_0); > } > > +static inline bool qcom_ubwc_macrotile_mode(const struct qcom_ubwc_cfg_data *cfg) Should we rename this to something like "qcom_ubwc_macrotile_mode_8ch()"? Konrad