From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 215FA2F5486 for ; Wed, 13 Aug 2025 23:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755126557; cv=none; b=hWNk83IahjL6Hz18LTtSShCCr2j8aUAFgrsBCbtrjzEVaIQF8z2+5WtYd2grar7iubP1NlaP+KgkGLibO8EFsRWvJLuaxilB4Y1YhmeiZulr+ddUnU26FFgYGLatoEZ81xX/6MisgVFD+vMt2XA1Wxe3INP54axKkE00oQGqRoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755126557; c=relaxed/simple; bh=T82FpN5osHxI2y1iccKhkwVh6JluhHia2thiRO8gHWs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wyc//WdGmJeF75xgQe/ODZZD73urlo0LKVF1nmvB2S1EY4OikXUYu20WycytKdSAc/waaqbPfZ547TyC7GsBnOjGd1FE8xrcDfAv6PuXyL7RxzFbCSD9cIYgNv+fu5gEYAfOslK9x46T1tB7u80deXu+dIyeSnOrkw8Y84tD7zc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JukDwkr0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JukDwkr0" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57DM0XYR026999 for ; Wed, 13 Aug 2025 23:09:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FW0Xg35JatzTxpNZ0mth0/VPTJXslvs1Vzzt18fSrD4=; b=JukDwkr0hdcUloBE 0Pwz3thW+Aamrdc92pJ54L+QVhN1XdYWu/ebx7UYEc8fMsL19o3UwgkZLrJn+/TB zZPCxGmFWFarR6cXMeViL3ubA4LgNbsXFMATUqk3UiV43tTh0p78FGQXDmWSJWN+ JfIRg45FLC+Jl+5sEC19nEot2JC6IHtvzjgOVAqZc3C7R3SGO1WBQ/CaHcHUmY7j vcbTgDyETQfzv+FCKAt6vn9I/4D7z3R54Ori80S+5hkbxgqbQ9hUbrWBU5FMw3iQ Ybtxn+YMo+nMdtwxYwqlMJNW9C5PtTmOjzf/B/tuUzb5vBXPPjwZJY4eFZVtCcLc hh3oiQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48dy3gdfc4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 13 Aug 2025 23:09:15 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4b109af71a5so1863431cf.1 for ; Wed, 13 Aug 2025 16:09:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755126553; x=1755731353; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FW0Xg35JatzTxpNZ0mth0/VPTJXslvs1Vzzt18fSrD4=; b=UjHn9xcYDjODA8wPjouAjVqJvvIgAlGYgJ0YTxkZXfx/E7UPpslwfDey/VScQf60q6 j6MoPlX7CsLBP6gk+G05qGctNJcD1BYTfzwLAhn/A9B0UtMwqlWNaT6w869nKAOXzg35 8yhGiMdGU3D2aV3/hF0fhDhx+XHqutuPyoG/ivq97CSHy31w2hJFqL6J+9WEpw1vgdTN wDVzU43kFSqSDHC7XXekdlXudi4WrHiZFFCS8ajuj9X/FFU1R1AFKZtx4itppst6pwMx uoaFLWyWWBQcT4aI1RTL9bv0LpL88IWrmDWvxrR0LtBxf6ONXhEJvIjwMyiWm4uzvCc1 nB4w== X-Forwarded-Encrypted: i=1; AJvYcCW/aFWQhxF442phA8JMyXeEMSCUv/Y7qc2UhYRDuZUTfjaTiARaQiAode0JtBAtgrWOIJmWCtE5eFosj74=@vger.kernel.org X-Gm-Message-State: AOJu0YzJT2utQCmKk0CTeriUjRz6becEaHV2rEJDif+riMUF6IRRT/kD f9gIVovivjcbDGUeVLTwNKBYvUqg+zGmloVXEBC9Y/i7bPabIuDK2hOfYUFej3XBo4xD6UjK42h GO1ms487kY6iRSYR20LVWsqILjumXM+HkHo9CwTvxAw/xcYNc3kOegJeg9J4o6N1IBZqyJIxG6o U= X-Gm-Gg: ASbGncsYzkZc1icmEt6bqH+Sr+l4rI04CrprykD3nLrbu7+MpfQjksIW1T3FnnQefn2 61hQRHNnKVdWiC4HTk5S/QpICv/9HDJCI8YIxroxQMjEezyTkNu9Qxpo9gi/SlfvXR9rq8cA6va 9X1GQz2pECSP7t0zuwIUXRjZTHFg+z2x03vb2FDBaX7ZUizKdR/x3ropS9V4Tb/EUYwXWwUwGmJ Zr0pwCeV37yAPbXXalo9UfrezjAuGQZBWnumg7fe5XufG8NeInESE0nHxmHkrgd5Xo2UAfYgXPG PFagPKstOXB9WvaMtvok9p1AzC40Sxcrrl4FmEp1xogD2ghE3IJesDX+bXch7sLKE4MAor01vXL seeXkZk0sVAxJ0pXJMg== X-Received: by 2002:ac8:5f8b:0:b0:47a:e81b:cca6 with SMTP id d75a77b69052e-4b10ab1409cmr7447271cf.10.1755126553474; Wed, 13 Aug 2025 16:09:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFksB5csn2J3qmtm/tHxIR/kI2a4tn8gLl4tYqT+oofHMStplfH8BbgDxQxUxAzjW7zZrDbTQ== X-Received: by 2002:ac8:5f8b:0:b0:47a:e81b:cca6 with SMTP id d75a77b69052e-4b10ab1409cmr7446991cf.10.1755126552867; Wed, 13 Aug 2025 16:09:12 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a0a1bf9sm2482327766b.31.2025.08.13.16.09.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Aug 2025 16:09:12 -0700 (PDT) Message-ID: <5de00c2e-2b81-42f4-ab17-6db0f1daf7ff@oss.qualcomm.com> Date: Thu, 14 Aug 2025 01:09:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/9] arm64: dts: qcom: x1: Disable audio codecs by default To: Stephan Gerhold , Bjorn Andersson , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Johan Hovold References: <20250813-x1e80100-disable-audio-codecs-v1-0-af82d9576f80@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250813-x1e80100-disable-audio-codecs-v1-0-af82d9576f80@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=X4lSKHTe c=1 sm=1 tr=0 ts=689d1b1b cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=KKAkSRfTAAAA:8 a=fBsYT2r0rtnNRkE0zdoA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA5MDAzMSBTYWx0ZWRfXx8lpU+qOCPgB tsWb2mdwhP0U2ovYL/1yQFpVLbbiJZR4qL3C1w4t1o+SyTRTONTfiiDT+5lagmFate6AJes5HAY 03DiNO7OzSJHlNTemkiVU/aGz7Y7CQhX18ThtnzCJrMubJbfk0hZqQCYjBFazivRwOL1GwTyYUE h9f2C9aAI+g/kV9H4t/hc2coZpTOiRoihlMNIOu6Z1eMQp3XxP/tGGjXNXzUVisUNHW+e16X4Sp fnN88YPYhLlFtMKlLynEEJtUxd0p1i2LcBCb4FqZeiuOla4iSdA+FWlHNEn9XBJMBYffjYN4MN0 SmaSaG4uvFBY3LLqjgojQqIfh6u5frnfajz4i/bsOCVPaGm2kbHgxSK28xpjSe1PEtPQ7b45Knz Pn0Fe+vh X-Proofpoint-GUID: FBcnTcp3RgzRFGErn-GOaCK7-a1NHDxC X-Proofpoint-ORIG-GUID: FBcnTcp3RgzRFGErn-GOaCK7-a1NHDxC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-13_02,2025-08-11_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508090031 On 8/13/25 5:58 PM, Stephan Gerhold wrote: > Currently, the macro audio codecs are enabled by default in x1e80100.dtsi. > However, they do not probe without the ADSP remoteproc, which is disabled > by default. FWIW if the ADSP doesn't start, you can't really consider the platform working.. It just does oversees too much of the SoC to even seriously consider using the device without it I would maybe perhaps even skew towards removing the status=disable from under remoteprocs instead.. that the user may not supply firmware doesn't have any negative effects as compared to keeping it disabled (other than a line or two of fwloader complaining) Konrad > Also, not all boards make use of all the audio codecs, e.g. > there are several boards with just two speakers. In this case, the > &lpass_wsa2macro is not used. > > Disable the audio codecs by default in x1e80100.dtsi and enable only the > used macros for each device. > > Signed-off-by: Stephan Gerhold > --- > Stephan Gerhold (9): > arm64: dts: qcom: x1-asus-zenbook-a14: Explicitly enable used audio codecs > arm64: dts: qcom: x1-crd: Explicitly enable used audio codecs > arm64: dts: qcom: x1e001de-devkit: Explicitly enable used audio codecs > arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Explicitly enable used audio codecs > arm64: dts: qcom: x1e80100-hp-omnibook-x14: Explicitly enable used audio codecs > arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Explicitly enable used audio codecs > arm64: dts: qcom: x1e80100-microsoft-romulus: Explicitly enable used audio codecs > arm64: dts: qcom: x1e80100-qcp: Explicitly enable used audio codecs > arm64: dts: qcom: x1e80100: Disable audio codecs by default > > arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi | 16 ++++++++++++++++ > arch/arm64/boot/dts/qcom/x1-crd.dtsi | 20 ++++++++++++++++++++ > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 13 +++++++++++++ > .../boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 16 ++++++++++++++++ > .../arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts | 16 ++++++++++++++++ > .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 12 ++++++++++++ > .../boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 16 ++++++++++++++++ > arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 19 +++++++++++++++++++ > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 12 ++++++++++++ > 9 files changed, 140 insertions(+) > --- > base-commit: 33a21dab19b31540dfeb06dde02e55129a10aec4 > change-id: 20250813-x1e80100-disable-audio-codecs-ef258fcea345 > > Best regards,