From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A3602046B0 for ; Tue, 18 Mar 2025 08:53:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742287988; cv=none; b=PKjnNPhP4USFeR7TPXSbUNyYchZs/TKqCKp4hrceDme/x8yH0z/7PsrVfiTKbu5JlBEppelcfavvvYBKkhT7MMm3c+p894L/1FjFN0eIWKzCXOkE1xxEWFxkyKACcRwpVKrb2MpqUm0OgCTHkqYlb0QBNQufTvJlgzkzH2GnSyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742287988; c=relaxed/simple; bh=nBqnAgBHS2l95Pjj/TfnmDtdp5MvYiOaOhdplM2mhmg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KF+D3TpixAp3oSj6umomKHF6E/Llv6/kzOZ3CAjV0hci7SckqkpvFPXqm7wn12kPJQ6ylsav9PRMMgk26ZvT6Zi8dkiTk7bvMP84e+E5klk+8HbkQNx0mrYbVqfVNpNDq4XNtXmf85bTpG3RNX07Un2m6+G65aMcYI2oHB6O+X0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SQUxXxi1; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SQUxXxi1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742287984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tObLTe69QFxvzolejx3T+2gunDSqNceNELAPgsdaeHE=; b=SQUxXxi1LvHvGtYA1AOZV/fmy6+ksZWbKLHTVSj7aR/awDDE9bC8JJhWSkQIMCHOWN+mco q4XRiXdlbYXe41eQkGA5BFepuj9qvwMUlVxpTsiCEOFY5vvkloi7EXeLq+Kr5dmU7Lc+IB JSFmKN6Jtts6Z3QNMbuQdhEiGr93Of4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-UuXZfVe0OIGvJYOs6JXooQ-1; Tue, 18 Mar 2025 04:53:03 -0400 X-MC-Unique: UuXZfVe0OIGvJYOs6JXooQ-1 X-Mimecast-MFC-AGG-ID: UuXZfVe0OIGvJYOs6JXooQ_1742287983 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43947979ce8so14988835e9.0 for ; Tue, 18 Mar 2025 01:53:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742287982; x=1742892782; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tObLTe69QFxvzolejx3T+2gunDSqNceNELAPgsdaeHE=; b=WrElrFxsfnhy4qbpRqHPETmbSxvZm1iSJG+W7p43XWhqscqOJGuh0yPYXOTXeEGrS9 si0Vak390ql8l4VF1OedrFN8VCujr0yf/FZFF1ome6AVofE0CjzVVIma1SYiD/yOhkye h9PIlIJGWHQwxuxEG/cDEkhojrOcZLD/c7Iy/2Tyebi1MCtK5VLmEJbETaQVe/rGNCJk yvffTrHUrTLeyT7mSqu0PvQek0qAVp+fWPS0ZwPtC3O5k4foLj7yhu/A3oFq2GXVoQ05 VIyT7udM1tpSFwHvsrizpeUhjyZ+zUUXupFVrLwzLbSnaRy4FcWLoxASG0Al3phnk9aK 7XAA== X-Forwarded-Encrypted: i=1; AJvYcCWppD/uRQGoJpCXNkHWiQL15DuZ4bbwoDt00eOv88P5S+yCKYVtYviuPyjPV7M4UNqmGJz85s+S/8e9OEA=@vger.kernel.org X-Gm-Message-State: AOJu0YyVMxJHY1Ud7iwv/akzP2R2NDOBAZHbbhwjCzRw+ytb9RIPpDL0 KYRzJtGJMAOZzLCTLnNf2Ys1wqU4gmnk61iIMQhR0pMVEv62H94bLbnYt/vDfJKEZKlQoHng/Tz B7VScdwyUh0dUMbISkYS3LsZwnxyBukGfO+BXDOeZqWdergvWcQH4Sf+n78TlVQ== X-Gm-Gg: ASbGnctZY/TBs3CtV6QDsSSXghAZgQB4uloXOdqAnqoNmA6Cxt+GrguMe0ZLo3WA4LE OgVXmmcIYfhD4/de0EwOybIlubKBD6/f2gRto+2WXg2aOg52wwMS0xj1kRZrdDrOVJ8mS7bilhl UYk6rKaZCkJZOb5yjg7nDNJHBRcBLOe5Ei2s3tmKrBGQa5eIzZyRHUnEXCsXCgkCXYXONcwKMu4 bBV1trCIQk9QumnEcNPpr1nqGwsCZEzlyY/gUkzAOfmyHpsh3i5OVHr60D5QZdfHwx6fwtkEivI YH2tTkoaGS2NcVQpTl8q7ZXjHjM3APbPKG0eLlZxHzJkAg== X-Received: by 2002:a05:600c:1910:b0:43b:cc3c:60bc with SMTP id 5b1f17b1804b1-43d3b98e784mr10214295e9.15.1742287982467; Tue, 18 Mar 2025 01:53:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLxkKyNtE11z59H06IZJtl8h4j7bAu1UH3i6QG52S1C4EP04HZjwsPQi3k1NceSqvEw/VDKQ== X-Received: by 2002:a05:600c:1910:b0:43b:cc3c:60bc with SMTP id 5b1f17b1804b1-43d3b98e784mr10213835e9.15.1742287982025; Tue, 18 Mar 2025 01:53:02 -0700 (PDT) Received: from [192.168.88.253] (146-241-10-172.dyn.eolo.it. [146.241.10.172]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c8975d65sm17738818f8f.56.2025.03.18.01.52.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Mar 2025 01:53:01 -0700 (PDT) Message-ID: <5de5943b-5527-49f6-a454-b3c7358cff56@redhat.com> Date: Tue, 18 Mar 2025 09:52:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 4/9] net: devmem: Implement TX path To: Mina Almasry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kselftest@vger.kernel.org, Kuniyuki Iwashima Cc: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Simon Horman , Jonathan Corbet , Andrew Lunn , Jeroen de Borst , Harshitha Ramamurthy , Kuniyuki Iwashima , Willem de Bruijn , David Ahern , Neal Cardwell , Stefan Hajnoczi , Stefano Garzarella , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Shuah Khan , sdf@fomichev.me, asml.silence@gmail.com, dw@davidwei.uk, Jamal Hadi Salim , Victor Nogueira , Pedro Tammela , Samiullah Khawaja , Kaiyuan Zhang References: <20250308214045.1160445-1-almasrymina@google.com> <20250308214045.1160445-5-almasrymina@google.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250308214045.1160445-5-almasrymina@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Adding Kuniyuki. On 3/8/25 10:40 PM, Mina Almasry wrote: > @@ -931,10 +932,67 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info) > return err; > } > > -/* stub */ > int netdev_nl_bind_tx_doit(struct sk_buff *skb, struct genl_info *info) > { > - return 0; > + struct net_devmem_dmabuf_binding *binding; > + struct list_head *sock_binding_list; > + struct net_device *netdev; > + u32 ifindex, dmabuf_fd; > + struct sk_buff *rsp; > + int err = 0; > + void *hdr; > + > + if (GENL_REQ_ATTR_CHECK(info, NETDEV_A_DEV_IFINDEX) || > + GENL_REQ_ATTR_CHECK(info, NETDEV_A_DMABUF_FD)) > + return -EINVAL; > + > + ifindex = nla_get_u32(info->attrs[NETDEV_A_DEV_IFINDEX]); > + dmabuf_fd = nla_get_u32(info->attrs[NETDEV_A_DMABUF_FD]); > + > + sock_binding_list = genl_sk_priv_get(&netdev_nl_family, > + NETLINK_CB(skb).sk); > + if (IS_ERR(sock_binding_list)) > + return PTR_ERR(sock_binding_list); > + > + rsp = genlmsg_new(GENLMSG_DEFAULT_SIZE, GFP_KERNEL); > + if (!rsp) > + return -ENOMEM; > + > + hdr = genlmsg_iput(rsp, info); > + if (!hdr) { > + err = -EMSGSIZE; > + goto err_genlmsg_free; > + } > + > + rtnl_lock(); The above could possibly be a rtnl_net_lock(), right? (not strictily related to this series) The same for the existing rtnl_lock() call in netdev-genl.c, right? /P