From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Khadija Kamran <kamrankhadijadj@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
paskripkin@gmail.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH] Staging: r8188eu: Fixed block comment
Date: Sat, 18 Feb 2023 20:11:01 +0100 [thread overview]
Message-ID: <5de7b776-4fbe-f6f8-ffa9-fdef337c9c20@gmail.com> (raw)
In-Reply-To: <Y+8p7Hyaf4LhO/Sw@khadija-virtual-machine>
On 2/17/23 08:17, Khadija Kamran wrote:
> Fixed block comment by adding '*' in each line. The Check message was
> shown by using checkpatch.pl script.
>
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
> index a7c67014dde0..03025dc89533 100644
> --- a/drivers/staging/r8188eu/core/rtw_br_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
> @@ -36,15 +36,16 @@
> #define WAIT_TIME_PPPOE 5 /* waiting time for pppoe server in sec */
>
> /*-----------------------------------------------------------------
> - How database records network address:
> - 0 1 2 3 4 5 6 7 8 9 10
> - |----|----|----|----|----|----|----|----|----|----|----|
> - IPv4 |type| | IP addr |
> - IPX |type| Net addr | Node addr |
> - IPX |type| Net addr |Sckt addr|
> - Apple |type| Network |node|
> - PPPoE |type| SID | AC MAC |
> ------------------------------------------------------------------*/
> + * How database records network address:
> + * 0 1 2 3 4 5 6 7 8 9 10
> + * |----|----|----|----|----|----|----|----|----|----|----|
> + * IPv4 |type| | IP addr |
> + * IPX |type| Net addr | Node addr |
> + * IPX |type| Net addr |Sckt addr|
> + * Apple |type| Network |node|
> + * PPPoE |type| SID | AC MAC |
> + * ----------------------------------------------------------------
> + */
>
> /* Find a tag in pppoe frame and return the pointer */
> static unsigned char *__nat25_find_pppoe_tag(struct pppoe_hdr *ph, unsigned short type)
Reviewed-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
next prev parent reply other threads:[~2023-02-18 19:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 7:17 Khadija Kamran
2023-02-18 19:11 ` Philipp Hortmann [this message]
2023-03-09 9:10 ` Greg KH
2023-03-10 11:52 ` Fabio M. De Francesco
2023-03-10 12:09 ` Dan Carpenter
2023-03-10 12:25 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5de7b776-4fbe-f6f8-ffa9-fdef337c9c20@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=kamrankhadijadj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®