From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0558D1FBC8C; Fri, 3 Jan 2025 15:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735919894; cv=none; b=OWUu9YGRkeZazNf/M6JwX3v3I+V4YJzkpaW8cXxT9wcNyuN2GVj279C1quEKREWJ6g0aZ7euAv//CYL5PpcprwnGDegJYF+fcnGHcGKtn+XDQc8LLizBs9z5qCpYX0V1P1lzxHJ1vFaBK7R1HO30Xc44j4e5OB/aOcag1rd4Kt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735919894; c=relaxed/simple; bh=3IrzjT6gl+FaklBooWlxoSBBE08JetmJ/xWsWjvZdcs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cef67jZUwVV6CwZ9FUzOVBOqdt1AFe9VKNbd5B5XB2fwe93dIajFRkkqJDe8qnNJVPAd7dmJUwFlpo6lQQFEBGePiIeKgP3BLfpNVKJc1VkxvUCYQRWklQzWJxCRLcIuws4VcvwVQrr/GqEWL4hSIfR1yWyTR82+zG6Jcn0AVjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eBXx4Igk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eBXx4Igk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84AA1C4CECE; Fri, 3 Jan 2025 15:58:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735919893; bh=3IrzjT6gl+FaklBooWlxoSBBE08JetmJ/xWsWjvZdcs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eBXx4Igk/IJlguIVS/gVKj8Y4JnuLL/cOIQIFBJBrEN4jtag9uR6hfNHphj14nP9M 5xrHGkif3DKCN0siUBKXX6sXZpK+0qYm4YIwW7uGrldZy2yVnd0JkxjjC9l5yZTaIf TkgQDQdZMgr7vPnifgQYnbhey8Y1zn8poKQ63Mlyspn8NR1OzO4dZxwXCTraPCHel0 Dmu967JD2uLWNmv7sVNBRt+yCSncCXxqQDC6uCeHEAdbZwWCjp5EiYEhkNvALz/eXc zb9j0CON6IfuOyyVRnCUP3TWOCJcr92mXaOBvVVcvSiFoGKbLQ9Y3pNOYdB8twoGpW fjoO4nL4Yk9rQ== Message-ID: <5deaaba3-9acf-4715-85d1-6c1f62ccc604@kernel.org> Date: Fri, 3 Jan 2025 16:58:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] arm64: dts: morello: Add support for common functionalities To: Vincenzo Frascino Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Russell King References: <20250102155416.13159-1-vincenzo.frascino@arm.com> <20250102155416.13159-3-vincenzo.frascino@arm.com> <9f430795-03c4-4ff4-ad71-92273877459a@arm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <9f430795-03c4-4ff4-ad71-92273877459a@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/01/2025 16:32, Vincenzo Frascino wrote: > > > On 03/01/2025 07:53, Krzysztof Kozlowski wrote: >> On Thu, Jan 02, 2025 at 03:54:14PM +0000, Vincenzo Frascino wrote: >>> The Morello architecture is an experimental extension to Armv8.2-A, >>> which extends the AArch64 state with the principles proposed in >>> version 7 of the Capability Hardware Enhanced RISC Instructions >>> (CHERI) ISA. >>> >>> The Morello Platform (soc) and the Fixed Virtual Platfom (fvp) share >>> some functionalities that have conveniently been included in >>> morello.dtsi to avoid duplication. >>> >>> Introduce morello.dtsi. >>> >>> Note: Morello fvp will be introduced with a future patch series. >>> >>> Signed-off-by: Vincenzo Frascino >>> --- >>> arch/arm64/boot/dts/arm/morello.dtsi | 341 +++++++++++++++++++++++++++ >>> 1 file changed, 341 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/arm/morello.dtsi >>> >>> diff --git a/arch/arm64/boot/dts/arm/morello.dtsi b/arch/arm64/boot/dts/arm/morello.dtsi >>> new file mode 100644 >>> index 000000000000..67bc960f4596 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/arm/morello.dtsi >>> @@ -0,0 +1,341 @@ >>> +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) >>> +/* >>> + * Copyright (c) 2020-2024, Arm Limited. All rights reserved. >>> + */ >>> + >>> +#include >>> + >>> +/ { >>> + interrupt-parent = <&gic>; >>> + >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + >>> + chosen { }; >> >> Drop > > Fine, I will do it in the next iteration. The file you asked me to see > (sm8650.dtsi) has the same expression. Because it did exactly the same as you here - copied it. > Why this is incorrect? What's the rationale? Redundant, makes this code unnecessary bigger and raises question: what if something relies on it but the actual dependency is not expressed/documented? ... > >>> + interrupts = ; >>> + clocks = <&dpu_aclk>; >>> + >>> + hdmi_tx: hdmi-transmitter@70 { >>> + compatible = "nxp,tda998x"; >>> + reg = <0x70>; >>> + video-ports = <0x234501>; >>> + port { >>> + tda998x_0_input: endpoint { >>> + remote-endpoint = <&dp_pl0_out0>; >>> + }; >>> + }; >>> + }; >>> + }; >>> + >>> + gic: interrupt-controller@2c010000 { >>> + compatible = "arm,gic-v3"; >>> + #address-cells = <2>; >>> + #interrupt-cells = <3>; >>> + #size-cells = <2>; >>> + ranges; >> >> >> Missing reg.... and why do you have ranges here? No children. >> > > I will remove it in the next iteration. > Next patch brought some answers here. I just don't get why entire GIC is not part of the DTSI. Best regards, Krzysztof