From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759149AbcHYPvT (ORCPT ); Thu, 25 Aug 2016 11:51:19 -0400 Received: from mout.web.de ([212.227.17.11]:61862 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756538AbcHYPvR (ORCPT ); Thu, 25 Aug 2016 11:51:17 -0400 To: linux-arm-kernel@lists.infradead.org, Al Viro , Dave Weinstein , Jeff Layton , Kees Cook , Nicolas Pitre , Russell King Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Subject: [PATCH] arm: sys_oabi-compat: Use kmalloc_array() in two functions Message-ID: <5deba521-2dd4-cd2e-23d7-226a1a7728c3@users.sourceforge.net> Date: Thu, 25 Aug 2016 17:50:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:FavF8FKA7G5+s1VKewuckVst29TspgBVLwj3Olh9GiOOPYZ+/Bs uQsVfm+9WveeJv+0Pe3sj5+AzzHBnu/1UWcDwEG/aPuHR3FZQ2woy6uW64rUs5KAeqkssua qcIXXQP8bo4LPdaYYbp+wlt3KAFiNmsA/o+v6ra2nJW75TraFhsT07iZJql92bQpkhCI6qb Sw7EOHQguLmGh2fPoYfkg== X-UI-Out-Filterresults: notjunk:1;V01:K0:zQC8Rn6Iy00=:qY6iMnN874Bg7p8SKkFV8z kkGIRyqkoR+LbAVdMGB+ziUbs3KTSQQ+uxk9w40/gzFG3ETFa2kjn/vN0NElAkVqv+Bcy225r 5HGWZX6cpqABc91ySjABkBcFEiTAvmCO/+tvybpx/cR7C4GhpZ54LkISYBzr5T1n9FoZyilyr iOj75fT0/mFBHQeum1VDWCBU6YHoKeOig1hlVbMz8AnT8jCO4t7KFaaI0wNWCSQ4AkyG/Auyc rAzSGcb0M3g4VAL+5ieCnhXRR796akFn6MtEL3x7fVDpXQHXuFIUYccI5KDBxfDhdKk5TiQ7n fIWt6WPLKf60ikgfilFYc3zZ2IXwqf0lwDlh9uSC4/Jwp1ynHjh1mlJKwwcakLcM5FLvMX9Fo 8oqfpyeTmV6LkPok9pjUgRW+aPYHypc01tgN1WfMu0Z8dNi4J23OVtDRvkVMAWzmu8LxSii/h CaErGSt3D4Sb2cyILRXWV9UtgzP50HjWY5gHXKiCMvHi4Q38pY/Yei1fbL0mGH1xCHaHEEjfQ J4K61BU2FOf2c4xGAfGnzLT2e3tkkay/DWf9cXrAiGodslvSgB2zj817WGmXiXIzl+dKD63U8 45uj7vgijA0eEEjE0ruu3LDoaUv0u9QLZ3Dc523IJj/dSCJ9/Ra7lOjbCpyWXVEr95ML1DtFN 382zHQPOOAvI5PModAqjVrTbYfmFnMnWaPWRXbGkan6ksA89i+zqRnNsVExoyQU3tFSYcWPXo 0lOkkQJ2hUvmgjU/jrxxhyqbqZuxG7C/lkTKukQj/kHs1ChY0COuTkeI/mtlBrFO1G40AhJ3+ a7tnJKNfIiJU+nLd5ic4YSc60EZ0g== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 Aug 2016 17:45:23 +0200 Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/arm/kernel/sys_oabi-compat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/kernel/sys_oabi-compat.c b/arch/arm/kernel/sys_oabi-compat.c index 5f221ac..e624db9 100644 --- a/arch/arm/kernel/sys_oabi-compat.c +++ b/arch/arm/kernel/sys_oabi-compat.c @@ -285,7 +285,7 @@ asmlinkage long sys_oabi_epoll_wait(int epfd, return -EINVAL; if (!access_ok(VERIFY_WRITE, events, sizeof(*events) * maxevents)) return -EFAULT; - kbuf = kmalloc(sizeof(*kbuf) * maxevents, GFP_KERNEL); + kbuf = kmalloc_array(maxevents, sizeof(*kbuf), GFP_KERNEL); if (!kbuf) return -ENOMEM; fs = get_fs(); @@ -323,7 +323,7 @@ asmlinkage long sys_oabi_semtimedop(int semid, return -EINVAL; if (!access_ok(VERIFY_READ, tsops, sizeof(*tsops) * nsops)) return -EFAULT; - sops = kmalloc(sizeof(*sops) * nsops, GFP_KERNEL); + sops = kmalloc_array(nsops, sizeof(*sops), GFP_KERNEL); if (!sops) return -ENOMEM; err = 0; -- 2.9.3