From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793717690; b=AKqUvFRbUEYERhcyVxkkaiQxeoZvrFEbt5C5ZXZJUQVlis8S4RtGF0/ewtUScxxKZdWv 1q/+UZV/YQrbFwNn+6KdX8EWMwotU5ZPzgqDIAyqCz/Xx0qPEiK3BthWnIwVKQanAdAAt GbxatyE4Apb2Ie3OdoOHEjE096BIecIjDEInxb2d1iyxnPyJDcyaU6p8KizFQua8WkMds CqvpEARmj3Q8WHhSLHldX30UZfE3oHa5ndQFvhT+NRCBGSMZ47Rzq/AyseRt2wdaNF56m +JXzK2l4c4i3nlwc+RwmlCzZTfqnMQekOzJ9bDKpX8M752fDiIOdC5OUZc/Jes3RE1w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793717690; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Authority-Analysis:X-Proofpoint-Spam-Info: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-GUID: X-Proofpoint-ORIG-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=XwK7pIFH2QUcKHLvESz9ooBqZDoO68FmReNGUgwY1OU=; b=YoY5k0eHDjEKqv67JNnzpDVe06F/RXmFgI68b4BpgMyeSriihjles9rZv8RYndBCeI3P Co0lvQeoqrQnZ1oAdrBQc9QsBdojGM6D0yPx0r4pHA22vLTULKG5yxhLflsEBDlpmI6bA UHfFR5+BJ4f27W/WLKMdqWIgGSNaO6PBOinbibMlBM/3P9iPx/LiuXb7TskaQW2/VHsUX REvyxvPh8oL+WwvffeeO+ZFTMWG4x6Zny5c9npny1yy8UuTMNspXXMsEw//irOLTuI+hf 6mZe3UNovLe5U/juqLLGwtaWZ0kkvm6KzIEw1M5TtXPtokNZq4eSKVKFH6G2J0hw9ug== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=FYstDD7F; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Y2rJTuhh; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E4C9606A334 for ; Tue, 3 Nov 2026 14:54:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8E4C9606A334 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=FYstDD7F; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Y2rJTuhh Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A3E9qQ74103896 for ; Tue, 3 Nov 2026 14:54:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XwK7pIFH2QUcKHLvESz9ooBqZDoO68FmReNGUgwY1OU=; b=FYstDD7Fm+ZmzrwA Pu9d48BKgdzgeQAnuyKjmn2S7WTwGtgCj6D7Gam+7IB3rC8SHUttz9ymcaNsND+E m6FoGS8slbo5RUiPvdLF6pdgI7YxeUONRxzvnre+eiVq9+/dhKxpyC4O7cHB4SN0 e8aH3uIJW+g7AXM+63TkJnKeYalm/Jub+LD1rPbagvmPiHDGtxtB4PqSQeSo4CUF 74qWk3Uco0nh+E96o7aAteljnRmxCFhFMrlLwEIPAdP8cefmC7S77GP9STWUTYwH tV7Kjd0U57xVYxZ7gUDOuBho2rTSMpmojx4YbkQld7qfW+9j2UJ8kJXYdcV2LonX VSySxA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hq76dapav-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Nov 2026 14:54:48 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-91c046843f1so116834096d6.1 for ; Tue, 03 Nov 2026 06:54:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793717688; x=1794322488; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XwK7pIFH2QUcKHLvESz9ooBqZDoO68FmReNGUgwY1OU=; b=Y2rJTuhhHdP6B/kNIbOSrtQYY3fNKgWop2McoL0NeWRg8ZtboyPK4SbLey4cdOjfen P7pauTi9YCE5ijP5qdUstDrjW7Muw2RXHFoq3UkU2gE9RmKuoEceVg6vNw9LFqw5PMPl oee+cvm/AjBTZBKkH02BqTyaBuDTT5yu3JVuGAH5hu5K0PNIMXOTc7YVqtgyVqI6T1OY TPFpXs9T2YaAJKbU49alF7TiQaDIAWnK+zxSox/ODxBMWQ6u4scOUaHyFunGA6/FJzTM BFfAhIYwM39l0jDTTazH1yTomPvsxmW1ToX1jTcGrMY7V6JmUasS7+GmO2dlxp2AVzWG CUnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793717688; x=1794322488; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XwK7pIFH2QUcKHLvESz9ooBqZDoO68FmReNGUgwY1OU=; b=tDsZOEi9k57qHZRtWN58t9FBgGRk3hdxYWKQ6QP9wQEydTZHLEl+R7ZKrfx2Z5Ggrp Bfeh66BW5hbqLO9GoumsUYj/pVqrGiMyyEng5kuzu1SXXl+aEx2g/q2N85j7usIO1qVM MzzmZ6c6o1g9I5j1Y8Ie1ZKJGAkC6WheIorUx3lPRduRv4YD8vhoMo8Ch4NaNqaMfyCY luoAry9Yn/z/Y4dbpoi3HtMkxquMONOpKdKI9UAvzND15Sf+go/HJXReXtQrdu5ycxqF fyVCV2+ScHBJOIKD2h7dQB6NIcMk0Fh+CEnIW48FjUNN+R2QQUQglczUO5jQx9g6Njw9 bUeA== X-Forwarded-Encrypted: i=1; AKwUvBzTwLDSDU7T8qf6/MennnxjLZXaWbr9AcH4A2HW22xbaNou9jI6Gwcfm2EEFwyzhAqZYS4SEDbe6JM8GAc=@vger.kernel.org X-Gm-Message-State: APuU4Z/jkmHlXc6D3v+4uTIkZbdVPHQRq42/pnXUVSO0kEIAb/gz3xol ikGB0YMwzMTAno74kfj6XFgbWdO37OX0kuNGUuB8KssLCNSzuzTFGjm0FXKb37l+8aWXFK5z+x5 l08hWtGptKrHaQgdl4G579v3yDTg5bNHO5dBhQ6d+l55nfoGaTuuuuAwcfz/msLwABTE= X-Gm-Gg: AYBFou23wH8NgWfXZ0BxIqFgwuVOJBmp69NkzViJ8waxDtRI/GdTKDiIs14oGSRiQdx Mj4QisNqNPhk5wcQTGrgLcUtOCAuPQCWnKYiRSxfpMYmOa7o9fP/37mUZZLq7hnwGxTDhRed0lc k8LTs484sE0ocj91u9ztlT1+RrkjbtgCgQE1CxVEg1NYxQ0o1UZCmexRnFFV8Oig1qsnV1VYg/F eezd9MeeiRxjaSJYQjR/djUzKUEcU6THhw6llfVCbuxz5Chc13pb/xboOGUt6w0W+tpif/rdpZx 6H25hmC+Dz1syWq561j6RuMXF5fthNwvtF5nOiyw3YX/zNfCulJPckwefTY4uHm4pbBtE5exs9U o8BigRndtyayV0ArtjaY79lDk7x04OgRGEIRdeKNaLymHiQQYHoKMY9tqSMK40PaC4pSsYrFgqb aaJ7p3ynMhklAF X-Received: by 2002:a05:620a:84c4:b0:93e:66e6:fa4 with SMTP id af79cd13be357-94421712a8dmr2083492985a.16.1793717687639; Tue, 03 Nov 2026 06:54:47 -0800 (PST) X-Received: by 2002:a05:620a:84c4:b0:93e:66e6:fa4 with SMTP id af79cd13be357-94421712a8dmr2083490385a.16.1793717687198; Tue, 03 Nov 2026 06:54:47 -0800 (PST) Received: from [192.168.25.64] ([94.155.124.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4b2aae24b32sm60341055e9.12.2026.11.03.06.54.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Nov 2026 06:54:46 -0800 (PST) Message-ID: <5df59181-cb60-4e07-bb4a-6f3ae994798a@oss.qualcomm.com> Date: Tue, 3 Nov 2026 16:54:44 +0200 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/9] media: qcom: camss: Introduce SOF sequence tracking To: Bryan O'Donoghue , bryan.odonoghue@linaro.org, Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261102-v4l2-frame-sync-v2-0-25cbed7a772f@kernel.org> <20261102-v4l2-frame-sync-v2-2-25cbed7a772f@kernel.org> <8196a664-f73b-4da1-aea0-0ea49676a4eb@oss.qualcomm.com> <7f3e822e-3749-41c5-8390-e6d74b203927@kernel.org> <36008be9-2b25-4f04-995e-f90e2547f7f2@oss.qualcomm.com> <57a326a1-81f8-437e-bd4f-25f79e0cd1cf@kernel.org> <2cfa4a92-2be2-4f13-84bf-ecac133b525f@kernel.org> Content-Language: en-US From: "Gjorgji Rosikopulos (Consultant)" In-Reply-To: <2cfa4a92-2be2-4f13-84bf-ecac133b525f@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=KJTPn1Fo c=1 sm=1 tr=0 ts=6ae9f5b8 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=eGCDHFSXubCXFTSSGhjuOA==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=TiwfKaYzfpL80q5XJR0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMTAzMDA1OSBTYWx0ZWRfXyFtZJ8kfS8RA vgyOHMJ1TjWeBDJ/qAphN1o6Uv3g5NSaVW7ZFOuc7R975Zs6VKk2Vs3La39639rTonQmT/bo4C8 kUEKGsMhgjIdWnLmWtHCh5BKLr0MV4s= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTAzMDA1OSBTYWx0ZWRfX0paC/LNXsioa ro9bv2vOXaR/BNihngVVi+6vjh88PTwxr9cbQa59V5C+vqpLCaWUHAyEiZBSb3nmTsdp2doD0eP PquuhKnFcpOt/OHsZceM6FMJO7n63kfeif/IAo6Dtv+b/PznkIYXfmZvK1pzD5z1OAMOJXFVOe7 pVz7/SKP8J3Zgtum0S3P9rMDE0ZAwwn4X+60k1fVpPjuHDGkpwsOWGprg3klyKWpgitzsO8Raaq KYQnDX/h191+25qurEbEPDTgfakW3vcXCtMDHFPOda24KFBwX3dFF6tkxrRnJ8R5VF1iEK9y+Dh d/bhnMVVA+03YmZ7Ym017DJQ4ZR/5ZB/zgRYlwp5YSjlSPlZOTLAwpdK0waRyoaneIFYq96/WiL FeGdhg3ggrkl+2/0NSan9X30ixuBGAfQAwlhjHbET98/DLOfu0K2n+xG3nH6rKMbk3IPzInEtHJ LAQ0o04Ur4cruLAsYwQ== X-Proofpoint-GUID: tiiwV4CUe_vO6lgz_AFFrW6aBIPBzf6N X-Proofpoint-ORIG-GUID: tiiwV4CUe_vO6lgz_AFFrW6aBIPBzf6N X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-03_03,2026-11-03_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610300000 definitions=main-2611030059 On 11/3/2026 4:39 PM, Bryan O'Donoghue wrote: > On 03/11/2026 14:35, Gjorgji Rosikopulos (Consultant) wrote: >> Hi Bryan, >> >> On 11/3/2026 3:27 PM, Bryan O'Donoghue wrote: >>> On 03/11/2026 13:13, Gjorgji Rosikopulos (Consultant) wrote: >>>>>> More than that though, there is in-fact a VFE specific SOF/EOF and EPOCH >>>>>> event but these require the CSID feeding a frame into the VFE pipeline >>>>>> and the VFE moving through its own state-machine to process that frame. >>>>>> >>>>>> So they are separate signals and separate logical events representing >>>>>> different things with different timings in hardware, meaning different >>>>>> things to userspace. >>>>> Well that make sense i agree that it make sense to be part of the csid >>>>> but it should be documented somewhere, maybe proper thing to do is update >>>>> the comment in videodev2.h and update the documentation for camss driver. >>>> Just an proposal if it is decided the id to be used, it make sense to contain >>>> stream_id. Then userspace based on the stream routing can map SOF >>>> for the stream of interest. But the API for retrieving stream_id is still >>>> experimental and i am not sure if will be well accepted. >>>> >>> Ah yes right I didn't really grok your point about .id = yes I >>> agree with you, the assignment of port/line number should be dropped and >>> left @ 0 - also what is the point of stuffing the line id into the .id >>> field is not warranted. >>> >>> Agreed, that's a mistake. >> Maybe this is a good point to raise. My concern is with the multistream patches: >> the id field is also used when subscribing to an event, so it would be useful >> for userspace to identify which SOF it receives in a GMSL use case. >> >> We can leave the id as 0 for this series, but I think we should discuss how to >> handle cases where two different cameras arrive on the same PHY over different >> virtual channels—for example, one using RDI0 and the other RDI1. >> For sure what is currently missing in stream_api support is the events and >> how they can be adopted to be per stream/streams. >> >> I hope that clarifies my intent—I’m not looking to hold up the series... > > Off the top of my head VC kind of makes sense here. > > OTOH it probably makes more sense - the VC differentiator in the VFE > delivering the data but I think we end up debating if the SOF triggered > in that VFE is the VFE SOF (yes) or he CSID (no) and if the VFE SOF > really transmits any real data user-space cares about... > > Leaving this series @ 0 is compliant with existing stuff elsewhere and > lets us reason about the multi-stream stuff separately and potentially > as you say addressing a gap in what's upstream for multi-stream right now. Yes i agree lets move the discussion of multi-stream support series where maybe it belongs, i am re-basing them right now most probably i will re-base on top of this series as well. I just want to add that we need to avoid sending multiple SOF's to userspace with ID'0 when multiple RDI's are enabled in parallel. Or at least to have explanation in the commit message that is expected behavior until we agree out the multi-stream frame sync events. ~Gjorgji