From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761491AbZDHHQY (ORCPT ); Wed, 8 Apr 2009 03:16:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752605AbZDHHQI (ORCPT ); Wed, 8 Apr 2009 03:16:08 -0400 Received: from smtp-out.google.com ([216.239.33.17]:49775 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752191AbZDHHQF convert rfc822-to-8bit (ORCPT ); Wed, 8 Apr 2009 03:16:05 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: cc:content-type:content-transfer-encoding:x-system-of-record; b=fpxxb9WOF+6YtKkaHeKX3xLKXQYkQFRPvsPJSU2tKy+B2rWrFrQhNColTBeU9gxv3 xRjD+oR0to+jUN9bl2erQ== MIME-Version: 1.0 In-Reply-To: <49DC4C82.40307@cn.fujitsu.com> References: <49D5E3EE.70201@cn.fujitsu.com> <49D5E44B.3080104@cn.fujitsu.com> <5df78e1d0904072328v11e03131y5256d5c2ba9c03d@mail.gmail.com> <49DC4C82.40307@cn.fujitsu.com> Date: Wed, 8 Apr 2009 00:16:00 -0700 Message-ID: <5df78e1d0904080016y4218854ek59fd0ebf28002326@mail.gmail.com> Subject: Re: Re: [PATCH 2/2] ftrace: Code cleanup for kernel/trace/trace_events_stage_*.h From: Jiaying Zhang To: Zhaolei Cc: Steven Rostedt , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Actually my real concern is that the current event tracing interface in ftrace is still too complex. I am putting those macros together and see whether we can merge some of them. Jiaying On Wed, Apr 8, 2009 at 12:04 AM, Zhaolei wrote: > Jiaying Zhang wrote: >> Hi Steve, >> >> I am looking at ftrace code more closely. It is also not clear to me why we > Hello, Zhang > > Different people may have different taste on codeing style, but IMHO, separate > those complex definition into several files make me easy to understand. > It is only my personal code liking... > > B.R. > Zhaolei > >> want to define the trace event macros in three stage header files. I wonder >> whether it would be clearer if we merge them together. Then people don't >> need to look at three files to understand what is going on in event tracing. >> >> Jiaying >> >> On Mon, Apr 6, 2009 at 6:54 PM, Steven Rostedt > > wrote: >> >> >>     On Fri, 3 Apr 2009, Zhaolei wrote: >> >>     > Add TRACE_FORMAT's define for trace_events_stage_2.h. >>     > Although it is already defined in trace_events_stage_1.h, we >>     should make each >>     > function independence. >>     > >>     > Move TP_fast_assign's define from trace_events_stage_2.h to >>     > trace_events_stage_3.h because it is used there. >>     > >>     > Unify TRACE_EVENT's 5th argument's name to "assign" >>     > >>     > Impact: cleanup, no functionality changed >>     > >>     > Signed-off-by: Zhao Lei >     > >> >>     I see what you are doing here, but I'm a little hesitant to apply it. >>     I'm getting ready to travel, so I do not have the time to look deeper at >>     this today. I'll try to do it while I'm traveling. >> >>     Thanks, >> >>     -- Steve >>     -- >>     To unsubscribe from this list: send the line "unsubscribe >>     linux-kernel" in >>     the body of a message to majordomo@vger.kernel.org >>     >>     More majordomo info at  http://vger.kernel.org/majordomo-info.html >>     Please read the FAQ at  http://www.tux.org/lkml/ >> >> > > >