From: David Laight <David.Laight@ACULAB.COM>
To: "'Florian Fainelli'" <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Woojung Huh <Woojung.Huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net 3/4] net: dsa: microchip: Utilize strncpy() for ethtool::get_strings
Date: Fri, 2 Mar 2018 10:51:33 +0000 [thread overview]
Message-ID: <5dfe389482c54437873d4c0ae29eca8a@AcuMS.aculab.com> (raw)
In-Reply-To: <20180302002529.15226-4-f.fainelli@gmail.com>
From: Florian Fainelli
>
> Do not use memcpy() which is not safe, but instead use strncpy() which
> will make sure that the string is NUL terminated (in the Linux
> implementation) if the string is smaller than the length specified. This
> fixes KASAN out of bounds warnings while fetching port statistics.
You really ought to use a copy function that will truncate the
string if it is too long.
Just assuming the string isn't too long is asking for trouble.
You might (almost) just use strcpy().
strlcpy() will probably work best here.
David
next prev parent reply other threads:[~2018-03-02 10:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 0:25 [PATCH net 0/4] net: dsa: Use " Florian Fainelli
2018-03-02 0:25 ` [PATCH net 1/4] net: dsa: b53: " Florian Fainelli
2018-03-02 0:25 ` [PATCH net 2/4] net: dsa: loop: " Florian Fainelli
2018-03-02 0:25 ` [PATCH net 3/4] net: dsa: microchip: Utilize " Florian Fainelli
2018-03-02 10:51 ` David Laight [this message]
2018-03-02 18:24 ` Florian Fainelli
2018-03-02 0:25 ` [PATCH net 4/4] net: dsa: mv88e6xxx: " Florian Fainelli
2018-03-02 3:08 ` Andrew Lunn
2018-03-02 4:21 ` Florian Fainelli
2018-03-02 4:34 ` [PATCH net 0/4] net: dsa: Use " Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dfe389482c54437873d4c0ae29eca8a@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome