From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751223AbdE2XGb (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 May 2017 19:06:31 -0400
Received: from mail-oi0-f45.google.com ([209.85.218.45]:33537 "EHLO
        mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750994AbdE2XGa (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 May 2017 19:06:30 -0400
Subject: Re: [PATCH] scsi: lpfc: prevent potential null pointer dereference
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
References: <20170523150928.GA24570@embeddedgus>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
From: James Smart <james.smart@broadcom.com>
Message-ID: <5e0120e9-418d-c051-cd3e-03c39ff8f627@broadcom.com>
Date: Mon, 29 May 2017 16:06:28 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170523150928.GA24570@embeddedgus>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good

Signed-off-by: James Smart <james.smart@broadcom.com>

-- james


On 5/23/2017 8:09 AM, Gustavo A. R. Silva wrote:
> Null check at line 966: if (ndlp) {,  implies that ndlp might be NULL.
> Functions lpfc_nlp_set_state() and lpfc_issue_els_prli() dereference
> pointer ndlp. Include these function calls inside the IF block that
> tests pointer ndlp.
>
> Addresses-Coverity-ID: 1401856
>