From: Hans Zhang <18255117159@163.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: jingoohan1@gmail.com, manivannan.sadhasivam@linaro.org,
lpieralisi@kernel.org, kw@linux.com, robh@kernel.org,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, rockswang7@gmail.com
Subject: Re: [PATCH] PCI: dwc: Add the sysfs property to provide the LTSSM status of the PCIe link
Date: Sun, 26 Jan 2025 22:06:52 +0800 [thread overview]
Message-ID: <5e0196ec-41f8-4969-bd6d-febd5be5048a@163.com> (raw)
In-Reply-To: <20250123164944.GA1223935@bhelgaas>
On 2025/1/24 00:49, Bjorn Helgaas wrote:
> On Thu, Jan 23, 2025 at 03:13:26PM +0800, Hans Zhang wrote:
>> Add the sysfs property to provide a view of the current link's LTSSM
>> status from the root port device.
>>
>> /sys/bus/pci/devices/<dev>/ltssm_status
>
> Would need a rationale, i.e., what benefit this provides. Obviously
> this is currently only implemented for DWC-based controllers and
> probably not ever available for ACPI or other generic host bridges.
>
> Also documentation somewhere in
> Documentation/ABI/testing/sysfs-bus-pci*.
>
> LTSSM is applicable to all Downstream Ports, including both Root Ports
> and Switch Downstream Ports, but in general I doubt this information
> is available for Switches in any generic way.
>
>> +++ b/drivers/pci/pci-sysfs.c
>> @@ -1696,6 +1696,9 @@ const struct attribute_group *pci_dev_attr_groups[] = {
>> #endif
>> #ifdef CONFIG_PCIEASPM
>> &aspm_ctrl_attr_group,
>> +#endif
>> +#ifdef CONFIG_PCIE_DW_HOST
>> + &dw_ltssm_status_attr_group,
>> #endif
>
> I'm not convinced of the value of potentially dozens of device- or
> vendor-specific additions like this.
At present, someone has submitted the dwc common debugfs driver.
dwc common driver: add debugfs
https://lore.kernel.org/linux-pci/20250121111421.35437-3-shradha.t@samsung.com/
I will make a patch version based on this patch.
Best regards
Hans
next prev parent reply other threads:[~2025-01-26 14:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 7:13 Hans Zhang
2025-01-23 16:16 ` Frank Li
2025-01-24 13:12 ` Hans Zhang
2025-01-24 16:01 ` Frank Li
2025-01-26 14:30 ` Hans Zhang
2025-01-23 16:49 ` Bjorn Helgaas
2025-01-26 14:06 ` Hans Zhang [this message]
2025-01-24 13:29 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e0196ec-41f8-4969-bd6d-febd5be5048a@163.com \
--to=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=rockswang7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®