From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC8FC43A1D for ; Thu, 12 Jul 2018 10:10:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 819DA20C0C for ; Thu, 12 Jul 2018 10:10:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 819DA20C0C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726580AbeGLKTF (ORCPT ); Thu, 12 Jul 2018 06:19:05 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:16092 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbeGLKTF (ORCPT ); Thu, 12 Jul 2018 06:19:05 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1, AES128-SHA) id ; Thu, 12 Jul 2018 03:10:10 -0700 Received: from HQMAIL101.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 12 Jul 2018 03:10:13 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 12 Jul 2018 03:10:13 -0700 Received: from [10.21.132.122] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 12 Jul 2018 10:10:08 +0000 Subject: Re: [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered() To: Aapo Vienamo CC: Rob Herring , Mark Rutland , Thierry Reding , Mikko Perttunen , , , References: <1531317693-3520-1-git-send-email-avienamo@nvidia.com> <1531317693-3520-4-git-send-email-avienamo@nvidia.com> <3ced704b-2a8b-b78c-3b1e-6c2d7562edcc@nvidia.com> <2d669942-0b4d-f48b-a8ba-67794485bf5f@nvidia.com> <20180712105247.121a5d13@dhcp-10-21-25-168> From: Jon Hunter Message-ID: <5e041bd6-d152-30a9-e2f8-48552e50ccee@nvidia.com> Date: Thu, 12 Jul 2018 11:10:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180712105247.121a5d13@dhcp-10-21-25-168> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/18 08:52, Aapo Vienamo wrote: > On Wed, 11 Jul 2018 16:26:42 +0100 > Jon Hunter wrote: > >> On 11/07/18 16:23, Jon Hunter wrote: >>> >>> On 11/07/18 15:01, Aapo Vienamo wrote: >>>> Implement a function to query whether a pad is in deep power down mode. >>> Can you elaborate on why this public function is needed and who will be >>> using this? >> >> Or I should say does this need to be public? > > It's only called from the pinconf callbacks and exposing it doesn't > indeed make much sense if we intend to replace direct calls to pmc.c > with pinctrl anyway. I'll make it private on the next iteration of the > series. Yes let's make it private. Cheers Jon -- nvpublic