From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26BD3C43441 for ; Thu, 22 Nov 2018 07:10:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFA9D20831 for ; Thu, 22 Nov 2018 07:10:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="pQxBup/p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFA9D20831 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392419AbeKVRs2 (ORCPT ); Thu, 22 Nov 2018 12:48:28 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:17973 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389708AbeKVRs1 (ORCPT ); Thu, 22 Nov 2018 12:48:27 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 21 Nov 2018 23:10:30 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 21 Nov 2018 23:10:21 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 21 Nov 2018 23:10:21 -0800 Received: from [10.19.225.182] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 22 Nov 2018 07:10:19 +0000 Subject: Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails To: Daniel Lezcano , , CC: , , References: <1542103567-5521-1-git-send-email-wni@nvidia.com> <1542103567-5521-2-git-send-email-wni@nvidia.com> <70f08208-d04c-c9a4-07e6-d377c33a9386@nvidia.com> From: Wei Ni Message-ID: <5e09bc13-7880-40f2-3f90-01d2cc3510ba@nvidia.com> Date: Thu, 22 Nov 2018 15:10:17 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1542870630; bh=Du9MJS4qQXf4v0qEAzhaup2aQTsbzBn44tw8rBbCihw=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=pQxBup/psB25IWKG/FutYAANGDjLl7r5gVIN7a4dTk4ek/ZDq1tEZgnXeoSOTslOG o0jV0Pb26s55HoMcXqzkMnG5A7KtGA9QO57736+lCFWG3GyDoVI1hNOk45aJg1975V yd9aOm/JwprNWKni/+W8TX3Nb2g9NoANXRrj6QjOo7yz8kevROSgIUju2booc2MfU9 NJfMKm32uYuql6adAYflgmuHe3iXc9DSKTTVwStWoeolMitjd4njgz7L/8QehHJM3x LJF3z5Kc2tvsKnHmY2+bhirmu3y5ZTw6RtpnsN+hyaNfLKJlPmFOJkwoeYqSsPKlp8 USj3h3pCMFmAQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/11/2018 8:51 PM, Daniel Lezcano wrote: > On 21/11/2018 11:23, Wei Ni wrote: >> >> >> On 21/11/2018 4:55 PM, Daniel Lezcano wrote: >>> On 13/11/2018 11:06, Wei Ni wrote: >>>> Don't bail when a sensor fails to register with the >>>> thermal zone and allow other sensors to register. >>>> This allows other sensors to register with thermal >>>> framework even if one sensor fails registration. >>> >>> I'm not sure if ignoring the error is really safe. Can you describe the >>> real situation you want to overcome ? How do you differentiate critical >>> sensors ? >> >> The driver will always try to register 4 thermal zones, including cpu, >> gpu, mem and pll, but if the dts file doesn't set the corresponding >> sensors, then the register will be failed. >> Normally, the dts file will set all 4 sensors, but there may have some >> platform doesn't support them all. So we post this patch. > > Ignoring errors is not the way to go to support different platforms. Fix > the DT. The issue isn't in DT file. The Tegra soc thermal include 4 sensors: cpu, gpu, mem, pll. But in some platforms, for example, we may only need to support 2 sensors, such as cpu and gpu, so we only configure these two senors in DT file. But the driver will always try to register 4 sensors, cpu/gpu/mem/pll, so mem and pll will be registered failed. So in this case we need to ignoring the failure, and continue to enable the driver. > > >> BTW, what do you mean "critical sensors"? We will set critical trip temp >> for all sensors. > > I meant sensor for thermal zone getting really high temperature. We doesn't have the critical sensors. We set the critical trip temp for all registered sensors. And these trip temp is set to the Tegra hardware. So it mean if the temperature reached the critical trip point, then the system will be shutdown directly. > > >>>> Signed-off-by: Wei Ni >>>> --- >>>> drivers/thermal/tegra/soctherm.c | 8 +++++--- >>>> 1 file changed, 5 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c >>>> index ed28110a3535..a824d2e63af3 100644 >>>> --- a/drivers/thermal/tegra/soctherm.c >>>> +++ b/drivers/thermal/tegra/soctherm.c >>>> @@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev) >>>> &tegra_of_thermal_ops); >>>> if (IS_ERR(z)) { >>>> err = PTR_ERR(z); >>>> - dev_err(&pdev->dev, "failed to register sensor: %d\n", >>>> - err); >>>> - goto disable_clocks; >>>> + dev_warn(&pdev->dev, "failed to register sensor %s: %d\n", >>>> + soc->ttgs[i]->name, err); >>>> + continue; >>>> } >>>> >>>> zone->tz = z; >>>> @@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev) >>>> struct thermal_zone_device *tz; >>>> >>>> tz = tegra->thermctl_tzs[soc->ttgs[i]->id]; >>>> + if (!tz) >>>> + continue; >>>> err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz); >>>> if (err) { >>>> dev_err(&pdev->dev, >>>> >>> >>> > >