mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
To: Tomas Winkler <tomas.winkler@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: <intel-gfx@lists.freedesktop.org>,
	Alexander Usyskin <alexander.usyskin@intel.com>,
	<linux-kernel@vger.kernel.org>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Vitaly Lubart <vitaly.lubart@intel.com>
Subject: Re: [Intel-gfx] [PATCH v8 02/16] mei: add kdoc for struct mei_aux_device
Date: Wed, 7 Sep 2022 11:58:07 -0700	[thread overview]
Message-ID: <5e127663-c7e9-a491-3d3b-b057c50eb25a@intel.com> (raw)
In-Reply-To: <20220907155813.1427526-3-tomas.winkler@intel.com>



On 9/7/2022 8:57 AM, Tomas Winkler wrote:
> struct mei_aux_device is an interface structure
> requires proper documenation.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

This is unchanged from the previously reviewed rev, so this still applies:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   include/linux/mei_aux.h | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/mei_aux.h b/include/linux/mei_aux.h
> index 587f25128848..a0cb587006d5 100644
> --- a/include/linux/mei_aux.h
> +++ b/include/linux/mei_aux.h
> @@ -7,6 +7,12 @@
>   
>   #include <linux/auxiliary_bus.h>
>   
> +/**
> + * struct mei_aux_device - mei auxiliary device
> + * @aux_dev: - auxiliary device object
> + * @irq: interrupt driving the mei auxiliary device
> + * @bar: mmio resource bar reserved to mei auxiliary device
> + */
>   struct mei_aux_device {
>   	struct auxiliary_device aux_dev;
>   	int irq;


  reply	other threads:[~2022-09-07 18:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 15:57 [PATCH v8 00/16] GSC support for XeHP SDV and DG2 Tomas Winkler
2022-09-07 15:57 ` [PATCH v8 01/16] drm/i915/gsc: skip irq initialization if using polling Tomas Winkler
2022-09-07 15:57 ` [PATCH v8 02/16] mei: add kdoc for struct mei_aux_device Tomas Winkler
2022-09-07 18:58   ` Ceraolo Spurio, Daniele [this message]
2022-09-07 15:58 ` [PATCH v8 03/16] mei: add slow_firmware flag to the mei auxiliary device Tomas Winkler
2022-09-07 15:58 ` [PATCH v8 04/16] drm/i915/gsc: add slow_firmware flag to the gsc device definition Tomas Winkler
2022-09-07 15:58 ` [PATCH v8 05/16] drm/i915/gsc: add GSC XeHP SDV platform definition Tomas Winkler
2022-09-07 19:02   ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [PATCH v8 06/16] mei: gsc: use polling instead of interrupts Tomas Winkler
2022-09-07 19:04   ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [PATCH v8 07/16] mei: gsc: wait for reset thread on stop Tomas Winkler
2022-09-07 19:06   ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [PATCH v8 08/16] mei: extend timeouts on slow devices Tomas Winkler
2022-09-07 19:12   ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [PATCH v8 09/16] mei: bus: export common mkhi definitions into a separate header Tomas Winkler
2022-09-07 19:19   ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-09-07 19:48     ` Winkler, Tomas
2022-09-07 15:58 ` [PATCH v8 10/16] mei: mkhi: add memory ready command Tomas Winkler
2022-09-07 15:58 ` [PATCH v8 11/16] mei: gsc: setup gsc extended operational memory Tomas Winkler
2022-09-07 19:23   ` Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [PATCH v8 12/16] mei: gsc: add transition to PXP mode in resume flow Tomas Winkler
2022-09-07 19:23   ` Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [PATCH v8 13/16] mei: drop ready bits check after start Tomas Winkler
2022-09-07 21:23   ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [PATCH v8 14/16] mei: debugfs: add pxp mode to devstate in debugfs Tomas Winkler
2022-09-07 19:26   ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-09-07 15:58 ` [PATCH v8 15/16] drm/i915/gsc: allocate extended operational memory in LMEM Tomas Winkler
2022-09-07 15:58 ` [PATCH v8 16/16] HAX: drm/i915: force INTEL_MEI_GSC on for CI Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e127663-c7e9-a491-3d3b-b057c50eb25a@intel.com \
    --to=daniele.ceraolospurio@intel.com \
    --cc=airlied@linux.ie \
    --cc=alexander.usyskin@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tomas.winkler@intel.com \
    --cc=vitaly.lubart@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®