From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Herring <robh@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mark Brown <broonie@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Russell King <linux@armlinux.org.uk>
Subject: Re: sysfs deferred_probe attribute
Date: Fri, 13 Jan 2017 08:42:39 +0100 [thread overview]
Message-ID: <5e175959-083e-84b6-729c-96ab65073416@collabora.com> (raw)
In-Reply-To: <1484245571.10206.28.camel@codethink.co.uk>
On 01/12/2017 07:26 PM, Ben Hutchings wrote:
> On Thu, 2017-01-12 at 18:41 +0100, Greg Kroah-Hartman wrote:
>> On Thu, Jan 12, 2017 at 11:27:01AM -0600, Rob Herring wrote:
>>> I just noticed that we have a new device attribute 'deferred_probe'
>>> added in 4.10 with this commit:
>>>
>>> commit 6751667a29d6fd64afb9ce30567ad616b68ed789
>>> Author: Ben Hutchings <ben.hutchings@codethink.co.uk>
>>> Date: Tue Aug 16 14:34:18 2016 +0100
>>>
>>> driver core: Add deferred_probe attribute to devices in sysfs
>>>
>>> It is sometimes useful to know that a device is on the deferred probe
>>> list rather than, say, not having a driver available. Expose this
>>> information to user-space.
>>>
>>> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>
>>>
>>> It seems like a bad idea to add an ABI for an internal kernel feature.
>>> When/if we replace deferred probe with something better based on
>>> functional dependencies are we going to keep this attr around? Or
>>> remove it and assume no userspace uses it?
>
> It should be removed then (and replaced with some kind of representation
> of dependencies).
>
>>> Perhaps it should be hidden
>>> behind CONFIG_DEBUG or just make a debugfs file that lists the
>>> deferred list. Then you wouldn't have to hunt for what got deferred.
>>
>> Ah, debugfs would be nice, I'd much prefer that. I don't know how Ben
>> is using this, but I think that would make more sense to me.
>
> I'm not using it any programmatic way, and don't intend to. debugfs
> would be OK, but attaching it to devices was easy to do and seemed to
> make sense.
Russell King started work on printing those devices in the deferred
queue at late_initcall, not sure why it didn't land.
But note that without proper dependency information, you cannot know for
sure if a device deferred its probe just because a dependency doesn't
have a matching driver.
Regards,
Tomeu
next prev parent reply other threads:[~2017-01-13 7:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 17:27 Rob Herring
2017-01-12 17:41 ` Greg Kroah-Hartman
2017-01-12 18:26 ` Ben Hutchings
2017-01-13 7:42 ` Tomeu Vizoso [this message]
2017-01-14 13:15 ` Greg Kroah-Hartman
2017-01-12 19:46 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e175959-083e-84b6-729c-96ab65073416@collabora.com \
--to=tomeu.vizoso@collabora.com \
--cc=ben.hutchings@codethink.co.uk \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®