mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Cooks <andrew.cooks@opengear.com>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nehal Shah <Nehal-bakulchandra.Shah@amd.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Ken Xue <Ken.Xue@amd.com>,
	Tobias Diedrich <ranma+kernel@tdiedrich.de>,
	Sudheesh Mavila <sudheesh.mavila@amd.com>,
	platypus-sw <platypus-sw@opengear.com>,
	alan@mizrahi.com.ve
Subject: Re: pinctrl-amd: What hardware does it apply to?
Date: Fri, 22 Dec 2017 11:17:25 +1000	[thread overview]
Message-ID: <5e17a846-b2c6-c078-3d90-bbf19aea2a8a@opengear.com> (raw)
In-Reply-To: <2142688.oNeEzK9Weu@debian64>

Hi Christian

On 21/12/17 23:02, Christian Lamparter wrote:
> On Thursday, December 21, 2017 8:25:03 AM CET Andrew Cooks wrote:
>> I'm working on gpio for an AMD Family 16h Model 30h system[1]. 
>> The SoC is the same as the GX412-TC used in the PC Engines APU2. 
>>
>> There is an out-of-tree gpio driver (gpio-amd) for this SoC in the
>> meta-amd yocto layer[2]. Another driver (gpio-sb8xx) was submitted
>> for upstream inclusion, but was knocked back with the suggestion
>> that pinctrl is the way forward[3].
>>
>> I would much prefer to use a mainline driver for the system I'm 
>> working on, so I'm looking at the pinctrl-amd driver to see
>> whether it applies to our SoC, or whether it could be extended,
>> or used as starting point for a new driver.
>>
>> The out-of-tree drivers apply to the GX412-TC SoC and uses PCI
>> for probing:
> 
> Just a FYI: due to these difficulties with getting a gpio driver
> upstream, Alan Mizrahi upstreamed an in-kernel led-apu.c driver [0]
> that sort of bypasses the whole pinctrl vs gpio issue.

Thanks, I saw that and was somewhat surprised to see it accepted.

> 
> If you are just after LEDs or gpio-keys you probably can go the same
> route?

I could. The gpio-amd driver in the meta-amd yocto layer, which is already functional, is another workable alternative. However, I would prefer the more elegant mainline pinctrl solution, if it's attainable.

Thanks

Andrew

  reply	other threads:[~2017-12-22  1:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-20 22:25 Andrew Cooks
2017-12-21 10:11 ` Linus Walleij
2017-12-21 12:12   ` Mika Westerberg
2017-12-22  0:37     ` Andrew Cooks
2017-12-22  6:05       ` Mika Westerberg
2017-12-22  0:44   ` Andrew Cooks
     [not found]   ` <CAOdcoTnpiWkPu4_eOJ6bzUE58PqRHw-y5yHY2T8M3Ymp_2v0MQ@mail.gmail.com>
2017-12-22  1:05     ` Andrew Cooks
2017-12-21 13:02 ` Christian Lamparter
2017-12-22  1:17   ` Andrew Cooks [this message]
2017-12-22  7:48     ` Linus Walleij
2017-12-22 17:49       ` Christian Lamparter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e17a846-b2c6-c078-3d90-bbf19aea2a8a@opengear.com \
    --to=andrew.cooks@opengear.com \
    --cc=Ken.Xue@amd.com \
    --cc=Nehal-bakulchandra.Shah@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=alan@mizrahi.com.ve \
    --cc=chunkeey@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platypus-sw@opengear.com \
    --cc=ranma+kernel@tdiedrich.de \
    --cc=sudheesh.mavila@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®