From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78D2E192B95 for ; Fri, 8 Nov 2024 13:33:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731072791; cv=none; b=XZnqsjMG6+6YQQF2i2reJ3TLA2KwHI2hvhmEsIElP85r6dnxcm2qoCoCnpS46ePQohlw0vbRrez/w+Zs49NO1Fz+G5qdXWcuGr5Y86xiOv9L6GnOVyeKZxZuxJcVR/QvYXOHI6gwsWJGbJ2HC3gEXzGsQleX5l+jj9WyQhU4TIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731072791; c=relaxed/simple; bh=zNr0dprauh1zxK+QJRJVWVYyAAJm59+k7hYGIO4+otc=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=SAj2bh7gZQCBx2ytHy3ayr1yPiG81CCHIiYrOhFYQCcQ2z2WzhEZ/HRlp+uEsX+HvFuyirwwH1DJcqxztQb+sgu2WKWc9Cg9qdeGNcaEgCet4yzdOkhdIMIa1fz1EfnoepI46LfFVQIJyGQObeA+5ozCHVf1TYaMjH+45pfrCF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=aBkYF4/p; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=YlG+A/p4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=aBkYF4/p; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=YlG+A/p4; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="aBkYF4/p"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="YlG+A/p4"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="aBkYF4/p"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="YlG+A/p4" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3E29A21B7B; Fri, 8 Nov 2024 13:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731072787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oJCSGf9W5QDQLEgF20NrP1ryxSrkWQmVfq993xA7CGU=; b=aBkYF4/ppr3ZtbHPov1GPrxQInhpY60ANzjiLTvleOuYYv1/QXUHrXRo00KIxUEMOzyRxy 7mlJkQB8eOUxCet+hJq0i56oWEg1FJHLZG6PLwqfOp+gb9APExw/S5qDeMivJoThSX/Q1Y xfnOYWBTlfbDubyUtPRDdtRsowgWdi8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731072787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oJCSGf9W5QDQLEgF20NrP1ryxSrkWQmVfq993xA7CGU=; b=YlG+A/p4OU4jfNUvhO/uScxfqUoDzmva9PrXpGeLtd1lwXJqKbzsLqofoqd9KdBc0X3oDd DTSoEo2V7BH0/yCg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="aBkYF4/p"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="YlG+A/p4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731072787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oJCSGf9W5QDQLEgF20NrP1ryxSrkWQmVfq993xA7CGU=; b=aBkYF4/ppr3ZtbHPov1GPrxQInhpY60ANzjiLTvleOuYYv1/QXUHrXRo00KIxUEMOzyRxy 7mlJkQB8eOUxCet+hJq0i56oWEg1FJHLZG6PLwqfOp+gb9APExw/S5qDeMivJoThSX/Q1Y xfnOYWBTlfbDubyUtPRDdtRsowgWdi8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731072787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oJCSGf9W5QDQLEgF20NrP1ryxSrkWQmVfq993xA7CGU=; b=YlG+A/p4OU4jfNUvhO/uScxfqUoDzmva9PrXpGeLtd1lwXJqKbzsLqofoqd9KdBc0X3oDd DTSoEo2V7BH0/yCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D856E1394A; Fri, 8 Nov 2024 13:33:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3HMYMxITLmeXcgAAD6G6ig (envelope-from ); Fri, 08 Nov 2024 13:33:06 +0000 Message-ID: <5e19d9d4-7533-4a59-a665-cfc4a8195293@suse.de> Date: Fri, 8 Nov 2024 14:33:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/7] drm/log: Do not draw if drm_master is taken To: Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , John Ogness , Javier Martinez Canillas , "Guilherme G . Piccoli" , bluescreen_avenger@verizon.net, Caleb Connolly , Petr Mladek , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20241108082025.1004653-1-jfalempe@redhat.com> <20241108082025.1004653-5-jfalempe@redhat.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20241108082025.1004653-5-jfalempe@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3E29A21B7B X-Spam-Level: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_TWELVE(0.00)[13]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_TO(0.00)[redhat.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch,linutronix.de,igalia.com,verizon.net,linaro.org,suse.com,lists.freedesktop.org,vger.kernel.org]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com,verizon.net]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -4.51 X-Spam-Flag: NO Hi Am 08.11.24 um 09:10 schrieb Jocelyn Falempe: > When userspace takes drm_master, the drm_client buffer is no more > visible, so drm_log shouldn't waste CPU cycle to draw on it. > > Signed-off-by: Jocelyn Falempe > --- > drivers/gpu/drm/drm_log.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_log.c b/drivers/gpu/drm/drm_log.c > index 376ee173d99d9..226e206e8b6a3 100644 > --- a/drivers/gpu/drm/drm_log.c > +++ b/drivers/gpu/drm/drm_log.c > @@ -18,6 +18,7 @@ > #include > > #include "drm_draw.h" > +#include "drm_internal.h" > #include "drm_log.h" > > MODULE_AUTHOR("Jocelyn Falempe"); > @@ -308,8 +309,13 @@ static void drm_log_write_thread(struct console *con, struct nbcon_write_context > if (!dlog->probed) > drm_log_init_client(dlog); > > - for (i = 0; i < dlog->n_scanout; i++) > - drm_log_draw_kmsg_record(&dlog->scanout[i], wctxt->outbuf, wctxt->len); > + /* Check that we are still the master before drawing */ > + if (drm_master_internal_acquire(dlog->client.dev)) { Just a note: it would be better to track this state in the client code and handle these locks automatically. But it's ok for now. It would require an overhaul of the fbdev helpers as well. > + drm_master_internal_release(dlog->client.dev); Don't you have to release after drawing? Best regards Thomas > + > + for (i = 0; i < dlog->n_scanout; i++) > + drm_log_draw_kmsg_record(&dlog->scanout[i], wctxt->outbuf, wctxt->len); > + } > } > > static void drm_log_lock(struct console *con, unsigned long *flags) -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)