From: Michal Simek <michal.simek@xilinx.com>
To: "Joni Lepistö" <joni.m.lepisto@gmail.com>,
robh+dt@kernel.org, mark.rutland@arm.com
Cc: Michal Simek <michal.simek@xilinx.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: zynq: Add support for Z-turn Lite board
Date: Thu, 27 Feb 2020 08:44:55 +0100 [thread overview]
Message-ID: <5e1b9f81-af5c-3091-5d62-ea2d938bae83@xilinx.com> (raw)
In-Reply-To: <20200226090337.16065-1-joni.m.lepisto@gmail.com>
On 26. 02. 20 10:03, Joni Lepistö wrote:
> Add a dts for MYIR Z-turn Lite and respective target in Makefile
> based on the existing Z-turn dts which is compatible except for
> memory size.
Just a side note - I can't see any reason to duplicate the whole dts
file if it is just the same - you can simply #include "zynq-zturn.dts"
and then change/rewrite things.
Second thing is that myir,zynq-zturn is not even listed in any yaml
binding file that's why dtbs_check will fail.
I expect you use standard boot flow via u-boot which can detect and
update memory size automatically for you. It means for kernel you can
even place there <0 0> and u-boot will fill it.
Just a summary I don't think it is worth to add support to this board in
Linux. And in U-Boot you should enable memory autodetection and you will
get support for this lite board for free.
Thanks,
Michal
prev parent reply other threads:[~2020-02-27 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 9:03 Joni Lepistö
2020-02-27 7:44 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e1b9f81-af5c-3091-5d62-ea2d938bae83@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=joni.m.lepisto@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®