From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EF13345CA3 for ; Wed, 10 Jun 2026 18:08:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781114931; cv=none; b=lnDsZj/GpJUbK79xrUei9dvcZIN+Y3U1JGMcxM9Hd5uYzupUK5Wymr0pe2mnHIAFylbsBJZHaHrhv5bmg4MYA9qAb6t/+t4YU69Js9bmD5Php8WjOGrgszFqIfdXdhSd4P6oW9tVno/AAdZc0/OaVHkfr3aH0ZkxiVFecIpW3p0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781114931; c=relaxed/simple; bh=TzdZ74lGIi/K4VLWAJkI9NGpFSw7kZd2nzjV7/0g0YY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=utcXxqcPWj7ESh7Z58EyMJjyVC9blS2tCvH82iGVJp/8w5/cOr/f7lD+wFz+4WL0A+Zee3f80SML279oDEWBph9ZASMVURggakdFYTALZJ/cR+rpGF3yH6YvBCeRtWLsocAFdYK9hYj7Klu6KSToE8vXRgUokZCJDsvBxB4XwRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QEg4XyDm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PMqrTb7B; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QEg4XyDm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PMqrTb7B" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65AFwplf2042073 for ; Wed, 10 Jun 2026 18:08:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pU7x77a+8qRNZg86QYZx6zWKXSydK7ZBnV/K7oIcSUE=; b=QEg4XyDmpI4ju+vP MPoo7HCH6aSWRQbIvwupXeFI+Iy3YUWTZ3MelkBn0z9JB7DI3ZMkZ4I9Uapfz3FU xei8PaUkf86825RNTqFnscSAFRSlhM2dCHF6ClDQPauMTT1c4RFRORBXabIGLr0D zPpLU9wVOKzsBiGwjHt2r3SbUEqjVZmqH8PRjA+VYNrmVswH5xPUF7uPb1+u4fNZ xtywKTJXj4NkYo5958lN3J1/hTKDa/3MOFD4G45MpXioqf/Ss8g1h5E6s2rgOwlu 19VFGVRS9axNe8G9MJMTj427yri1afNKHRLsk+nBD5yOS7es/sF7+LM39OXklKsq FyDD9Q== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epukevkka-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 18:08:48 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-6cfc66167c4so2766441137.1 for ; Wed, 10 Jun 2026 11:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781114928; x=1781719728; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pU7x77a+8qRNZg86QYZx6zWKXSydK7ZBnV/K7oIcSUE=; b=PMqrTb7BISBpbsBNL4aNgdGrNsGMH5yQ9p6Xtchzysfje08es50y9HBStPvvHLu7Kz zNGTPCD4PiXhtl1lhjunEZ42HH3jOZ8Qy5TMEJxEecWiwGi/urgPJ+TRWW3sJNIT5pCM VrUc/ldXOoSByexnHqmA5t8RuT+8mmBBTKEZqgMjFd3jCRFi4Un2wmeWLCsyCDeC024M FIFHBzo+isUwbRJqYAzUC6GZPXrYFCSq+z6LbpR5AKejK9f0y6ebypamCTudJ7RYvHPk NdOAaLCVG5QbT7M7m67uUZ2Gph+50RFfd1Q9SqGwKxtgZLdqG/yNe2A4o2CjrfUd5Pau NSSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781114928; x=1781719728; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pU7x77a+8qRNZg86QYZx6zWKXSydK7ZBnV/K7oIcSUE=; b=pfX871BUsXG5FBIx1vIAzQKyoAgSPwioZ28uDFBtcKGSxG1yUm0Yqm5y6v3N0H+qts p26ivEsnIt1sCsWt3F+FvS0oeLCRWAvQ/KefyJno/7BcoKpMKug+ObES0DAER2zL3Ol7 qtCayMy5AH7bxknevX/V2fkBWa1wnfxC0/QV+U9CabSh3HMh9ugELAAQR5ZIto0mXOJK BOUJojawa7Kwyc136aAA2B9TBZWM76kZXuXoDLiLLI+a4oN/mM/snpx8kR5bCmdhAT0Q nGGGqL9gy+skLvSAct2Xp2+RT3p3DdPC2DalWqTMawJ7HSjk4MBAJrTcK0SGCp7L4zhK Mdtg== X-Forwarded-Encrypted: i=1; AFNElJ9Rbc7OV+EkBL3hiCj9UfaEjM5UVBr3KEHoCYmxHMFVeId/CZBu7sHrb8Wb7ja2NXQFvOdf0G+W1DsgH2w=@vger.kernel.org X-Gm-Message-State: AOJu0YzRxBVcRmSwhR6VVECGwjkeyaNwU72cIubrCHo9+CagV3q/DcR9 GLpA1CgTpg8/XNkYPQ4Y8Zp2pQVcIpw0Yig5skpj9KKo0QuliAi//4pW61eeqMTNapAJmVO1IsD OgRo5jzAf4bK1wPPxgacRJ106VQPIsm/mhAKzDAuK+yASdMb/LeEBOzz6qBn2E9xq3is= X-Gm-Gg: Acq92OFMyZ779fTm8g2SuUy0sVK54mo4uRlgmdd/KqAkU6L4GPS6UfNv2NJj9mXkrO1 7U4g+UEFJtpLUiBYmQRHhaEKo3QSjt0IaHAG9sfAQJJWydL+dWObKErl3iddXawD0HRb1FIsWEQ dvgb6J4dO+vnOjhQoDRYrw2OQHUKp8oozj0r/BWE7h0HY3kib72vQIYvaZBPWWqrVFofIifa9t3 Pmr458wtjJxdskLLYnUoQiceHjCkOGQaupE8cIM9316YM0R0N4jovIpgK1SQS9NwXWgcGXK1Rt6 nI4z8Syv81QivH8+35Kmb7uzbtlil1g95nv7i1NX3GWaIRjDmTdN9/HrJJHP3tE107DAhoDSaBC 4p3x2RmFFT7k6fKwDdXBQ/BgjLRNrSwoDQnqLEbIBm7IQZb4B4tc1Ug0zVX2HkMvbZxA= X-Received: by 2002:a05:6102:5e82:b0:636:46ee:2f0b with SMTP id ada2fe7eead31-71d1ffa545bmr70887137.12.1781114927792; Wed, 10 Jun 2026 11:08:47 -0700 (PDT) X-Received: by 2002:a05:6102:5e82:b0:636:46ee:2f0b with SMTP id ada2fe7eead31-71d1ffa545bmr70859137.12.1781114927376; Wed, 10 Jun 2026 11:08:47 -0700 (PDT) Received: from [192.168.0.172] ([49.205.248.156]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf055303fc6sm1229897066b.42.2026.06.10.11.08.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 11:08:46 -0700 (PDT) Message-ID: <5e1be8c3-3e41-4a4f-bb70-3bc6bad7f26d@oss.qualcomm.com> Date: Wed, 10 Jun 2026 23:38:37 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: media: qcom,qcm2290-venus: document shikra Iris compatible To: Krzysztof Kozlowski Cc: Bryan O'Donoghue , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jorge Ramirez-Ortiz , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260609-shikra_vpu-v1-0-3a32bb38b080@oss.qualcomm.com> <20260609-shikra_vpu-v1-1-3a32bb38b080@oss.qualcomm.com> <20260610-flexible-badger-of-dignity-bbaea0@quoll> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260610-flexible-badger-of-dignity-bbaea0@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDE3MCBTYWx0ZWRfXzpiLWYIP0vUh tSZIJz3ieSFYvBhTMp58Xp6V7Rol5hDjwyZb6DcqAco/i5XLEdaI93ee9+m32O+eysLMrGs5Go9 EJb6UmDT8bLV4yoW5SQuFn+9nMTCkRp9IbpdQ6oU9WJGWgbaWp4dN36PvjvQfSF0t34xwqqoGJD HtgPEkVUm6qu+Q7p6BeoV3nhG74vEF8eBfz0jRODa95Iqyr961gRcmDCz/1yOVcdf4dB0BddCQW fufWcOGSi70ev0yq6aWP16i8QPj1DrOIU9LmSRQVOxF077RWVq0NuE4vKycLGWSVVyRI1Tx6exw XqpVNW4YCV4U14lVwfcbHTcBONVVu6l0lGN3djv5LShw7jg182fvR+jvM0lwzco/IlOVZf755b2 8YDqK2Aay1245joLgkumbbqGZsgpnwok8+YyIow7ix36IPPjjzc7xCGd77gUgEYxGgSjwIV9bem 3x5TUYQgikIgMCwoDmQ== X-Proofpoint-ORIG-GUID: MTrtzMw0f6UiTZaK5pVhfWtL9iT_kFKr X-Proofpoint-GUID: MTrtzMw0f6UiTZaK5pVhfWtL9iT_kFKr X-Authority-Analysis: v=2.4 cv=DNG/JSNb c=1 sm=1 tr=0 ts=6a29a830 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=tTcoO59C9ckK9alVnXkiOA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=YZymR2wwIn4Cfu7efxMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 spamscore=0 impostorscore=0 priorityscore=1501 adultscore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100170 On 6/10/2026 2:47 PM, Krzysztof Kozlowski wrote: > On Tue, Jun 09, 2026 at 09:45:40PM +0530, Vikash Garodia wrote: >> Document the iris video accelerator used on shikra platforms by adding >> the qcom,shikra-iris compatible. >> >> Although QCM2290 and shikra share the same video hardware and overall >> integration, their SMMU programming differs. QCM2290 exposes separate >> stream IDs for the video hardware and the Xtensa path, requiring two >> explicit IOMMU entries, whereas shikra uses a masked SMR to collapse >> equivalent stream IDs into a single mapping. Due to QCM2290’s SID layout >> and Xtensa isolation requirements, such SMR masking is not applicable on >> QCM2290 platforms. >> Since shikra uses the same video hardware as QCM2290 and shares the same >> programming model and capabilities, it is added as a fallback compatible >> to qcom,qcm2290-venus, with conditional handling to allow either one or >> two IOMMU entries. >> >> Signed-off-by: Vikash Garodia >> --- >> .../bindings/media/qcom,qcm2290-venus.yaml | 20 ++++++++++++++++---- >> 1 file changed, 16 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml >> index 5977e7d0a71b4fb5681f1c2094439c251366f01f..895533b9756690d075fd7729e3f805c8e72ff0df 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml >> @@ -15,12 +15,27 @@ description: >> >> allOf: >> - $ref: qcom,venus-common.yaml# >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: qcom,shikra-iris >> + then: >> + properties: >> + iommus: >> + maxItems: 1 >> + else: >> + properties: >> + iommus: >> + maxItems: 2 > > allOf goes to the end, after required: block. See example-schema. > Ack > >> >> properties: >> compatible: >> oneOf: >> - items: >> - - const: qcom,sm6115-venus >> + - enum: >> + - qcom,sm6115-venus >> + - qcom,shikra-iris > > Messed order. > Ack >> - const: qcom,qcm2290-venus >> - const: qcom,qcm2290-venus > > Best regards, > Krzysztof >