From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A010A37E2E9 for ; Mon, 27 Jul 2026 05:11:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785129097; cv=none; b=tHW8/IeYKsrYOqaCaj62Ahcbs3musxUVSRgaeTlDyFTmCgQyRL43o6C4MM9QyGqMZqXufRd0c4mSmTLtat22n5F2gVrGCIorNPB7r3Ltt+Xm7h/Dk0QJYObR10NxPi0Uv9Kf/5dv9kITMnaStiw7HGfIrLbJ91NVVoRsGXrp7io= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785129097; c=relaxed/simple; bh=kZBidVZjmJGoApIJ3GO2Kz8d2/QFXB37Ii82Hw+ccag=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q7dQNZHs1ksjAEgJ9s+sc2mFIl4PJpvPRVWDgZJWHodX4i+2ajw3/UwdTs81duHK9Loaj7Ax7QEc8syASUUJW3o9Da2iezXcqtVg8Kf/UHjkxKSPEQxWIvk5vtjxypOwODniL88s0ilhmlU8glCi4Y1Q2+7Uage6VsMeCofViF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EAyH5Qza; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R9O8noX4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EAyH5Qza"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R9O8noX4" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66R1g29e2257280 for ; Mon, 27 Jul 2026 05:11:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sUXCyPbow4yUif1Oge6A2zcHD6lU8y6rMl8bk7t7NqE=; b=EAyH5QzaGI2fH9Ut Ph2NuUUAOuniSdcOx9XDSjaHG9CZygSCXWhA6LKC7tQwW0TRY0J6whesX4q3PIVB VQ/kNctBjfYv3SRoBvbFm/XQThkXLQtIZo+UwcFz5uHnea2QEr4jA0l6D+IZ/ZqK G/f2qhmzEtoqxK1PbadmjJvqRxLKashN3muMRxuP7RFnsJjr1YcR9Uq3D4z/j9Ey IrijZHbgYV16WWN5eu2eVhaZd+LMkZip9831/mMTwElV+ARDskvCwZwPAuyvrXGM 458sKzHh7LDD9gZB0A+nMBbse3roDSdf6K4Izl0AcuxUXJwac3n406dosso1Kz8H BebRqw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fmmfgvnvt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Jul 2026 05:11:34 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb7049fa552so1459601a12.2 for ; Sun, 26 Jul 2026 22:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785129093; x=1785733893; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=sUXCyPbow4yUif1Oge6A2zcHD6lU8y6rMl8bk7t7NqE=; b=R9O8noX4RQZdWzulXw/qCeywij8U8XHvKgzJ2seVkQPzzHCV6ompPqn8Q6agr3euZe RFITvrANuhHcUNsrL0XkANqTNe5OI7R6YqlD9I0fRBzBgo4PaQ8olGICGUc+7u2LEGMQ YVahpmL1DjI0TZMf1t2X8/3VxJaQ7YGEGYJQ1jMMbH+YVyCnruFmGrrQIw4dBm7Ci0B+ i+ApcK2DQKzXGN9Uwf0A0yPvPPqGsvu1dUMNpihrJAew9Er1YGmlL1NOVzqgeeCGBEo1 1eaiNrNFM6y2UUQ9rivVGeh0yJTPTszYRcuBXRq+XBu2wOTi5dQXX7qKhlqZLD8yq3Lv RPCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785129093; x=1785733893; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sUXCyPbow4yUif1Oge6A2zcHD6lU8y6rMl8bk7t7NqE=; b=js9lC7r4nxEvjFXkb3K82+WD69SZLvjB5RgTBHflY2kXTit6l/e9/ffRgbtZqnpBLW Dve+iKmpZyURenEIE5zla6vpIeibv6C/eyT2YB7QtwtxOEwBJKNdxDZkFym9t3bpVwqA XDBq3A5EL5lTo3U239V2RaDYq2dbvNAwnbGLww68reWOr8Gi0cMFxUra7dIQCCjevQzQ NIndKPLWAWUwOAE8DQuyJqWZ86XloubKYlnMN0vO+/pA1waMfOeuRHXWh8msUT52bUs7 /dCTlaz21K7GHvd/oWbCOCAt2KRjejWHdg1HJ8RqvS6M02CFFlEvj+TtDH2vBk6SRWVv niCg== X-Forwarded-Encrypted: i=1; AHgh+RpWJ0L/GOhV+xlj1+r4HyzBGuZrsGD7au15LoEvEoos7ChNqfk00zu55nif2F0djWOd2PsOnUUtMBSUMCI=@vger.kernel.org X-Gm-Message-State: AOJu0YwJmb1skgT9TJihfVVT/Ay94z1cF5Wo3ZpjVVGU0lSmEjjn13TX ZezE8w6O4qXrmiP5lVmIS6QE5A9TpLhoZ73qsokjlhJsmXJQvauFZRrPeOLNo2DXczc4BsaJL9O bMfPUdTny7vaeMBF9OW/8zbpG++/NP8M1VnTEWr9CGFyfHU0ln+vW+ic9Lyv9uB+rpJk= X-Gm-Gg: AR+sD11gxs6T8oooMsQOdm3uOnuqMXbhjxZI17/m5vKvvTC92UbaWVn12uGGjBfz9QS rEkNU4forJQ/U0uEGxzJu6pVC3JDIPaXyHkkfQEuKpI5xkyHqls07LASE3EL4CAfUbTLeLHEDLp 56+5d+OW4G1zwfcLeApStuKdk5vPHZHoYFz4LAHik3K+OIwqC7DgJWTGXda6IK/mB2nIyKJlE+s 0Iyqd87qc6lxu5eg+kiipkM0IS2YThZhOTvWKAWU3IVNBN5+W8GbpSxrXDmPUzgkFwnyv8JPZXn ukbcaHhFpV8kjB4cp7ouUBbsFbnBPkOrw2MJg6cjSmf13L7xcPuQx613o9SzJLR3CiaODtHb+kS LYi9PMAJbohZItTrSjMzTmBYAXJkkEA57Y+7QGAsd X-Received: by 2002:a05:6a20:d52b:b0:3b5:489c:7bb5 with SMTP id adf61e73a8af0-3c67da7901cmr6999995637.28.1785129093039; Sun, 26 Jul 2026 22:11:33 -0700 (PDT) X-Received: by 2002:a05:6a20:d52b:b0:3b5:489c:7bb5 with SMTP id adf61e73a8af0-3c67da7901cmr6999969637.28.1785129092616; Sun, 26 Jul 2026 22:11:32 -0700 (PDT) Received: from [10.152.199.23] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc3e1255sm41470321eec.4.2026.07.26.22.11.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jul 2026 22:11:32 -0700 (PDT) Message-ID: <5e1c8d1a-ffc7-43ef-8285-c1c002a36e3e@oss.qualcomm.com> Date: Mon, 27 Jul 2026 10:41:27 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next] wifi: ath12k: validate TLV length in process_tpc_stats() To: Jeff Johnson , Jeff Johnson Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260726-ath12k_wmi_process_tpc_stats-len-check-v1-1-c4ba2f84d9c6@oss.qualcomm.com> From: Rameshkumar Sundaram Content-Language: en-US In-Reply-To: <20260726-ath12k_wmi_process_tpc_stats-len-check-v1-1-c4ba2f84d9c6@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: x4INteeXZwHQe0H8iA-mylonUj9VeZPY X-Proofpoint-ORIG-GUID: x4INteeXZwHQe0H8iA-mylonUj9VeZPY X-Authority-Analysis: v=2.4 cv=GdYnWwXL c=1 sm=1 tr=0 ts=6a66e886 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=XkCbJFFJNXZGceBJsBQA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI3MDA0OSBTYWx0ZWRfX5wEBhptwQ016 l7aVQ2dtRi22xWwVW/Wc7ab9W0SwxJpIbEsm0NOopuz0Sjvm/Tg9ot/SnQy6PtYacbvHYqMcyq8 iQ1tns11Y003ekHal8a4OIjXEN1CLAY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI3MDA0OSBTYWx0ZWRfXwQOMU/xDN9sc jW2wm6Q2AYlk2oGcxipA694R67z32vcH/T9ZVOAsVGbgToeGF8HQ9dEv+hb9RSNebRPwimCELGl tc+h5nkIrxHRG01j6YQl6fo9Uvv2+vu2gm7mC7k6sEOuJz1KcMEDAWl9WgIqGj+i12onu4KUVbI qHiI2/h6/RxguFHTWf0uDMoAfqvf1Ah3ynR5J8aNZW2pkQ6UA+JOsdTvHp6QPPG0CmZhGGzi/n8 jfsvii1/odlzvI43bkC2g5sjeLUtxRlh/TEj1pKa1FZLvUP7ARX7xPg0cUWvQWTVu8vUWyHZf6d mLdVWe58/wDOExifht7tP0IKAID6qoDINWqygPwg1qWsx0I5FNctJeU8LvmFNLVCqeLLA0+d0OS 8HaKyuCO/GII7+O2hO3rgcgALofPIbNyp86UUcb7Z4/BmeWxgGQxdxsKQXk5t+ptWLfnk0x5ZKM s9DyQkU1hwoU6IxJTMQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-27_01,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607270049 On 7/27/2026 4:32 AM, Jeff Johnson wrote: > The outer skb->len guard only confirms the SKB is large enough > to hold the full fixed_param struct, but the TLV's own WMI_TLV_LEN > field is never checked. Firmware advertising a TLV length shorter > than sizeof(*fixed_param) causes reads of pdev_id and event_count > beyond the declared TLV payload. > > Add a check that the TLV length is at least sizeof(*fixed_param) > before casting and dereferencing the pointer. > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > Assisted-by: Claude:claude-sonnet-4-6 > Signed-off-by: Jeff Johnson Reviewed-by: Rameshkumar Sundaram