From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D3DF3E0C44 for ; Wed, 1 Apr 2026 11:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775042484; cv=none; b=WiUCErsCLWKAVp5D2F5kI6bdBi4J69enbAUnfqDZ+zQdNflbt6mSG0Ao3OL/C2Cq+MG+8WR7KIl4T9+/fie1PS9CGcOKr/DJekiVvI7OUe0HyJpCGLdEw9d7IgcKPLHzYDheQ/6gcuqlNy50/ZR1EHAc5Il7OGPG+sc/ArGaOyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775042484; c=relaxed/simple; bh=VMnhYYDUiaSfV3lX5JRhm4gQqAQh3ymN4z4y+uJ1Bss=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OC4jXg0XYTJurMHJojqMjcnne0mswMpIkeT3adhQ24X0ZUlBy0u7WzC5j0sF6t8hk/wRCxg04EZQKMoaAuv38OjprB/tTfhy/c5475NVxLerw0XdVg6cSxPr23q5N3g9fbxmSXQRUmYkPhyssk+roidIMODT0cWaRDTXriJQp4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n3d/GjPU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KSCwkHTr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n3d/GjPU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KSCwkHTr" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6317rpe91578304 for ; Wed, 1 Apr 2026 11:21:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bSggxIu2zQD4DsBMlrluFZINoxno1QBalYiFALDNiKs=; b=n3d/GjPUdHAvz2CW 58H63oyVg70eCSDzS7dQOgfiC8USySrryu3pXHoemDi5bx38eASlTcAJsAeTPxC3 0yeC1PkMZjQ8djJXSGttCXqjQvr+pOsFHvyyO8G6AUUTB1gNhPQTtR0B4bGYE0Lr yyoljGFMQLcTwj65pvfraKcoQMhcycUvlR5gHZB7drZjH4JOatp4jJD7c64dUYoT EjpnjZRkfd+8G0X3ofKkmyJBHH3tGWVP6616I1q3F1ZhmMZkC4j6o8rAnteYbTq+ llGFuJF/LFcPsGspSs8YNDOFi2IoNL83CVqG0EvWADxoG1KbPbEhhHbubif9d53n 3LFBYQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8k6kurgt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 11:21:22 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c73781252edso12653187a12.0 for ; Wed, 01 Apr 2026 04:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775042481; x=1775647281; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bSggxIu2zQD4DsBMlrluFZINoxno1QBalYiFALDNiKs=; b=KSCwkHTr+UQy0WT0lMbT57libRfCbahSHcDj9kwy/vJFpVJgqDMsT4S+3RHKW5fn3T AA63vUskwsv2L47VFUvZWl27emOFglwYYyv/5V8o+2WMaDgAuPNdKnfu3Ga/Q2aI2Eqc fQT/sJpk88oPBWo33SV5PIRWJ/dfrOak7fKSvN16k5c8O9N94QGVQOMy3LvOAzliJRhQ 2qinwZW90ETAuTL0NtN1/dsCc0acNS+OCC8arcpWFC/LTSbyEaUlru5eWd9H1uCc+spF N1i/oTMvAijmtOzJVU+jN/RcsHN2uKXX8TmeIYb7BwQSrpopb/Hr7hqFxWcJkiG5LENv eDRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775042481; x=1775647281; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bSggxIu2zQD4DsBMlrluFZINoxno1QBalYiFALDNiKs=; b=J4+qoVlLFfyjOB0kwVoo5cyFP0HaKPCj8wsqNW/f5PjBqeIIbp/jRlrdTMqKOM46to 4Xd32yvVjs3S4i6AGU60K54r4KElQ8dqx9LbB4F+iZa0aP/Yc4N5ZbkotGh5ycMQfmln csF/dPwVQRyZcP7A+g38s2JyyXq6WnATzcQ/skNsU/WK2BQSpn4ELHVAxg+mrFviaeno wHTWncFSSApRW6heGgT5ZrylJXobM4blxBCTCrOicQ58jZogy5sfePfJ5IN9xyuIOa/l Jg74YlCIaSXcq5HiDGi+/bGWV9SFNArrBVVGf0/d4fFdg1Ml5i7LlllnPYVQ0kkjzAR4 U38g== X-Forwarded-Encrypted: i=1; AJvYcCVwXJDJIiOELIrDltWbmDzRulbD/06LtGO71uupMawam1EzP4fgGs+3xeKqx3arseBMSw8eJEKQFnSy+gg=@vger.kernel.org X-Gm-Message-State: AOJu0YwFGNCEs9NWzBG7CYYLn3lS3mtaS/eLX/6vCGiqagNsibxv2l+t fIKB81EdvlmZdI65S2PBXRAEb8iWJbEB5PWxWiWOAfZ8aqDyZ4xDQEo1j0mF75vZ9smvIus18xu Vu39DP1qH3kriFjstxENKm+5zblhT481+SVyzsDf4Sd6nSz7vEXPsPtyiPLWfNbPmDss= X-Gm-Gg: ATEYQzxABPxvJRixF3jkZdKEzsnz2KBwT1SQQlloWj4shNUyda57Kv3/wHgcKkX5rL1 n68XNVcNL0WsvEn8t4K5wK2NGw3YM2rulJ4YtMusJSl+4gvayY91JCAYDAeWZLngD+qYFVMoK41 2pEguVvp7ZNcdoWGkcWYKyIa/k4cTETqPi8Oa8//Gd89mlgdWmExR7z44BW3osQxgUxYtKYP2Aa Wh4XtLsfDxn3Du3wMwRnD0dFhvZoleZcuDUK7dW88TZ3+zVAIodGr6pgfJYhndQhllcAqz16xFe QBS0PJTroKtSrWMzPwBPqiXrTO88qsLgVacABrKdDog48j7hMLP72iRx4d3NpfUhdmGiEXrxYJw hbBG240AJ8Qoijp83p3RZBcumWfaxhOHmURtoqk9rvZ8EPamjyOqKnA== X-Received: by 2002:a05:6a00:22d4:b0:82c:e601:3601 with SMTP id d2e1a72fcca58-82ce8ae56d4mr3725108b3a.42.1775042481327; Wed, 01 Apr 2026 04:21:21 -0700 (PDT) X-Received: by 2002:a05:6a00:22d4:b0:82c:e601:3601 with SMTP id d2e1a72fcca58-82ce8ae56d4mr3725063b3a.42.1775042480682; Wed, 01 Apr 2026 04:21:20 -0700 (PDT) Received: from [10.0.0.3] ([106.222.233.247]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82caf97abfesm12659643b3a.1.2026.04.01.04.21.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 04:21:20 -0700 (PDT) Message-ID: <5e1f6af3-c6d3-936e-70fe-6f7ddd472304@oss.qualcomm.com> Date: Wed, 1 Apr 2026 16:51:11 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v5 2/5] media: iris: scale MMCX power domain on SM8250 Content-Language: en-US To: Dmitry Baryshkov , Ulf Hansson Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Jonathan Marek , "Rafael J. Wysocki" , Bryan O'Donoghue , Vikash Garodia , Mauro Carvalho Chehab , Stanimir Varbanov , Abhinav Kumar , Hans Verkuil , Stefan Schmidt , Konrad Dybcio , Bryan O'Donoghue , Dikshita Agarwal , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab References: <20260209-iris-venus-fix-sm8250-v5-0-0a22365d3585@oss.qualcomm.com> <20260209-iris-venus-fix-sm8250-v5-2-0a22365d3585@oss.qualcomm.com> <5e2635ac-35de-645b-b5e7-235923f844ce@oss.qualcomm.com> <0b41ee7c-83fe-d604-b750-8a5a0bd62bf8@oss.qualcomm.com> <6yfn6ux3gbin2dtopdxxv4okinspueryuey5vfdq633gsewc6r@ttp56brnpgvr> <4fiyjcqt5smotudsfzyqrevxxnx3sf5grbgfluzkndbp2od6pq@vlyikcvl3xkb> From: Dikshita Agarwal In-Reply-To: <4fiyjcqt5smotudsfzyqrevxxnx3sf5grbgfluzkndbp2od6pq@vlyikcvl3xkb> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=bfJmkePB c=1 sm=1 tr=0 ts=69ccffb2 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=5/Y9Gi2N1OwmQbPtUd2E/A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=cwlDSPEQxbFMGEvUi3wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDEwNCBTYWx0ZWRfX7rc8RFoJFwom Y2/wqFhFS16+yc1XY0az3/kEYY41kufr7X8NYagwUce+lRpZE4Vx1gbhti6gn87tVm8r7INWDi1 /qUC315eZKzRc3HiqoRpvjIJzqarrOETusZYGanwY4KA9nXzHXn2bOHpGVtyG1sAQCcrxpTBwdd dtGPa9dzGUg5mqRRjy+8Vbze65l5t8MWu/BRWvvaeCPxhAHmr7Dxx5mdaG+EGtgQp8Zw5XcUNBq mo0+Qk5ERuo3Naqsiieb0h38yYdyVhaDhtZV2xCgt4eF7Ygq5egYexvZaibnMKRhSFruFpKgbhY 1DWYQKEHA6pocnMYtNmbT8KpLa6k5/q0V4dbN5GLp+4d6qdOAT8YtErTA8Hb5JLceQKCQ8w4UAf 0+MtEC7BH8WIR1ISDlhPqKdnPWADH6aV6VH9HfSUIgdquNDSLZsDtJlcIwdnCSFQ5pjMjGuEBRP 14k57SL+AUyamAyECCQ== X-Proofpoint-GUID: AYDtivDzZtZso_oB0MSO_K-1bKZRRlIi X-Proofpoint-ORIG-GUID: AYDtivDzZtZso_oB0MSO_K-1bKZRRlIi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_03,2026-04-01_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 suspectscore=0 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010104 On 4/1/2026 4:31 PM, Dmitry Baryshkov wrote: > On Wed, Apr 01, 2026 at 12:46:01PM +0200, Ulf Hansson wrote: >> On Tue, 31 Mar 2026 at 20:46, Dmitry Baryshkov >> wrote: >>> >>> On Tue, Mar 31, 2026 at 01:33:35PM +0200, Ulf Hansson wrote: >>>> On Mon, 30 Mar 2026 at 15:06, Dikshita Agarwal >>>> wrote: >>>>> >>>>> >>>>> >>>>> On 3/30/2026 4:45 PM, Dmitry Baryshkov wrote: >>>>>> On Mon, Mar 30, 2026 at 10:55:02AM +0530, Dikshita Agarwal wrote: >>>>>>> >>>>>>> >>>>>>> On 2/9/2026 7:02 AM, Dmitry Baryshkov wrote: >>>>>>>> On SM8250 most of the video clocks are powered by the MMCX domain, while >>>>>>>> the PLL is powered on by the MX domain. Extend the driver to support >>>>>>>> scaling both power domains, while keeping compatibility with the >>>>>>>> existing DTs, which define only the MX domain. >>>>>>>> >>>>>>>> Fixes: 79865252acb6 ("media: iris: enable video driver probe of SM8250 SoC") >>>>>>>> Reviewed-by: Dikshita Agarwal >>>>>>>> Signed-off-by: Dmitry Baryshkov >>>>>>>> --- >>>>>>>> drivers/media/platform/qcom/iris/iris_platform_gen1.c | 2 +- >>>>>>>> drivers/media/platform/qcom/iris/iris_probe.c | 7 +++++++ >>>>>>>> 2 files changed, 8 insertions(+), 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_platform_gen1.c >>>>>>>> index df8e6bf9430e..aa71f7f53ee3 100644 >>>>>>>> --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c >>>>>>>> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c >>>>>>>> @@ -281,7 +281,7 @@ static const struct bw_info sm8250_bw_table_dec[] = { >>>>>>>> >>>>>>>> static const char * const sm8250_pmdomain_table[] = { "venus", "vcodec0" }; >>>>>>>> >>>>>>>> -static const char * const sm8250_opp_pd_table[] = { "mx" }; >>>>>>>> +static const char * const sm8250_opp_pd_table[] = { "mx", "mmcx" }; >>>>>>>> >>>>>>>> static const struct platform_clk_data sm8250_clk_table[] = { >>>>>>>> {IRIS_AXI_CLK, "iface" }, >>>>>>>> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c >>>>>>>> index 7b612ad37e4f..74ec81e3d622 100644 >>>>>>>> --- a/drivers/media/platform/qcom/iris/iris_probe.c >>>>>>>> +++ b/drivers/media/platform/qcom/iris/iris_probe.c >>>>>>>> @@ -64,6 +64,13 @@ static int iris_init_power_domains(struct iris_core *core) >>>>>>>> return ret; >>>>>>>> >>>>>>>> ret = devm_pm_domain_attach_list(core->dev, &iris_opp_pd_data, &core->opp_pmdomain_tbl); >>>>>>>> + /* backwards compatibility for incomplete ABI SM8250 */ >>>>>>>> + if (ret == -ENODEV && >>>>>>>> + of_device_is_compatible(core->dev->of_node, "qcom,sm8250-venus")) { >>>>>>>> + iris_opp_pd_data.num_pd_names--; >>>>>>>> + ret = devm_pm_domain_attach_list(core->dev, &iris_opp_pd_data, >>>>>>>> + &core->opp_pmdomain_tbl); >>>>>>>> + } >>>>>>>> if (ret < 0) >>>>>>>> return ret; >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> Hitting below compilation error on latest kernel >>>>>>> >>>>>>> drivers/media/platform/qcom/iris/iris_probe.c: In function >>>>>>> ‘iris_init_power_domains’: >>>>>>> drivers/media/platform/qcom/iris/iris_probe.c:71:46: error: decrement of >>>>>>> read-only member ‘num_pd_names’ >>>>>>> 71 | iris_opp_pd_data.num_pd_names--; >>>>>> >>>>>> See commit 7ad7f43e568b ("pmdomain: de-constify fields struct >>>>>> dev_pm_domain_attach_data") >>>> >>>> The intent was for this patch to be part of v7.0-rc1, but I failed >>>> with my pull-request to Linus. >>>> >>>> Instead this will be part of v7.1-rc1, assuming everything goes as expected. >>>> >>>> Is it possible to drop/defer these changes until v7.2? >>> >>> It would be very sad. >> >> Right. >> >> Since it's my mistake, let me reconsider. If I rebase my branch and >> share the necessary commit through an immutable branch that you can >> pull in. Would that work for you? > > I think that question goes to Vikash, Dikshita, Bryan and linux-media > maintainers. Bryan, what is the plan for this patchset? Should Ulf > rebase the branch? Or is this patchset delayed for some other reasons? Its good to go, Bryan can comment as he will be raising the PR. Thanks, Dikshita >