mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Johan Hovold <johan@kernel.org>
Cc: Rui Miguel Silva <rmfrfs@gmail.com>,
	Alex Elder <elder@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: power_supply: Use struct_size() helper
Date: Wed, 10 Apr 2019 13:30:28 -0500	[thread overview]
Message-ID: <5e204c42-e567-9ab2-340c-1b8d017807e3@embeddedor.com> (raw)
In-Reply-To: <20190404065733.GA12635@localhost>

Hi Johan,

On 4/4/19 1:57 AM, Johan Hovold wrote:
> 
> This patch looks good, but I noticed a bug here in the current code,
> which should be fixed before applying this clean up.
> 
> sizeof(req) should have been sizeof(*req) above.
> 

Good catch.

>> -				 sizeof(struct gb_power_supply_props_desc),
>> +				 sizeof(req),
>> +				 struct_size(resp, props, props_count),
>>  				 GFP_KERNEL);
>>  	if (!op)
>>  		return -ENOMEM;
> 
> I've just submitted a fix (and CCed you as well). 
> 
> Would you mind respinning on top of that one?
> 

Yep. I'll send v2 shortly.

Thanks
--
Gustavo

  reply	other threads:[~2019-04-10 18:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 20:58 Gustavo A. R. Silva
2019-04-04  6:57 ` Johan Hovold
2019-04-10 18:30   ` Gustavo A. R. Silva [this message]
2019-04-04  7:09 ` Rui Miguel Silva
2019-04-04  7:24   ` Johan Hovold
2019-04-10 18:36     ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e204c42-e567-9ab2-340c-1b8d017807e3@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmfrfs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®