From: Andi Kleen <ak@linux.intel.com>
To: Stephane Eranian <eranian@google.com>, linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, kan.liang@intel.com
Subject: Re: [PATCH] perf/x86/intel: fix ICL/SPR INST_RETIRED.PREC_DIST encodings
Date: Wed, 13 Oct 2021 17:37:47 -0700 [thread overview]
Message-ID: <5e2262a3-ec27-fa3e-c5d1-3a5e25a42042@linux.intel.com> (raw)
In-Reply-To: <20211014001214.2680534-1-eranian@google.com>
On 10/13/2021 5:12 PM, Stephane Eranian wrote:
> This patch fixes the encoding for INST_RETIRED.PREC_DIST as published by Intel
> (download.01.org/perfmon/) for Icelake. The official encoding
> is event code 0x00 umask 0x1, a change from Skylake where it was code 0xc0
> umask 0x1.
>
> With this patch applied it is possible to run:
> $ perf record -a -e cpu/event=0x00,umask=0x1/pp .....
>
> Whereas before this would fail.
>
> To avoid problems with tools which may use the old code, we maintain the old
> encoding for Icelake.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
Make sense.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
next prev parent reply other threads:[~2021-10-14 0:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 0:12 Stephane Eranian
2021-10-14 0:37 ` Andi Kleen [this message]
2021-10-14 10:09 ` Peter Zijlstra
2021-10-14 18:01 ` Stephane Eranian
2021-10-15 10:27 ` Peter Zijlstra
2021-10-30 14:40 ` [tip: perf/core] perf/x86/intel: Fix " tip-bot2 for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e2262a3-ec27-fa3e-c5d1-3a5e25a42042@linux.intel.com \
--to=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®