Re: [PATCH net-next] net: phy: Add c45_phy_ids sysfs entry

["Yajun Deng" <yajun.deng@linux.dev>]

May 28, 2025 at 9:08 PM, "Russell King (Oracle)" <linux@armlinux.org.uk> wrote:



> 
> On Mon, May 26, 2025 at 08:52:12AM +0000, Yajun Deng wrote:
> 
> > 
> > May 26, 2025 at 4:19 PM, "Russell King (Oracle)" <linux@armlinux.org.uk> wrote:
> > 
> >  On Mon, May 26, 2025 at 08:11:21AM +0000, Yajun Deng wrote:
> > 
> >  > $ ls /sys/class/net/eth0/phydev/c45_phy_ids
> > 
> >  > 
> > 
> >  > mmd10_device_id mmd17_device_id mmd23_device_id mmd2_device_id mmd7_device_id
> > 
> >  > 
> > 
> >  > mmd11_device_id mmd18_device_id mmd24_device_id mmd30_device_id mmd8_device_id
> > 
> >  > 
> > 
> >  > mmd12_device_id mmd19_device_id mmd25_device_id mmd31_device_id mmd9_device_id
> > 
> >  > 
> > 
> >  > mmd13_device_id mmd1_device_id mmd26_device_id mmd3_device_id
> > 
> >  > 
> > 
> >  > mmd14_device_id mmd20_device_id mmd27_device_id mmd4_device_id
> > 
> >  > 
> > 
> >  > mmd15_device_id mmd21_device_id mmd28_device_id mmd5_device_id
> > 
> >  > 
> > 
> >  > mmd16_device_id mmd22_device_id mmd29_device_id mmd6_device_id
> > 
> >  > 
> > 
> >  
> > 
> >  I suspect you don't have a PHY that defines all these IDs. Are you sure
> > 
> >  
> > 
> >  your .is_visible() is working properly?
> > 
> >  
> > 
> >  
> > 
> >  I'm just determining if it's a c45 device and not filtering PHY ID content now.
> > 
> >  I can add this condition.
> > 
> 
> I'm talking about listing all 31 entries, whether they're implemented in
> 
> the PHY or not. Look at mmds_present in struct phy_c45_device_ids to
> 
> determine which IDs should be exported as well as checking whether the
> 
> ID value you're exporting is not 0 or ~0.
> 

I've already sent v2. Please review it.

> -- 
> 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> 
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
>