From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A909418A6CF for ; Mon, 28 Jul 2025 12:04:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753704249; cv=none; b=qpAevwKaD6lLlN83bVzHHPHF5TgUgMqxMpiVXLJcCX84nO8Je65dmL9wRJUZhtzRJrHXHhesSfkRjHOpF+eU+8dY0w65xXJm3V6+SYzBT9ELvz9fds/ir4wr9ujv9OoQYxS8wWgZpdMinNtdRJu/bDJ4d8vOUtRMjOsqjNSDwgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753704249; c=relaxed/simple; bh=5rAvbVGtB7lFEOgjNCztAzaQGPyJ6cuIh1BF+HOX/d0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BZiUHZWR2Wp+TS3JO8Y8/JRfBX+NZnvLE8h6Zk5Y0Mc9j8Nl+PBg0mnA0f1TeHTwyDI4RRdUP+2bF1AhBCYEdk3Y+MIFXjxAm3h49EKbnF4uU1PagFmoS572V1lWEnsadZH0V6aUtqttulVMtQwdCb6W3Wubpx74YUJ79E6Cuwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oXmc+B86; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oXmc+B86" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56SAlNtL023584 for ; Mon, 28 Jul 2025 12:04:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 66vOC3/qlK+MyX1ZwSFINvuQl7YeMvvNbUSCtqoe2Dw=; b=oXmc+B86PKUWLJVm QmOpYEtQ3X4JsvXSyBAVaGeN1yGLf7GeUn5xEjkuzpWAWLaO6HyuZWPubGDWatMF 2RtLNtrcea4FUlk1nFQ29VO9pWFmUWWeypasRwXZtoIhJS+bP26mbjzM/fdYObcD EsZ6QMmFwGbS3EwxC6tXisZM+cPgtOJWcPaNpmngAI4t+5ysoc1LjuSvHUHtsdci hpC7bRxWV27vCsWKzkEnxaAy3l4RpZP2QOoH5Ke1xtRHgmxceUPBPkoUby8J2MG+ GPeER5xrSghPrUu2Z4HhXPbu2ZZE5wekUZ/5S9xfcCOR2v7Y09zGMwSg0CV3X1Ux JSf9xg== Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484r6qme35-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 28 Jul 2025 12:04:06 +0000 (GMT) Received: by mail-il1-f197.google.com with SMTP id e9e14a558f8ab-3e29aabc9cbso41765635ab.0 for ; Mon, 28 Jul 2025 05:04:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753704246; x=1754309046; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=66vOC3/qlK+MyX1ZwSFINvuQl7YeMvvNbUSCtqoe2Dw=; b=G1fWUhNMtTUWujkqzcqJuBOERiXfzENT1Htkm+Bn499xSoX2XQCvSp+5G4Vjj/2Jxl AbwUNFRL21meFVxtxWBe9dccDqVAkvRWlu5l5gr5uEHfUGhKQCWQakB2p5bxlxRi42Fq 3sMn6VijQii5jtUGagi05pvxooTO1DCGs6ND6/CTDiGstvz7sytDax44ZdywZLCQgd8W cMWOJnrPUjuHfCu5P67w2SmrTr8pRgjOr2vmJwOLvYZ29DTrGehXVSWtfctocbuLCrvc t39Rz1MRQA23GjQS/blEj+/6igmYEfIjotDzWw7HCsbmr/c/NatVGUZUeSgR8hPbH0Yj O2kw== X-Forwarded-Encrypted: i=1; AJvYcCW8+VEYPmPdajJca9ZjjYlzaeY10LKncIerG4v8OEkegRekcFtcfj1UnS8VNoEGaxG74oizR7cx715UCZw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywf4NvHgHzcIIC2i/rJZLhe+nh1m0mA3HhgYTvXnTibPSfjFHqO LU+rNDeIi5YIEaFE0XR1WTY9ZxmycI7Lc8FAioC8U1JbFIQ7u/xkk75cy08K3o+xk36oVj9KE8J SYBtPCgzl2HPOYqHceXSeCsKCiGoVzD2+xMd4VfzovTSibtvqX+Wx/aVp+CboexM5/U0= X-Gm-Gg: ASbGncvlEFi5lH8TkXW96ib5rPb8NplvcQmjwKFkfIDJnASP00Va2IsRHkoeKY0RZCG kgv7932o8D9gYKUumi4SJu8/AY4rgJa8ZNVl4iewJvIfbeYN1utI3hYf6lCfA7bYv/6WcxNoYit e86FTC+YiuEaNRLzMDNTvUtmb1pDPhISXmxLiopPcOJBgcpjfAXXHcUShxf46Fg80Lehccq7+oj 8jf7gfStwCPToqhAzA+onWG+DzNNzCBh/FkhgmgXo//Qu5gfmz5oAznDBuCLDie3owIpyg3/E9+ LlaVLxcB9D6WptIPkYYYes+Y0Hsz4Ays0VIYygj/lAQCDPs+vttwOvrGsNjhxaKgyLvtpNAPELZ HzWit+Bo5CwDMUP+dqh9E4qF3TEpNCQysgzWnIhnstWXV0Q0PheIHBRd4nLN94spaffBmJnUDD2 ePLK7udtU66p/n1S8nBQ== X-Received: by 2002:a05:6e02:3707:b0:3e2:8a58:7f67 with SMTP id e9e14a558f8ab-3e3c52e6ac4mr173518255ab.11.1753704245662; Mon, 28 Jul 2025 05:04:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+zIpMz+L3rJ5NWcaLcGYendd5twzo270GnZHovgracNvGxzH2qdsYSFiW1xnhFedlu22Z8Q== X-Received: by 2002:a05:6e02:3707:b0:3e2:8a58:7f67 with SMTP id e9e14a558f8ab-3e3c52e6ac4mr173514325ab.11.1753704241592; Mon, 28 Jul 2025 05:04:01 -0700 (PDT) Received: from ?IPV6:2001:14bb:cc:47df:318b:ca77:b793:45a5? (2001-14bb-cc-47df-318b-ca77-b793-45a5.rev.dnainternet.fi. [2001:14bb:cc:47df:318b:ca77:b793:45a5]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-331f42b6edbsm12086391fa.98.2025.07.28.05.03.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jul 2025 05:03:59 -0700 (PDT) Message-ID: <5e2caeb7-360a-4590-a36f-ff1ec4c20d31@oss.qualcomm.com> Date: Mon, 28 Jul 2025 15:03:57 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 07/10] firmware: psci: Implement vendor-specific resets as reboot-mode To: Krzysztof Kozlowski Cc: Shivendra Pratap , Bartosz Golaszewski , Bjorn Andersson , Sebastian Reichel , Rob Herring , Sudeep Holla , Souvik Chakravarty , Krzysztof Kozlowski , Conor Dooley , Andy Yan , Mark Rutland , Lorenzo Pieralisi , Arnd Bergmann , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Vinod Koul , Catalin Marinas , Will Deacon , Florian Fainelli , Mukesh Ojha , Stephen Boyd , Andre Draszik , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Elliot Berman , Srinivas Kandagatla References: <20250727-arm-psci-system_reset2-vendor-reboots-v13-0-6b8d23315898@oss.qualcomm.com> <20250727-arm-psci-system_reset2-vendor-reboots-v13-7-6b8d23315898@oss.qualcomm.com> <3gtlf5txxtioa5bvo6o467jupyoam4hjhm2mdiw5izv5vbl3tz@drndgp3tcrgo> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI4MDA4NSBTYWx0ZWRfXw4CvUTzhINdR EDi4Bw8lX9vBvJfasTmjnKioFFMTbkETiywCW5KAGUYow/ofKfa+jJM1BzCl+3oT47pHSnZ3m+m hG2i/OASvk/y7bSsNIhnbvUQc7FAd2C1yAIj7PqNzAnua/0YAfuNowAQwoyDzGGe6DUaKGvqT22 lMS37PuIpflUZiIRcFgDYtrcz/0elU3GNAV7udKgzdRC3Pp/x/TQp4zQ1GJXbSeZ3V+OIGSRysl QR85pd/TGwKdgPXXWaL7SbnX2HL+ypu09TStmxnlL5VEgiMwm6vsE0syn1VLNo1QTUi0B9WjI/D Eqr1ferAAKKQa1kOfg6wRRgBd3UJhz1oZJUIK2zkjEFapzbVjNg4msSG3hsrcMV26dW9rRYmxw4 yKkvfR/t/7zzY9nivmrVNh0Q8PzQA92ckAtJx3I9IT83QkeA1Erdq71wpmJqkyRvj+q36nbg X-Proofpoint-ORIG-GUID: eDnZfJVJ65Ix9KbcOtXksCg6-_sKE-Zk X-Authority-Analysis: v=2.4 cv=ea89f6EH c=1 sm=1 tr=0 ts=68876736 cx=c_pps a=5fI0PjkolUL5rJELGcJ+0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=jG_yPd5o3CEIpo8lzG8A:9 a=QEXdDO2ut3YA:10 a=HaQ4K6lYObfyUnnIi04v:22 X-Proofpoint-GUID: eDnZfJVJ65Ix9KbcOtXksCg6-_sKE-Zk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-28_03,2025-07-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 suspectscore=0 bulkscore=0 adultscore=0 clxscore=1015 spamscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507280085 On 28/07/2025 14:52, Krzysztof Kozlowski wrote: > On 28/07/2025 11:44, Dmitry Baryshkov wrote: >> On Mon, Jul 28, 2025 at 06:53:14AM +0200, Krzysztof Kozlowski wrote: >>> On 27/07/2025 18:24, Shivendra Pratap wrote: >>>> + >>>> +static int __init psci_init_vendor_reset(void) >>>> +{ >>>> + struct reboot_mode_driver *reboot; >>>> + struct device_node *np; >>>> + int ret; >>>> + >>>> + np = of_find_node_by_path("/psci/reboot-mode"); >>> >>> >>> Why are you looking by full path, not by compatible? Is the ABI - above >>> path - expressed anywhere? >> >> PSCI node is required to have a node name of psci, it doesn't have MMIO, > > This is true > >> so it resides in the root node > > This might be or not might be true. It is not defined by ABI. Anyway, > you answered where the ABI would be documented, even though as I said it > is not (/psci is not), but does not answer to first part: why you are > not using compatibles which is always the preferred method? That's a good question, I've added one from my side: why do we need an extra late_init call. > > >> and the reboot-mode is defined in the >> previous patch. So, I'd assume, the path is defined. > > As I said, path is not. only psci/reboot-mode is. Do we have an _actual_ use case where PSCI node is not at at root node? If not, it's obviously a deficiency of the schema. Could you please provide suggestions on how to describe that in DT schema? -- With best wishes Dmitry