From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751796AbcGWBrg (ORCPT ); Fri, 22 Jul 2016 21:47:36 -0400 Received: from mail-by2nam03on0069.outbound.protection.outlook.com ([104.47.42.69]:10140 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751061AbcGWBrd (ORCPT ); Fri, 22 Jul 2016 21:47:33 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.225) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c71-eb3ff70000000e72-f0-5792c7cdaac1 Subject: Re: [PATCH] add u64 number parser To: James Smart , , , References: <5792b919.0C1gyf+dF4XKu6Zj%james.smart@broadcom.com> From: Bart Van Assche Message-ID: <5e325cbb-a140-8f26-7402-5dc1a2cd07ea@sandisk.com> Date: Fri, 22 Jul 2016 18:32:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <5792b919.0C1gyf+dF4XKu6Zj%james.smart@broadcom.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsWyRoxnke7545PCDeYd07XYvfAjk8XlXXPY LOYve8pu0X19B5sDi8es+2fZPDYvqff4vEkugDmKyyYlNSezLLVI3y6BK+PLofCCi0wVR7/8 YWtgbGfqYuTkkBAwkXi4ai47iC0ksJRJYseXxC5GLiB7B6PE5a1PWWGKJs5sY4dIzGWUWHZq DTNIQlhAS2JO01SwbhGBHkaJ7olQkxwknv/bDFbDJmAk8e39TBYQm1fATmLG3Vtgm1kEVCWW L5gCFhcViJDo/bUEqkZQ4uTMJ2A2p4CjxMxlt9m6GDk4mAXsJR5sLQMJMwvIS2x/O4cZ5B4J gUmsEt1ztzNB7FWXOLlkPtMERqFZSEbNQmifhaR9ASPzKkax3Myc4tz01AJDE73ixLyUzOJs veT83E2MkAAv3MH4+rb3IUYBDkYlHt6CqEnhQqyJZcWVuYcYJTiYlUR49wLjQ4g3JbGyKrUo P76oNCe1+BCjNAeLkjjvxeiPYUIC6YklqdmpqQWpRTBZJg5OqQbGeRMtXT60pGXeuPR0yary ncYROawPhZ1S9BZ8skzc8T/3j6+aQibvo1spx9Sybt9hnyNpmFD38Jaf+SeeuZcP8GqHt8Uy 1S9bI3TtmtjUrcu/9F/WkZ7EmsWxdAZ7v/U53muyFy/uW6J1u3ljOmOuSlhKsuuMf4tbxTSM /hT3fFm0P6TiS2qAEktxRqKhFnNRcSIAzjmSPWwCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEJMWRmVeSWpSXmKPExsXCtZEjRVf75KRwg3dHZC12L/zIZHF51xw2 i/nLnrJbdF/fwebA4jHr/lk2j81L6j0+b5ILYI7isklJzcksSy3St0vgyvhyKLzgIlPF0S9/ 2BoY25m6GDk5JARMJCbObGPvYuTiEBKYzSjRvrmNBSQhLKAlMadpKlhCRKCNUWL63S3sIAkh AQeJ5/82M4PYbAJGEt/ezwRr4BWwk5hx9xbYVBYBVYnlC6aAxUUFIiR6fy2BqhGUODnzCZjN KeAoMXPZbTYQm1nAVuLO3N3MELa8xPa3c5gnMPLOQtIyC0nZLCRlCxiZVzGK5WbmFOemZxYY GuoVJ+alZBZn6yXn525iBIcaZ+QOxqcTzQ8xMnFwSjUwcvgw+80XFeVYeecz8332yz4J/rGV p7/Hqkrd1UtzO3/sneiJq4duW3jtrGJjn5xbJ3li87YXSf/mSezpecf/8qfui9xrU5+2ruI/ kJamkfo4+5FRg3xok+6F567rLPnNpsjGPPh8LY6xolJrTmxDQPjeuf7BfA/vrd8U1eOdvbzt zKzc4qMaSizFGYmGWsxFxYkAV5swWuUBAAA= X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.225;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(199003)(24454002)(6806005)(4001350100001)(586003)(2950100001)(31696002)(77096005)(87936001)(230700001)(23746002)(65956001)(65806001)(47776003)(189998001)(86362001)(2270400002)(64126003)(2201001)(97736004)(92566002)(5001770100001)(106466001)(81156014)(81166006)(2906002)(50466002)(356003)(33646002)(8936002)(31686004)(305945005)(107886002)(54356999)(69596002)(68736007)(36756003)(7846002)(8676002)(76176999)(83506001)(50986999)(11100500001)(65826006)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR02MB2339;H:milsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD023;1:pV9A/5LfHw7TTPPz+IVmk4DHFFY9QgyFYD24+hIW4xo8fhHOn5pcghYCx0Hf56yPcaDPxcaxmLj/LxY2+V8ZrFlmnMYhJ/bBEldER7o7twyNXTnczzJDMs+p4P3cqYanyF1s6lV10KHMIDRgv+mbQV0QsWHW8dKunE9JF9gA2ScFBmIMFbNYKFJ17zNN7azuvF6G75IcPHAT/8Vn+aFXNRQZF12PIhlgmgx1wR9YkPumcVhJUp+5IOJZYNopYVCeczHQX/Bk0004fANNMJgLrtjasIoxNol5fyMWu3hJiI1jNxNIrO1y/sA9iopx+TWT+5sYO5C5cs/8TKLUr4Je31XfDnVRkB6q3B0Y4ObLN6M11GvDGpWggq7ckHLh80U68jZwXxo0r2icHjk/8FRrCTYschUS+keJvFaEe77bl+hOvi81jLddZPaB6TEdMhdRME+P46kiZe8MdJ6GHUThorb8yCMKTIztIkpOcfPqvPU+HNUiDxR7Gxy7eGgC7erFlF2/uBHYAZXdGFFjKw8EWg== X-MS-Office365-Filtering-Correlation-Id: d7ecce50-7edc-494f-a114-08d3b29937d1 X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2339;2:iGJwZzxuqTqfZDnrYWO5MfnPLZXRFn7SsfHA7VOeoATT0DwcV9R/J3agho1pxLw1gpddz8bJL/RPajOxVBzI7jH5m8TU9Wr3jiC3jQXSzf/XCBByEL17IlVo3m0qpnlh6p3DRDL2PT/NuxBiPH3k/rdmd0yoy/4htwLR/g9QwqmnJnj61zRWmIxfJ+nX8oMV;3:LtfhO2hYmiGzEbuKrov7JeAa+8h55sIy8yKisGAPCi51tUlSLa+G3mXYoy55oQvCcy+Ia+/65zvSotrerRMSwvDZG7dMdofB0b8DthWQM3GJgVQILKGaBBZFiQ5xJqX9Ug3ycwAZBPT3xFGZu20hUqAm80b5bw+XdK5bPyI8i7BM0wTbXXevXWN84e0BSCNoYyNCh93h+PbL+uPZ/d7Pgpb56m5jRY8+T3kII+ufBflLC2EYB/zQG0GXhMwerb/UA9ttihcd0rklyAH8XxcCug==;25:jiEYh6C1QSgJY4bLuxw5jsZfVPEYhissUpTwhBg/mAvWQ9jYEnkDJmq1GmNzOZDiibfdpv9l45ePD4W7cT4N/AQyEAj8CUreZ4vrWpW6tbx11K2klz6EdojaSZui7IjysNNZGCKlmT6y4dW1uaWHa/Zk3gecYjuM4fUCS6FHIU+7Ooorixiv/RS74VdUxjxNQdJNhu9jS45bi2yV3wzl2glWnWdMN3CuMxbrAJGSNmm4sYVMytIi4o5h8IBTaQXhKuLjesyN2HdiDH4uP1a0r+UCV27rG4j4lxVqMTfXr/X9a1QiTFiku3z0cgDgHMKKwWBy7N7XU5EX2j1sTeu5TFQLbo24glIa/Io9tvjsGUSopFsDl5PAgZerAxrUYovwVQeIrazSrBASpm7+XZ5TPCUtEid3T5xEmICDauq9zT8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BN6PR02MB2339; X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2339;31:gHpdapFHtY9W80xlW8iESY/XXjlphesjdzNcHNqHAjvLgo725rJHYsl30nx5+G9YutNFBagTG75hz6PNhcfjQVaF2i/RHLXk044zGb3we1hD43QQ3zqPjuYyU4R0oX/6Zz2oxaMCwPSmIshB+VbWf64z2Fn5Q/7ZOoIDJss8FJOHBXHbTK6c1p7kT8FlbAHz0o/TpwaWQkULbWlF7PUfBw==;20:Eb60JBBgKWHHoChS7jm83xEFKdQwKywjABfxKjc1HFpuAfFVIxyDH+26Rs+YKNrTliWLM9eqUznIHr+5gStgeH1/Oc3IHN/pB2ZKZZxSvgrp7jv5Mv7+0gPvZiJYhNEAfA0JLVl1Ij+wZrn0utyCKIERXWpSfoawtxUXf2MzAGL3WUDR/S5PwWxLv8yrv1lE+I2CbOuyXIaY1nCQZyebbYEKY+FfxN7g3EPenVBxJ/PUz4XKKgWl9KeThsYlZUASvQ3ZJNt/2pJvnbv2epBnN6QfE4chTRYPzylowv3wa6pwvVEwUOoD7ZPYaoZvedjYMOu6I6yxtmHNMmjFKgSAfCdnBj2azIEFX/0JUdfqZklQPgPDdn+h8bRS8EhXMY7VUMw5/8+hUJ7a37wqaQ082Zi7WsAB8jOT7dsOLnIQipRP68X5c1A/HdphvFEwlIVE6aMvoSpS/tEZx0OYv0LdAbeIm3THeyqPEWod5MgjOJvzgxvqbQIKSdQinnywwe9h X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(13018025)(13016025)(10201501046)(3002001)(6055026);SRVR:BN6PR02MB2339;BCL:0;PCL:0;RULEID:;SRVR:BN6PR02MB2339; X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2339;4:MT1ZEcfTDwf1YAy/mUT2cf0Ph3NoR1rEBccx81jURr26nR5jTIQ6DiOJnDkyAnEJXPDb5ADJYjoXlz/0Tng5po6YiVmFUWzNfCYREA0JM6mRSJ+ro+c8vk4emUAKVOJz+uvAKA0DbyNQ+PGIeCkUFLKqwCGqeI0b4o1kjpAAMqZM2TM/kRABkPpzOqCopUMG2SDaaviVSqsYPv4afPMRAadAS8PwhG3lkCbnk8dSoKTB63Rsl6hh5K0lNguSzjm5iDb3Np7TqcnxwycqejnIuSgkQMfViXWNTwwQCp8BWwyWZJG3TJ8dTDKkBOXyT10O6bmYAI/VIjqAxgGJB5jzeKILFHWtzMUIHTVUhD+yjmT3oe3OSDvV29qF6XQjBxfIOp8E8LDmSi2KTUz2f01SYoXnDXBOgjRHt0RQrUdpHQI= X-Forefront-PRVS: 0012E6D357 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR02MB2339;23:rWNHjpcZ8YcnqI7NSkMP3ekj9HcVXcNGMj/Qv?= =?Windows-1252?Q?Gpk3SYCJpZW+Rs1fwlt0Ac+DrljIThssBLTQppfBSZNDUqJoeqUhfYIu?= =?Windows-1252?Q?fvJ8wUwx2fAis26szCgpnOCLa0KJnsckKHFUlh8f60QOOi0YY+JgFokh?= =?Windows-1252?Q?N6s3bcb2+qYANe5xnkIFpQtnLSU1OpcmVB/p4iOADgxnfqwutyTTgWQ+?= =?Windows-1252?Q?ubELTBWf390bLvpp6+GI3lvTh8Au3DVxcNImFOtg9UlbqpXu4fvOcf0C?= =?Windows-1252?Q?hTWN2DUadSY7qPdrbM0raPp3prJFjNlthE38wryynCg8kATIKCEbdm3O?= =?Windows-1252?Q?dh0YNxA93PuHl/8lFyespUxtaQvO3bd5NgiwmaqtV7IE4FYug/UDEpWL?= =?Windows-1252?Q?YXtSee8KPISGOb7eRGLYzXZW/Yg7nl4w6wCSA3PZPxUI9dX6a629R8kE?= =?Windows-1252?Q?ROoozN/fHHyhvZoL01Ytr/vML7hQnwUVC8r7/aqruqbnckm4TV87lTj3?= =?Windows-1252?Q?FH1jG/K9hjOKFGDoriN2m6X4ROPgbv9OCd5VHNQHvvRJtXo75uSlkIP1?= =?Windows-1252?Q?IbJNPVnyOATRTz0l3MU9/dPNFA2XmcmnwGKWkB++nqIsVHOAh1hkAdTB?= =?Windows-1252?Q?G6yuUx7feCkRyo8jV50GB3uo0uW2gLTKtv8hivooFAk25PXC+3tCTgPv?= =?Windows-1252?Q?3+RGr/t7nNpCYM/9cRe+HClkxQXbMJh+SUEThIwhVbYymx36PHKE8lbD?= =?Windows-1252?Q?zq9obUXxIqHIx97LtnEgvxQh+AwrneqBZgVQkWpRVgmPiu+d8HDQHYuM?= =?Windows-1252?Q?1Y8ZZgi2im2BuSqRVF3ZNl21iAsgd9domYmHAEy6xBAOj41qo1KuhWVl?= =?Windows-1252?Q?aEBpqKBidHf4k3CuM5HmdC13xHGxhh0HxiFCGoqBzPlO6HKAW0ZfpMtX?= =?Windows-1252?Q?/5MiiF0Fqou3Dv3DA8iG53CmzuNvvVUw2VRkSw0ScZH4E+bCxbkJTcfB?= =?Windows-1252?Q?Q3niU0iy2oqsiZCM6kU667QWsDsF7QJKSWgewWkLLy1HuLLbfu5MsLnY?= =?Windows-1252?Q?eljJjI9hMyDI6S0DxgDxXZxpPOZwHMCQatXbtOTkLaCpjgFOlVQhHYCc?= =?Windows-1252?Q?nCndVFttBV/34MgxL8DbEcx3nv8Z71YNrya4lsPUVPMFDlFM8qi1gmsD?= =?Windows-1252?Q?Vn+FUHioqke+k62Lj7E617xZWolYjOWV/+Uj5kw2U++XTl2k3UcrXR6o?= =?Windows-1252?Q?R196wY5PyIk9yzSyECPZ/+onOh+x48l8NdzAbGLg/SPvGRBi9brfd07r?= =?Windows-1252?Q?b5Z?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2339;6:72KIjNnnURCMdbk/pBWOl1BuxJyBh8yy4ftGAZ38lpfZ6p+UB7LLaMWlEjyqP5OHhRBHN5enZ4Vya4uC/1So3bKXKj0jVeyd5yLyztii8N3h8fy4HqJ/Pvp/sqs//1cSWvfYMIw6418rQwqZN6vAxqN8vPW3rv2n/qNEYnXfCaNoyJbTIsHGg/Sn/BlhAo2HxB9X2WXT8AvyfoCOi3VDm6hpB27DzTZXLCS1ZZVU4hiM9nph+WhYDa0cGyImudMfJ9SM7UU+/6Pz91pAPHYH+bjlJ2EXwA761R6xCoKhspH+8k8UTvpkD3lX6hVV52S4k1uP4SzWS2RrafCFiFE9aA==;5:U9yxKCNOCNFBsEDO4Yzfll4ALWrfV9ljUgqObPuR+cR/iHWfOk4K1t3fmufYawlsTUZ0Gm77zbL7/IvBTk6mWynW5lNUi0w56u6QnqxEJ4WfAMKmPD6E3HEnyaUeYeuwNtWrhxmUFT5lCCCMxtzqYw==;24:jxepFP95M+T4/yuNRLf/cn7QT7eYmpkEABfphCQl31LojbyYVPMsqLy5Dr7/Zz2Ab2VgmGnLbIv81zfk0sPuZwdhNAbx8Y1XfMTe267vprI=;7:N6TaMlFdeW+z1O3S0NIPKUVoG0paj7G+c5aKuiBWqRD65XY/Y9h25j2AYEYC+XWdO3AYV9K8k2Wl3rg+y/STmoxCmcMHS9Hb5CFAYjDERpgn3aiBcY3kq50v8HNInpSd9bvqHxiwDS+9IQN8eJ7GeHZHeIKwAu3Un5ubzR9GbeddfxEo+0bMpvkdv5RGmr4cFa918sYFIeEMQvN9B/LEBn/V9bdNIWmGRNeSc/b6/9ljmwsaDqNbZH4zUV/tV3D1 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2339;20:Sbfb4sOM6Eifq+AAYzMfVKOLuhOr30I7ZD0jEKyN+SMa8Msf2v0d2w32K9sfpcAXV5Qe/yY/E0XYwLCPicZetObR0hseIr/g1qdIeorrdYqHQjNUWCxF6qX/tA+s4L0Zc6yS7HaLoukjJbVufFSdEkhFAzhEfvQlE5ur6BcnZUnbTLVVBJhTbxoMmvw3q19g8e2T9H/4pppN2Z0uXrgU6uEOO2kzzxGJ00zsjZB1bUTMk4LnWmVmiLn/a+vSlqa7 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2016 01:32:31.1245 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.225];Helo=[milsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2339 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/22/16 17:23, James Smart wrote: > + buf = kmalloc(len + 1, GFP_KERNEL); > + if (!buf) > + return -ENOMEM; > + memcpy(buf, s->from, len); > + buf[len] = '\0'; Hello James, Have you considered to combine the above kmalloc() and memcpy() calls into a single kasprintf(GFP_KERNEL, "%.*s", len, s->from) call? Bart.