From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14D4AECAAD8 for ; Wed, 21 Sep 2022 15:19:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229960AbiIUPTf (ORCPT ); Wed, 21 Sep 2022 11:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbiIUPTc (ORCPT ); Wed, 21 Sep 2022 11:19:32 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 544AFE8D for ; Wed, 21 Sep 2022 08:19:30 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id s6so9779718lfo.7 for ; Wed, 21 Sep 2022 08:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=0OQNwidXfglALVVRMIJX0eA8njvh8tvja1lgxaI+Bb8=; b=URPgkLc1/gEOLl+n4W6SG44A8sW0ivmUThd6wN1YUN4N6g3JnC2/j/1QYSftU7xaaz 2a+TEBvw2H3iWYXTihvWlTi4WbCu0Vx0ykuJev8WVHbHOupHTP1OpyE7hsGIraPkOlzE VL/eSNVkW8icU54So/jIoYxDwNz3+ICSus9RWWpHKwAbNdbDH4f+4A5KZx24rWjM2cfe DC43cw4b0n7Jc7ymx+0uemUcdX+w2/LCn/uF/sKKhaOD0DhlUjHfOEvxQcnjglcQSp+l wtLLoC6MS7jOht05JoAdVj4CwHafjJHlKGcXfrpHPgggnfD4HBk9MZSlVf6TRuYVkLme efaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=0OQNwidXfglALVVRMIJX0eA8njvh8tvja1lgxaI+Bb8=; b=e4JLzNiNjOGlP8hpTH1iklRMJHFtQGIOgox0i2ePsv0gSqFQUCjbKXhAbtHySlrBIU DhBoxNk+mm2iYIDZ9BQaGmBH15oIrpTqhIeZYRsF0aC0E1NmbiOnvU2TFu9Zvx7rnoVt 5cf6Rz48yD9YEN1x0KS90Y5U5Ch3Aw4ByqKW/tDbqHWVbLBQwyztE6SoiJClUjOUseiS jzUsqbLbkp3g8ErPb2BTUlhBgW2dm/ImOCuMb0us2+Oc9ojYmy/xaXNxrlkqJQxglNt9 FpT+FnbmMloUFnun+9V4HQzUUQMlqHv+Uo76KIIHi+mCkXzONdrJY+ooGIGoJO9Gm6X2 SEYQ== X-Gm-Message-State: ACrzQf2P37847qjGglgXA/YnvLRlWSiLFx5KE4uqwGzqr3D4f+gTct1r vJYbU8qD6cGEz/Ft1qI90rDfFQ== X-Google-Smtp-Source: AMsMyM5W8d7QEhX0GyaMcafFqQFoeDrLIcJcGcKbJeXZ90zLpEd3zhpdII+hyLJ5GGWSp/H+vapy2Q== X-Received: by 2002:a05:6512:3b8e:b0:49a:d2f4:6b7d with SMTP id g14-20020a0565123b8e00b0049ad2f46b7dmr9680650lfv.627.1663773567480; Wed, 21 Sep 2022 08:19:27 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id m6-20020a056512114600b004896ed8dce3sm485158lfg.2.2022.09.21.08.19.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Sep 2022 08:19:27 -0700 (PDT) Message-ID: <5e34eadc-ef6a-abeb-6bce-347593c275b7@linaro.org> Date: Wed, 21 Sep 2022 17:19:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/2] ASoC: wcd9335: fix order of Slimbus unprepare/disable To: Pierre-Louis Bossart , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Vinod Koul , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20220921145354.1683791-1-krzysztof.kozlowski@linaro.org> <20916c9d-3598-7c40-ee77-1148c3d2e4b1@linux.intel.com> <9a210b04-2ff2-df98-ad1a-89e9d8b0f686@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/09/2022 17:11, Pierre-Louis Bossart wrote: >>>> /** >>>> * slim_stream_unprepare() - Un-prepare a SLIMbus Stream >>>> * >>>> * @stream: instance of slim stream runtime to unprepare >>>> * >>>> * This API will un allocate all the ports and channels associated with >>>> * SLIMbus stream >>> >>> You mean this piece of doc? Indeed looks inaccurate. I'll update it. >> >> Wait, no, this is correct. Please point to what is wrong in kernel doc. >> I don't see it. :( > > the TRIGGER_STOP and TRIGGER_PAUSE_PUSH do the same thing. There is no > specific mapping of disable() to TRIGGER_STOP and unprepare() to > TRIGGER_PAUSE_PUSH as the documentation hints at. Which TRIGGER_STOP and TRIGGER_PAUSE_PUSH? In one specific codec driver? If yes, I don't think Slimbus documentation should care how actual users implement it (e.g. coalesce states). Best regards, Krzysztof