From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Zheng Yejian <zhengyejian1@huawei.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"mhiramat@kernel.org" <mhiramat@kernel.org>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH] blktrace: Gracefully return if fail in blk_register_tracepoints()
Date: Tue, 28 Mar 2023 17:58:24 +0000 [thread overview]
Message-ID: <5e3d8652-7cab-a6ea-a943-80950a0f9bed@nvidia.com> (raw)
In-Reply-To: <20230328094605.480557-1-zhengyejian1@huawei.com>
On 3/28/23 02:46, Zheng Yejian wrote:
> Currently blk_register_tracepoints() WARN for every registration failure
> of block tracepoint, however, blk_trace can still be setup-ed.
>
> It seems better to cleanup registered tracepoints and return error when
> a certain registration failed, even if it's a small probability, and
> users can know the error and do blk_trace setup again.
>
> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
> ---
>
So far I'm fine with current code as this adds a lot of code.
I've thought of doing this when I worked on blktrace extension, but
others are okay with it sure ..
-ck
prev parent reply other threads:[~2023-03-28 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 9:46 Zheng Yejian
2023-03-28 17:58 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e3d8652-7cab-a6ea-a943-80950a0f9bed@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=zhengyejian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®