From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750868AbdAWJWX (ORCPT ); Mon, 23 Jan 2017 04:22:23 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34984 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbdAWJWV (ORCPT ); Mon, 23 Jan 2017 04:22:21 -0500 Subject: Re: [PATCH 0/9] KVM: Fine-tuning for several function implementations To: SF Markus Elfring , kvm@vger.kernel.org, =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: Cc: LKML , kernel-janitors@vger.kernel.org From: Paolo Bonzini Message-ID: <5e40aa05-ccdf-0995-e1c4-a331d1da998a@redhat.com> Date: Mon, 23 Jan 2017 10:22:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/01/2017 19:09, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 22 Jan 2017 19:06:54 +0100 > > Several update suggestions were taken into account > from static source code analysis. Patches 1, 6 and 7 are acceptable. The others are useless churn or they make the result uselessly different from the rest of KVM code. Paolo > Markus Elfring (9): > Return directly after a failed copy_from_user() in kvm_vm_compat_ioctl() > Move error code settings in kvm_vm_ioctl() > Move error code settings in kvm_vcpu_compat_ioctl() > Move error code settings in kvm_vcpu_ioctl() > Improve size determinations in kvm_vcpu_ioctl() > Return an error code only as a constant in kvm_get_dirty_log_protect() > Return an error code only as a constant in kvm_get_dirty_log() > Adjust seven checks for null pointers > Improve another size determination in kvm_create_vm() > > virt/kvm/kvm_main.c | 278 +++++++++++++++++++++++----------------------------- > 1 file changed, 120 insertions(+), 158 deletions(-) >