From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6516B398FB6 for ; Thu, 4 Dec 2025 11:03:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764846189; cv=none; b=nH/m5jF4gTXq8Gbhd2rUAnHPcHoHx1weAv9PPTweIQbmTRZE7nclmZi+JC8VJehX/Coe/QdhQFuwyA1RbHSil77wQmJHJPFO/YnoEe6p8UAPuaAnc8TwzBAxk3VQQ9HlsWlfHGel1MWDhKgGLyn8VlFWiiTHUzSTOazH0RzbDmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764846189; c=relaxed/simple; bh=VWw56lfVUxbu7RmFqR4iJTg6Fr4OZGMCryvW1pHXJ74=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TkdTKYt6RBJj93y1+MgZB7DPzqn6P+9d2dA/Cz8GUeGoDpHnm/kiJ6kAcFXuSTdTL4KyZObPWdQx5O7NtKsNnz7tGYH31Rt/1+mdHKXPxWGd5twfGGEKOX5Gsh6GQzrvnTuOFbw8CVTPvtNqibwtBWGY83ttHxU+wwVgzcSIx/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fTJtstxT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fTJtstxT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B01B5C4CEFB; Thu, 4 Dec 2025 11:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764846188; bh=VWw56lfVUxbu7RmFqR4iJTg6Fr4OZGMCryvW1pHXJ74=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fTJtstxTd7DHTEktZHzCsbEJ6ZYJe7o1ugVino9CQ10qs+kObJb6NVapIn+Aem/NM 7sP/0tOxfL7E8LcIwVY1U471BCsA4Nz1kjsV6A6jZdBNTfIgXPFc3ttMdFgAW/3HWd 6lxLBXAjWAyKllKvrh4s2KHWSKxIwCnQrz6+9aeeLOMKuSqevqwZ+VDsHyZuwnjhh3 5dZtV5WUEiUKV8xaoB3+poV67kmozKb5v0q2BYZbE+ckYT/xjTljs74/EFy6BnDrws S5VD4A7ceq6aIf5UYc6UFJrKFWUcALSGfOD3TGHeqZJTNMB7Ku8SPqD1dTncvQbB0+ KAPvFs2DMa/JA== Message-ID: <5e40dd55-c9ea-4387-bd9b-7a4410df9898@kernel.org> Date: Thu, 4 Dec 2025 12:03:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [v2] mm: shmem: avoid build warning for CONFIG_SHMEM=n To: Mike Rapoport Cc: Arnd Bergmann , Hugh Dickins , Andrew Morton , Pratyush Yadav , Pasha Tatashin , Arnd Bergmann , Baolin Wang , Kairui Song , Christian Brauner , Lorenzo Stoakes , Kemeng Shi , Guo Weikang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20251204102905.1048000-1-arnd@kernel.org> <93782526-c198-4590-b96b-c4f630b8ecbb@kernel.org> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/4/25 11:55, Mike Rapoport wrote: > On Thu, Dec 04, 2025 at 11:34:24AM +0100, David Hildenbrand (Red Hat) wrote: >> On 12/4/25 11:28, Arnd Bergmann wrote: >>> From: Arnd Bergmann >>> >>> The newly added 'flags' variable is unused and causes a warning if >>> CONFIG_SHMEM is disabled, since the shmem_acct_size() macro it is passed >>> into does nothing: >>> >>> mm/shmem.c: In function '__shmem_file_setup': >>> mm/shmem.c:5816:23: error: unused variable 'flags' [-Werror=unused-variable] >>> 5816 | unsigned long flags = (vm_flags & VM_NORESERVE) ? SHMEM_F_NORESERVE : 0; >>> | ^~~~~ >>> >>> Replace the two macros with equivalent inline functions tto get the >>> argument checking. >>> >>> Fixes: 6ff1610ced56 ("mm: shmem: use SHMEM_F_* flags instead of VM_* flags") >> >> That's still not upstream, right? >> >> $ git tag --contains 6ff1610ced56 >> mm-everything-2025-11-29-19-43 >> mm-everything-2025-12-03-23-49 >> next-20251201 >> next-20251203 >> next-20251204 >> >> So we can likely just squash it into the problematic commit before >> proceeding with it? > > It's mm-nonmm-stable, I don't think fixups can go there. Ah, I only looked at mm-stable and mm-unstable. Confused why this is in nomm-stable and not mm-stable. Anyhow: Acked-by: David Hildenbrand (Red Hat) -- Cheers David