From: Joe Perches <joe@perches.com>
To: Johan Boger <jb@ip.fi>, jikos@kernel.org
Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: drivers: hid: hid-asus.c: Optimized input logic for keys
Date: Mon, 09 May 2022 06:54:51 -0700 [thread overview]
Message-ID: <5e44ef1302b722d3bf7fafe55111e76f7173e6be.camel@perches.com> (raw)
In-Reply-To: <20220509100258.24764-1-jb@ip.fi>
On Mon, 2022-05-09 at 12:02 +0200, Johan Boger wrote:
> Instead of calling asus_map_key_clear() function in each case,
> we now set a temporary value and clear it after default.
> Patch was checked by checkpatch and adjusted accordingly.
This patch subject is not correct. This is not a staging patch.
Your commit message is also incomplete as this is modifying comments,
changing whitespace, and changing brace styles.
and IMO:
Either use a single line case style like:
case foo: statement; break;
or use a multiple line case style like:
case foo:
statement;
break;
but please do not use a mixed case one line and statement; break;
on another like:
case foo:
statement; break;
Please remember checkpatch is only a guide, it's not the last word
on style where every message it emits requires an actual code change.
btw: there are _many_ single line case uses in the kernel
$ git grep -P 'case\s+\w+\s*:\s*\w+' -- '*.[ch]' | wc -l
7581
next prev parent reply other threads:[~2022-05-09 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 10:02 Johan Boger
2022-05-09 13:54 ` Joe Perches [this message]
2022-05-09 15:06 ` Johan Boger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e44ef1302b722d3bf7fafe55111e76f7173e6be.camel@perches.com \
--to=joe@perches.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jb@ip.fi \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®