mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Burton <paulburton@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: ralf@linux-mips.org, paulburton@kernel.org
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linux-mips@vger.kernel.org
Subject: Re: [PATCH] MIPS: VPE: Fix a double free and a memory leak in  'release_vpe()'
Date: Sat, 15 Feb 2020 14:56:00 -0800	[thread overview]
Message-ID: <5e487701.1c69fb81.107e8.b7f9@mx.google.com> (raw)
In-Reply-To: <20200202201922.22852-1-christophe.jaillet@wanadoo.fr>

Hello,

Christophe JAILLET wrote:
> Pointer on the memory allocated by 'alloc_progmem()' is stored in
> 'v->load_addr'. So this is this memory that should be freed by
> 'release_progmem()'.
> 
> 'release_progmem()' is only a call to 'kfree()'.
> 
> With the current code, there is both a double free and a memory leak.
> Fix it by passing the correct pointer to 'release_progmem()'.

Applied to mips-fixes.

> commit bef8e2dfceed
> https://git.kernel.org/mips/c/bef8e2dfceed
> 
> Fixes: e01402b115ccc ("More AP / SP bits for the 34K, the Malta bits and things. Still wants")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Paul Burton <paulburton@kernel.org>

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paulburton@kernel.org to report it. ]

      reply	other threads:[~2020-02-15 22:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-02 20:19 Christophe JAILLET
2020-02-15 22:56 ` Paul Burton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e487701.1c69fb81.107e8.b7f9@mx.google.com \
    --to=paulburton@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®