From: Florian Fainelli <f.fainelli@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, richardcochran@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: broadcom: Fix BCMGENET Kconfig
Date: Mon, 7 Nov 2022 12:43:18 -0800 [thread overview]
Message-ID: <5e4b19ca-fafe-dcda-332f-1c400c91b0a6@gmail.com> (raw)
In-Reply-To: <20221105090245.8508-1-yuehaibing@huawei.com>
On 11/5/22 02:02, YueHaibing wrote:
> While BCMGENET select BROADCOM_PHY as y, but PTP_1588_CLOCK_OPTIONAL is m,
> kconfig warning and build errors:
>
> WARNING: unmet direct dependencies detected for BROADCOM_PHY
> Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
> Selected by [y]:
> - BCMGENET [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && HAS_IOMEM [=y] && ARCH_BCM2835 [=y]
>
> drivers/net/phy/broadcom.o: In function `bcm54xx_suspend':
> broadcom.c:(.text+0x6ac): undefined reference to `bcm_ptp_stop'
> drivers/net/phy/broadcom.o: In function `bcm54xx_phy_probe':
> broadcom.c:(.text+0x784): undefined reference to `bcm_ptp_probe'
> drivers/net/phy/broadcom.o: In function `bcm54xx_config_init':
> broadcom.c:(.text+0xd4c): undefined reference to `bcm_ptp_config_init'
>
> Fixes: 99addbe31f55 ("net: broadcom: Select BROADCOM_PHY for BCMGENET")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@broadcom.com>
Thanks
--
Florian
next prev parent reply other threads:[~2022-11-07 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 9:02 YueHaibing
2022-11-07 20:43 ` Florian Fainelli [this message]
2022-11-08 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e4b19ca-fafe-dcda-332f-1c400c91b0a6@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®