From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D2EAEDEC73 for ; Wed, 13 Sep 2023 15:20:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237841AbjIMPUI (ORCPT ); Wed, 13 Sep 2023 11:20:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233184AbjIMPTf (ORCPT ); Wed, 13 Sep 2023 11:19:35 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4412BD; Wed, 13 Sep 2023 08:19:30 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38DEnsnh019322; Wed, 13 Sep 2023 15:18:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=DMmTuX4BUuWS71fg2UcymHdYuzTLXzic08tXaQHFJkE=; b=WKJFL+yVdMYVyWo+0mT5jzwKC14sNMa8xFF3QB8uIZkVOTAGBV+pYc+IHz4T4Ajr+s9R E9qSIkMrLyFXn860cgrx2nqnUJlKlg+UXGukFB7EZQsSYx56AmrdqoB7OKaJC5UPrmcR FVRVPYtVn3uv/34PIPn6qi6tSnZDv++gJnxThPAyw1UAghSI2Qn/VkH9UjK6Gu1CPsFf nRmM9XrE178nMeybkQmS17kclJ4soqJItMluEuit8poP2DsU6xjm9BdD2I1mJNqsyACE EA/kKAkXO6KAYZDhCAu2pi42eC9AEa1IGCoudSHHHEyKrtPozIlWXp16fCbVQucJUyCu PQ== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t2y8q1xfp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Sep 2023 15:18:48 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38DFIlhM025985 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Sep 2023 15:18:47 GMT Received: from [10.216.62.56] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Wed, 13 Sep 2023 08:18:34 -0700 Message-ID: <5e5359d0-6f32-7312-b344-2d84be63d03d@quicinc.com> Date: Wed, 13 Sep 2023 20:48:30 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver Content-Language: en-US To: Jeff Johnson , Krzysztof Kozlowski , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , References: <1694290578-17733-1-git-send-email-quic_mojha@quicinc.com> <1694290578-17733-7-git-send-email-quic_mojha@quicinc.com> <36d9bd32-7ea4-4d84-b1e9-3cfcc3bec85c@quicinc.com> From: Mukesh Ojha In-Reply-To: <36d9bd32-7ea4-4d84-b1e9-3cfcc3bec85c@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: fZxGkFPM9RluezOm5Frm40HM8FUFEa5k X-Proofpoint-GUID: fZxGkFPM9RluezOm5Frm40HM8FUFEa5k X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-13_08,2023-09-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309130124 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/12/2023 12:39 AM, Jeff Johnson wrote: > On 9/11/2023 4:07 AM, Krzysztof Kozlowski wrote: >> On 09/09/2023 22:16, Mukesh Ojha wrote: >>> +/** >>> + * qcom_minidump_region_register() - Register region in APSS >>> Minidump table. >>> + * @region: minidump region. >>> + * >>> + * Return: On success, it returns 0 and negative error value on >>> failure. >>> + */ >>> +int qcom_minidump_region_register(const struct qcom_minidump_region >>> *region) >>> +{ >>> +    struct minidump *md; >>> +    int ret; >>> + >>> +    md = qcom_smem_minidump_ready(); >>> +    if (!md) >>> +        return -EPROBE_DEFER; >>> + >>> +    if (!qcom_minidump_valid_region(region)) >>> +        return -EINVAL; >>> + >>> +    mutex_lock(&md->md_lock); >>> +    ret = qcom_md_region_register(md, region); >>> +    if (ret) >>> +        goto unlock; >>> + >>> +    qcom_md_update_elfheader(md, region); >>> +unlock: >>> +    mutex_unlock(&md->md_lock); >>> +    return ret; >>> +} >>> +EXPORT_SYMBOL_GPL(qcom_minidump_region_register); >> >> NAK, there is no user for this. >> >> Drop all exports from minidump drivers. Your upstream driver *must not* >> expose stuff to your vendor drivers. > > Do we not expect that upstream drivers would want to register? As of current version of patch, there is no user. Let's avoid till any upstream QCOM driver uses it . > Mind you, in the downstream code the following was a bad limitation: > #define MAX_NUM_OF_SS           10 I don't think, there is any problem with above macro, instead there is restriction on total number of APSS region can be registered. #define MAX_NUM_ENTRIES 201 -Mukesh > >